Skip to content

Commit 0007593

Browse files
authored
portsTab: sort telemetry, sensors, peripherals select lists (#3219)
* sort telemetry, sensors, peripherals select elements. disabledText on top * Update ports.js Ekstra comment
1 parent 78652bf commit 0007593

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/js/tabs/ports.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,13 +243,15 @@ ports.initialize = function (callback) {
243243
const selectElementSelector = `select[name=${selectElementName}]`;
244244
selectElement = functionsElement.find(selectElementSelector);
245245

246+
const disabledText = i18n.getMessage('portsTelemetryDisabled');
246247
if (selectElement.length === 0) {
247248
functionsElement.prepend(`<span class="function"><select name="${selectElementName}" /></span>`);
248249
selectElement = functionsElement.find(selectElementSelector);
249-
const disabledText = i18n.getMessage('portsTelemetryDisabled');
250250
selectElement.append(`<option value="">${disabledText}</option>`);
251251
}
252252
selectElement.append(`<option value="${functionName}">${functionRule.displayName}</option>`);
253+
// sort telemetry, sensors, peripherals select elements. disabledText on top
254+
selectElement.sortSelect(disabledText);
253255

254256
if (serialPort.functions.indexOf(functionName) >= 0) {
255257
selectElement.val(functionName);

0 commit comments

Comments
 (0)