CR review III

haslinghuis · haslinghuis · commit 2b8ff38691d5 · 2025-10-19T03:27:38.000+02:00
diff --git a/src/js/serial.js b/src/js/serial.js
@@ -92,7 +92,7 @@ class Serial extends EventTarget {
         let result = false;
         try {
             this._protocol = this.selectProtocol(path);
-            result = await this._protocol.connect(path, options, callback);
+            result = await this._protocol.connect(path, options);
         } catch (error) {
             console.error(`${this.logHead} Error during connection:`, error);
         }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ class Serial extends EventTarget {`
`92`	`92`	`let result = false;`
`93`	`93`	`try {`
`94`	`94`	`this._protocol = this.selectProtocol(path);`
`95`		`- result = await this._protocol.connect(path, options, callback);`
	`95`	`+ result = await this._protocol.connect(path, options);`
`96`	`96`	`} catch (error) {`
`97`	`97`	console.error(`${this.logHead} Error during connection:`, error);
`98`	`98`	`}`