compacted a few switch cases

Author: Tony Cabello

src/js/tabs/gps.js

@@ -48,6 +48,10 @@ TABS.gps.initialize = function (callback) {
             const lat = FC.GPS_DATA.lat / 10000000;
             const lon = FC.GPS_DATA.lon / 10000000;
             const url = `https://maps.google.com/?q=${lat},${lon}`;
+            const gnssArray = ['GPS', 'SBAS', 'Galileo', 'BeiDou', 'IMES', 'QZSS', 'Glonass'];
+            const qualityArray = ['no signal', 'searching', 'acquired', 'unusable', 'locked', 'fully locked', 'fully locked', 'fully locked'];
+            const usedArray = ['unused', 'used'];
+            const healthyArray = ['unknown', 'healthy', 'unhealthy', 'unknown'];
             let alt = FC.GPS_DATA.alt;
             if (semver.lt(FC.CONFIG.apiVersion, API_VERSION_1_39)) {
                 alt = alt / 10;
@@ -65,6 +69,7 @@ TABS.gps.initialize = function (callback) {
             const eSsTable = $('div.GPS_signal_strength table tr:not(.titles)');
 
             if (FC.GPS_DATA.chn.length <= 16) {
+                // Legacy code path: old BF firmware or old ublox module
                 for (let i = 0; i < FC.GPS_DATA.chn.length; i++) {
                     const row = eSsTable.eq(i);
 
@@ -74,6 +79,7 @@ TABS.gps.initialize = function (callback) {
                     //$('td', row).eq(3).text(' ');
                     $('td', row).eq(2).find('progress').val(FC.GPS_DATA.cno[i]);
                 }
+                // Cleanup the rest of the table
                 for (let i = FC.GPS_DATA.chn.length; i < 32; i++) {
                     const row = eSsTable.eq(i);
 
@@ -83,33 +89,14 @@ TABS.gps.initialize = function (callback) {
                     $('td', row).eq(2).find('progress').val(0);
                 }
             } else {
+                // M8N/M9N on newer firmware
                 for (let i = 0; i < FC.GPS_DATA.chn.length; i++) {
                     const row = eSsTable.eq(i);
 
-                    switch (FC.GPS_DATA.chn[i]) {
-                        case 0:
-                            $('td', row).eq(0).text('GPS');
-                            break;
-                        case 1:
-                            $('td', row).eq(0).text('SBAS');
-                            break;
-                        case 2:
-                            $('td', row).eq(0).text('Galileo');
-                            break;
-                        case 3:
-                            $('td', row).eq(0).text('BeiDou');
-                            break;
-                        case 4:
-                            $('td', row).eq(0).text('IMES');
-                            break;
-                        case 5:
-                            $('td', row).eq(0).text('QZSS');
-                            break;
-                        case 6:
-                            $('td', row).eq(0).text('GLO');
-                            break;
-                        default:
-                            $('td', row).eq(0).text('-');
+                    if (FC.GPS_DATA.chn[i] <= 6) {
+                        $('td', row).eq(0).text(gnssArray[FC.GPS_DATA.chn[i]]);
+                    } else {
+                        $('td', row).eq(0).text('-');
                     }
 
                     if (FC.GPS_DATA.chn[i] >= 7) {
@@ -119,49 +106,9 @@ TABS.gps.initialize = function (callback) {
                     } else {
                         $('td', row).eq(1).text(FC.GPS_DATA.svid[i]);
 
-                        let quality = '';
-                        switch (FC.GPS_DATA.quality[i] & 0x7) {
-                            case 0:
-                                quality = quality + 'no signal | ';
-                                break;
-                            case 1:
-                                quality = quality + 'searching | ';
-                                break;
-                            case 2:
-                                quality = quality + 'acquired | ';
-                                break;
-                            case 3:
-                                quality = quality + 'unusable | ';
-                                break;
-                            case 4:
-                                quality = quality + 'locked | ';
-                                break;
-                            default:
-                                quality = quality + 'fully locked | ';
-                                break;
-                        }
-
-                        let used = '';
-                        switch ((FC.GPS_DATA.quality[i] & 0x8) >> 3) {
-                            case 0:
-                                quality = quality + 'unused | ';
-                                break;
-                            case 1:
-                                quality = quality + 'used | ';
-                                break;
-                        }
-
-                        switch ((FC.GPS_DATA.quality[i] & 0x30) >> 4) {
-                            case 1:
-                                quality = quality + 'healthy';
-                                break;
-                            case 2:
-                                quality = quality + 'unhealthy';
-                                break;
-                            default:
-                                quality = quality + 'unknown';
-                                break;
-                        }
+                        var quality = qualityArray[FC.GPS_DATA.quality[i] & 0x7] + ' | ' +
+                                      usedArray[(FC.GPS_DATA.quality[i] & 0x8) >> 3] + '|' +
+                                      healthyArray[(FC.GPS_DATA.quality[i] & 0x30) >> 4];
 
                         $('td', row).eq(3).text(quality);
                         $('td', row).eq(2).find('progress').val(FC.GPS_DATA.cno[i]);