chore: add semi rule to the linter and run --fix

Adds semicolon to the linter rules.

Author: chmelevskij

.eslintrc.js

@@ -13,6 +13,7 @@ module.exports = {
     },
     rules: {
         "no-trailing-spaces": "error",
-        "eol-last": "error"
+        "eol-last": "error",
+        semi: "error"
     }
-};
+}

src/js/Analytics.js

@@ -87,16 +87,16 @@ const Analytics = function (trackingId, userId, appName, appVersion, changesetId
 Analytics.prototype.setDimension = function (dimension, value) {
     const dimensionName = `dimension${dimension}`;
     this._googleAnalytics.custom(dimensionName, value);
-}
+};
 
 Analytics.prototype.setMetric = function (metric, value) {
     const metricName = `metric${metric}`;
     this._googleAnalytics.custom(metricName, value);
-}
+};
 
 Analytics.prototype.sendEvent = function (category, action, options) {
     this._googleAnalytics.event(category, action, options);
-}
+};
 
 Analytics.prototype.sendChangeEvents = function (category, changeList) {
     for (const actionName in changeList) {
@@ -107,23 +107,23 @@ Analytics.prototype.sendChangeEvents = function (category, changeList) {
             }
         }
     }
-}
+};
 
 Analytics.prototype.sendAppView = function (viewName) {
     this._googleAnalytics.screenview(viewName);
-}
+};
 
 Analytics.prototype.sendTiming = function (category, timing, value) {
     this._googleAnalytics.timing(category, timing, value);
-}
+};
 
 Analytics.prototype.sendException = function (message) {
     this._googleAnalytics.exception(message);
-}
+};
 
 Analytics.prototype.setOptOut = function (optOut) {
     window['ga-disable-' + this._trackingId] = !!optOut;
-}
+};
 
 Analytics.prototype._rebuildFlightControllerEvent = function () {
     this.setDimension(this.DIMENSIONS.BOARD_TYPE, this._flightControllerData[this.DATA.BOARD_TYPE]);
@@ -137,36 +137,36 @@ Analytics.prototype._rebuildFlightControllerEvent = function () {
     this.setDimension(this.DIMENSIONS.BOARD_NAME, this._flightControllerData[this.DATA.BOARD_NAME]);
     this.setDimension(this.DIMENSIONS.MANUFACTURER_ID, this._flightControllerData[this.DATA.MANUFACTURER_ID]);
     this.setDimension(this.DIMENSIONS.MCU_TYPE, this._flightControllerData[this.DATA.MCU_TYPE]);
-}
+};
 
 Analytics.prototype.setFlightControllerData = function (property, value) {
     this._flightControllerData[property] = value;
 
     this._rebuildFlightControllerEvent();
-}
+};
 
 Analytics.prototype.resetFlightControllerData = function () {
     this._flightControllerData = {};
 
     this._rebuildFlightControllerEvent();
-}
+};
 
 Analytics.prototype._rebuildFirmwareEvent = function () {
     this.setDimension(this.DIMENSIONS.FIRMWARE_NAME, this._firmwareData[this.DATA.FIRMWARE_NAME]);
     this.setDimension(this.DIMENSIONS.FIRMWARE_SOURCE, this._firmwareData[this.DATA.FIRMWARE_SOURCE]);
     this.setDimension(this.DIMENSIONS.FIRMWARE_ERASE_ALL, this._firmwareData[this.DATA.FIRMWARE_ERASE_ALL]);
     this.setDimension(this.DIMENSIONS.FIRMWARE_CHANNEL, this._firmwareData[this.DATA.FIRMWARE_CHANNEL]);
     this.setMetric(this.METRICS.FIRMWARE_SIZE, this._firmwareData[this.DATA.FIRMWARE_SIZE]);
-}
+};
 
 Analytics.prototype.setFirmwareData = function (property, value) {
     this._firmwareData[property] = value;
 
     this._rebuildFirmwareEvent();
-}
+};
 
 Analytics.prototype.resetFirmwareData = function () {
     this._firmwareData = {};
 
     this._rebuildFirmwareEvent();
-}
+};

src/js/ConfigInserter.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const ConfigInserter = function () {
-}
+};
 
 const CUSTOM_DEFAULTS_POINTER_ADDRESS = 0x08002800;
 const BLOCK_SIZE = 16384;
@@ -102,4 +102,4 @@ ConfigInserter.prototype.insertConfig = function (firmware, input) {
     console.log(`Custom defaults inserted in: ${microtime() - timeParsingStart.toFixed(4)} seconds.`);
 
     return true;
-}
+};

src/js/ConfigStorage.js

@@ -38,4 +38,4 @@ const ConfigStorage = {
             window.localStorage.setItem(element, JSON.stringify(tmpObj));
         });
     }
-}
+};

src/js/Features.js

@@ -201,7 +201,7 @@ Features.prototype.findFeatureByBit = function (bit) {
             return feature;
         }
     }
-}
+};
 
 Features.prototype.updateData = function (featureElement) {
     const self = this;

src/js/TuningSliders.js

@@ -273,7 +273,7 @@ TuningSliders.updateFilterSlidersDisplay = function() {
         $('.tuningFilterSliders .sliderLabels tr:nth-child(2)').hide();
         this.sliderGyroFilter = true;
     } else {
-        $('.tuningFilterSliders .sliderLabels tr:nth-child(2)').show()
+        $('.tuningFilterSliders .sliderLabels tr:nth-child(2)').show();
         this.cachedGyroSliderValues = true;
     }
 

src/js/backup_restore.js

@@ -436,7 +436,7 @@ function configuration_restore(callback) {
         }
 
         if (configuration.apiVersion == undefined) {
-            configuration.apiVersion = "1.0.0" // a guess that will satisfy the rest of the code
+            configuration.apiVersion = "1.0.0"; // a guess that will satisfy the rest of the code
         }
         // apiVersion previously stored without patchlevel
         if (!semver.parse(configuration.apiVersion)) {

src/js/gui.js

@@ -126,7 +126,7 @@ GuiControl.prototype.interval_add_condition = function (name, code, interval, fi
             this.interval_remove(name);
         }
     }, interval, first);
-}
+};
 
 // name = string
 GuiControl.prototype.interval_remove = function (name) {

src/js/jenkins_loader.js

@@ -7,7 +7,7 @@ const JenkinsLoader = function (url) {
 
     this._jobsRequest = '/api/json?tree=jobs[name]';
     this._buildsRequest = '/api/json?tree=builds[number,result,timestamp,artifacts[relativePath],changeSet[items[commitId,msg]]]';
-}
+};
 
 JenkinsLoader.prototype.loadJobs = function (viewName, callback) {
     const self = this;
@@ -43,10 +43,10 @@ JenkinsLoader.prototype.loadJobs = function (viewName, callback) {
                 // remove Betaflight prefix, rename Betaflight job to Development
                 const jobs = jobsInfo.jobs.map(job => {
                     return { title: job.name.replace('Betaflight ', '').replace('Betaflight', 'Development'), name: job.name };
-                })
+                });
 
                 // cache loaded info
-                const object = {}
+                const object = {};
                 object[jobsDataTag] = jobs;
                 object[cacheLastUpdateTag] = $.now();
                 chrome.storage.local.set(object);
@@ -60,14 +60,14 @@ JenkinsLoader.prototype.loadJobs = function (viewName, callback) {
             cachedCallback();
         }
     });
-}
+};
 
 JenkinsLoader.prototype.loadBuilds = function (jobName, callback) {
     const self = this;
 
     const jobUrl = `${self._url}/job/${jobName}`;
     const buildsDataTag = `${jobUrl}BuildsData`;
-    const cacheLastUpdateTag = `${jobUrl}BuildsLastUpdate`
+    const cacheLastUpdateTag = `${jobUrl}BuildsLastUpdate`;
 
     chrome.storage.local.get([cacheLastUpdateTag, buildsDataTag], function (result) {
         const buildsDataTimestamp = $.now();
@@ -98,7 +98,7 @@ JenkinsLoader.prototype.loadBuilds = function (jobName, callback) {
                     }));
 
                 // cache loaded info
-                const object = {}
+                const object = {};
                 object[buildsDataTag] = builds;
                 object[cacheLastUpdateTag] = $.now();
                 chrome.storage.local.set(object);
@@ -112,7 +112,7 @@ JenkinsLoader.prototype.loadBuilds = function (jobName, callback) {
             cachedCallback();
         }
     });
-}
+};
 
 JenkinsLoader.prototype._parseBuilds = function (jobUrl, jobName, builds, callback) {
     // convert from `build -> targets` to `target -> builds` mapping
@@ -160,4 +160,4 @@ JenkinsLoader.prototype._parseBuilds = function (jobUrl, jobName, builds, callba
     });
 
     callback(targetBuilds);
-}
+};

src/js/msp/MSPHelper.js

@@ -845,7 +845,7 @@ MspHelper.prototype.process_data = function(dataHandler) {
                         const serialPort = {
                             identifier: data.readU8(),
                             scenario: data.readU8(),
-                        }
+                        };
                         FC.SERIAL_CONFIG.ports.push(serialPort);
                     }
                     FC.SERIAL_CONFIG.mspBaudRate = data.readU32();
@@ -1658,7 +1658,7 @@ MspHelper.prototype.process_data = function(dataHandler) {
             }
         }
     }
-}
+};
 
 /**
  * Encode the request body for the MSP request with the given code and return it as an array of bytes.
@@ -2330,7 +2330,7 @@ MspHelper.prototype.setRawRx = function(channels) {
     }
 
     MSP.send_message(MSPCodes.MSP_SET_RAW_RC, buffer, false);
-}
+};
 
 /**
  * Send a request to read a block of data from the dataflash at the given address and pass that address and a dataview
@@ -2568,7 +2568,7 @@ MspHelper.prototype.sendVoltageConfig = function(onCompleteCallback) {
         MSP.send_message(MSPCodes.MSP_SET_VOLTAGE_METER_CONFIG, buffer, false, nextFunction);
     }
 
-}
+};
 
 MspHelper.prototype.sendCurrentConfig = function(onCompleteCallback) {
 
@@ -2598,7 +2598,7 @@ MspHelper.prototype.sendCurrentConfig = function(onCompleteCallback) {
         MSP.send_message(MSPCodes.MSP_SET_CURRENT_METER_CONFIG, buffer, false, nextFunction);
     }
 
-}
+};
 
 MspHelper.prototype.sendLedStripConfig = function(onCompleteCallback) {
 
@@ -2688,7 +2688,7 @@ MspHelper.prototype.sendLedStripConfig = function(onCompleteCallback) {
 
         MSP.send_message(MSPCodes.MSP_SET_LED_STRIP_CONFIG, buffer, false, nextFunction);
     }
-}
+};
 
 MspHelper.prototype.sendLedStripColors = function(onCompleteCallback) {
     if (FC.LED_COLORS.length == 0) {
@@ -2703,7 +2703,7 @@ MspHelper.prototype.sendLedStripColors = function(onCompleteCallback) {
         }
         MSP.send_message(MSPCodes.MSP_SET_LED_COLORS, buffer, false, onCompleteCallback);
     }
-}
+};
 
 MspHelper.prototype.sendLedStripModeColors = function(onCompleteCallback) {
 
@@ -2733,7 +2733,7 @@ MspHelper.prototype.sendLedStripModeColors = function(onCompleteCallback) {
 
         MSP.send_message(MSPCodes.MSP_SET_LED_STRIP_MODECOLOR, buffer, false, nextFunction);
     }
-}
+};
 
 MspHelper.prototype.serialPortFunctionMaskToFunctions = function(functionMask) {
     const self = this;
@@ -2747,7 +2747,7 @@ MspHelper.prototype.serialPortFunctionMaskToFunctions = function(functionMask) {
         }
     }
     return functions;
-}
+};
 
 MspHelper.prototype.serialPortFunctionsToMask = function(functions) {
     const self = this;
@@ -2761,7 +2761,7 @@ MspHelper.prototype.serialPortFunctionsToMask = function(functions) {
         }
     }
     return mask;
-}
+};
 
 MspHelper.prototype.sendRxFailConfig = function(onCompleteCallback) {
     let nextFunction = send_next_rxfail_config;
@@ -2792,7 +2792,7 @@ MspHelper.prototype.sendRxFailConfig = function(onCompleteCallback) {
         }
         MSP.send_message(MSPCodes.MSP_SET_RXFAIL_CONFIG, buffer, false, nextFunction);
     }
-}
+};
 
 MspHelper.prototype.setArmingEnabled = function(doEnable, disableRunawayTakeoffPrevention, onCompleteCallback) {
     if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_37)
@@ -2822,7 +2822,7 @@ MspHelper.prototype.setArmingEnabled = function(doEnable, disableRunawayTakeoffP
             onCompleteCallback();
         }
     }
-}
+};
 
 MspHelper.prototype.loadSerialConfig = function(callback) {
     const mspCode = semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_43) ? MSPCodes.MSP2_COMMON_SERIAL_CONFIG : MSPCodes.MSP_CF_SERIAL_CONFIG;