Skip to content

Commit 72fc7b6

Browse files
committed
Created subtab for PID filters. Added filter setting to PID tuning tab.
1 parent abaf226 commit 72fc7b6

File tree

4 files changed

+616
-418
lines changed

4 files changed

+616
-418
lines changed

_locales/en/messages.json

Lines changed: 53 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -776,8 +776,11 @@
776776
"pidTuningUpgradeFirmwareToChangePidController": {
777777
"message": "<span style=\"color: red\">Changing PID controller disabled - you can change it via the CLI.</span> You have firmware with API version <span style=\"color: red\">$1</span>, but this functionality requires requires <span style=\"color: #ffbb00\">$2</span>."
778778
},
779-
"pidTuningName": {
780-
"message": "Name"
779+
"pidTuningSubTabPid": {
780+
"message": "PID Settings"
781+
},
782+
"pidTuningSubTabFilter": {
783+
"message": "Filter Settings"
781784
},
782785
"pidTuningShowAllPids": {
783786
"message": "Show all PIDs"
@@ -1623,18 +1626,54 @@
16231626
"pidTuningLevelHelp": {
16241627
"message": "The values below change the behaviour of the ANGLE and HORIZON flight modes. Different PID controllers handle the values differently. Please check the documentation."
16251628
},
1626-
"pidTuningLfpFilters": {
1627-
"message": "LFP Filters"
1628-
},
1629-
"pidTuningGyro": {
1630-
"message": "Gyro Soft (Hz)"
1631-
},
1632-
"pidTuningDTerm": {
1633-
"message": "D Term (Hz)"
1634-
},
1635-
"pidTuningYaw": {
1636-
"message": "Yaw (Hz)"
1637-
},
1629+
"pidTuningNonProfileFilterSettings": {
1630+
"message": "Profile independent Filter Settings"
1631+
},
1632+
"pidTuningGyroLowpassFrequency": {
1633+
"message": "Gyro Soft Lowpass Frequency (Hz)"
1634+
},
1635+
"pidTuningGyroLowpassFrequencyHelp": {
1636+
"message": "Gyro Soft Lowpass Frequency (Hz)"
1637+
},
1638+
"pidTuningGyroNotchFrequency": {
1639+
"message": "Gyro Notch Filter Frequency (Hz)"
1640+
},
1641+
"pidTuningGyroNotchFrequencyHelp": {
1642+
"message": "Gyro Notch Filter Frequency (Hz)"
1643+
},
1644+
"pidTuningGyroNotchCutoff": {
1645+
"message": "Gyro Notch Filter Cutoff Frequency (Hz)"
1646+
},
1647+
"pidTuningGyroNotchCutoffHelp": {
1648+
"message": "Gyro Notch Filter Cutoff Frequency (Hz)"
1649+
},
1650+
"pidTuningFilterSettings": {
1651+
"message": "Filter Settings"
1652+
},
1653+
"pidTuningDTermLowpassFrequency": {
1654+
"message": "D Term Lowpass Frequency (Hz)"
1655+
},
1656+
"pidTuningDTermLowpassFrequencyHelp": {
1657+
"message": "D Term Lowpass Frequency (Hz)"
1658+
},
1659+
"pidTuningDTermNotchFrequency": {
1660+
"message": "D Term Notch Filter Frequency (Hz)"
1661+
},
1662+
"pidTuningDTermNotchFrequencyHelp": {
1663+
"message": "D Term Notch Filter Frequency (Hz)"
1664+
},
1665+
"pidTuningDTermNotchCutoff": {
1666+
"message": "D Term Notch Filter Cutoff (Hz)"
1667+
},
1668+
"pidTuningDTermNotchCutoffHelp": {
1669+
"message": "D Term Notch Filter Cutoff (Hz)"
1670+
},
1671+
"pidTuningYawLowpassFrequency": {
1672+
"message": "Yaw Lowpass Frequency (Hz)"
1673+
},
1674+
"pidTuningYawLowpassFrequencyHelp": {
1675+
"message": "Yaw Lowpass Frequency (Hz)"
1676+
},
16381677
"pidTuningVbatPidCompensation": {
16391678
"message": "Vbat PID Compensation"
16401679
},

tabs/pid_tuning.css

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@
242242
padding: 5px;
243243
text-align: left;
244244
border-right: 1px solid #ccc;
245-
width: calc(100% -1px);
245+
width: calc(100% - 1px);
246246
}
247247

248248
.tab-pid_tuning .pid_titlebar th:first-child {
@@ -305,6 +305,33 @@
305305
border-radius: 0px;
306306
}
307307

308+
.tab-pid_tuning .tab_container {
309+
float: top;
310+
width: 300px;
311+
height: 20px;
312+
border-right-width: 0px;
313+
}
314+
315+
.tab-pid_tuning .tab_container td {
316+
background-color: #2e2e2e;
317+
}
318+
319+
.tab-pid_tuning .tab_container td a {
320+
color: #999999;
321+
}
322+
323+
.tab-pid_tuning .tab_container td.active {
324+
background-color: #ffbb00;
325+
color: #000;
326+
transition: none;
327+
}
328+
329+
.tab-pid_tuning .tab_container td.active a {
330+
background-color: #ffbb00;
331+
color: #000;
332+
text-shadow: 0px 1px rgba(255, 255, 255, 0.45);
333+
}
334+
308335
.tab-pid_tuning .single-field {
309336
display: inline-block;
310337
margin-bottom: 10px;
@@ -374,7 +401,7 @@
374401
border-bottom: 1px solid #ccc;
375402
color: #828282;
376403
/* font-family: 'open_sans', Arial; */
377-
background-image: linear-gradient(-45deg, rgba(255, 255, 255, .2) 10%, transparent 10%, transparent 20%, rgba(255, 255, 255, .2) 20%, rgba(255, 255, 255, .2) 30%, transparent 30%, transparent 40%, rgba(255, 255, 255, .2) 40%, rgba(255, 255, 255, .2) 50%, transparent 50%, transparent 60%, rgba(255, 255, 255, .2) 60%, rgba(255, 255, 255, .2) 70%, transparent 70%, transparent 80%, rgba(255, 255, 255, .2) 80%, rgba(255, 255, 255, .2) 90%, transparent 90%, transparent 100%, rgba(255, 255, 255, .2) 100%, transparent);
404+
background-image: linear-gradient(315deg, rgba(255, 255, 255, .2) 10%, transparent 10%, transparent 20%, rgba(255, 255, 255, .2) 20%, rgba(255, 255, 255, .2) 30%, transparent 30%, transparent 40%, rgba(255, 255, 255, .2) 40%, rgba(255, 255, 255, .2) 50%, transparent 50%, transparent 60%, rgba(255, 255, 255, .2) 60%, rgba(255, 255, 255, .2) 70%, transparent 70%, transparent 80%, rgba(255, 255, 255, .2) 80%, rgba(255, 255, 255, .2) 90%, transparent 90%, transparent 100%, rgba(255, 255, 255, .2) 100%, transparent);
378405
}
379406

380407
.fancy.header th {
@@ -383,7 +410,6 @@
383410
padding-left: 5px;
384411
}
385412

386-
387413
.pid_mode {
388414
width: calc(100% - 5px);
389415
height: 20px;
@@ -399,7 +425,7 @@
399425
border-bottom: 1px solid #ccc;
400426
color: #828282;
401427
font-family: 'open_sans', Arial;
402-
background-image: linear-gradient(-45deg, rgba(255, 255, 255, .2) 10%, transparent 10%, transparent 20%,
428+
background-image: linear-gradient(315deg, rgba(255, 255, 255, .2) 10%, transparent 10%, transparent 20%,
403429
rgba(255, 255, 255, .2) 20%, rgba(255, 255, 255, .2) 30%, transparent 30%, transparent 40%,
404430
rgba(255, 255, 255, .2) 40%, rgba(255, 255, 255, .2) 50%, transparent 50%, transparent 60%,
405431
rgba(255, 255, 255, .2) 60%, rgba(255, 255, 255, .2) 70%, transparent 70%, transparent 80%,

0 commit comments

Comments
 (0)