feat: use modules instead of global bindings (#3245)

Author: chmelevskij

.eslintrc.js

@@ -20,5 +20,25 @@ module.exports = {
         "no-var": "error",
         "prefer-template": "error",
         "template-curly-spacing": "error",
+        "no-undef": "error",
+        'no-duplicate-imports': 'error',
+    },
+    globals: {
+        d3: true,
+        THREE: true,
+        cordova: true,
+        cordovaUI: true,
+        ol: true,
+        wNumb: true,
+        ConfigStorage: true,
+        objectHash: true,
+        // start cordova bindings, remove after cordova is removed/replace/modularized
+        cordova_serial: true,
+        fileChooser: true,
+        i18n: true,
+        appReady: true,
+        cordovaChromeapi: true,
+        appAvailability: true,
+        // end cordova bindings
     },
 };

src/components/EscDshotDirection/EscDshotDirectionComponent.js

@@ -5,6 +5,7 @@ import EscDshotDirectionMotorDriver from "./EscDshotDirectionMotorDriver.js";
 import DshotCommand from "../../js/utils/DshotCommand.js";
 import FC from "../../js/fc.js";
 import { API_VERSION_1_44 } from '../../js/data_storage.js';
+import { getMixerImageSrc } from "../../js/utils/common.js";
 
 class EscDshotDirectionComponent
 {

src/components/MotorOutputReordering/MotorOutputReorderingComponent.js

@@ -6,6 +6,8 @@ import MSP from "../../js/msp";
 import MSPCodes from "../../js/msp/MSPCodes";
 import FC from "../../js/fc";
 import { gui_log } from "../../js/gui_log";
+import { i18n } from "../../js/localization";
+import GUI, { TABS } from "../../js/gui";
 
 export default class MotorOutputReorderComponent
 {

src/js/Analytics.js

@@ -1,3 +1,8 @@
+import ShortUniqueId from 'short-unique-id';
+import googleAnalytics from 'universal-ga';
+import { set as setConfig, get as getConfig } from './ConfigStorage';
+import GUI from './gui';
+import CONFIGURATOR from './data_storage';
 
 let tracking = null;
 export { tracking };
@@ -6,6 +11,66 @@ export function createAnalytics(ga, settings) {
     tracking = new Analytics(ga, settings);
 }
 
+function getBuildType() {
+    return GUI.Mode;
+}
+
+function setupAnalytics(result) {
+    let userId;
+    if (result.userId) {
+        userId = result.userId;
+    } else {
+        const uid = new ShortUniqueId();
+        userId = uid.randomUUID(13);
+
+        setConfig({ 'userId': userId });
+    }
+
+    const optOut = !!result.analyticsOptOut;
+    const checkForDebugVersions = !!result.checkForConfiguratorUnstableVersions;
+
+    const debugMode = typeof process === "object" && process.versions['nw-flavor'] === 'sdk';
+
+    const settings = {
+        trackingId: 'UA-123002063-1',
+        userId: userId,
+        appName:  CONFIGURATOR.productName,
+        appVersion: CONFIGURATOR.version,
+        gitRevision: CONFIGURATOR.gitRevision,
+        os: GUI.operating_system,
+        checkForDebugVersions: checkForDebugVersions,
+        optOut: optOut,
+        debugMode: debugMode,
+        buildType: getBuildType(),
+    };
+    createAnalytics(googleAnalytics, settings);
+    window.tracking = tracking;
+
+    function logException(exception) {
+        tracking.sendException(exception.stack);
+    }
+
+    if (typeof process === "object") {
+        process.on('uncaughtException', logException);
+    }
+
+    tracking.sendEvent(tracking.EVENT_CATEGORIES.APPLICATION, 'AppStart', { sessionControl: 'start' });
+
+    $('.connect_b a.connect').removeClass('disabled');
+    $('.firmware_b a.flash').removeClass('disabled');
+}
+
+export function checkSetupAnalytics(callback) {
+    if (!tracking) {
+        const result = getConfig(['userId', 'analyticsOptOut', 'checkForConfiguratorUnstableVersions' ]);
+        setupAnalytics(result);
+    }
+
+    if (callback) {
+        callback(tracking);
+    }
+}
+
 class Analytics {
 
     constructor (ga, settings) {

src/js/CliAutoComplete.js

@@ -1,6 +1,8 @@
 import GUI from './gui';
 import CONFIGURATOR from './data_storage';
 import FC from './fc';
+import semver from 'semver';
+import { tracking } from './Analytics';
 
 /**
  * Encapsulates the AutoComplete logic

src/js/DarkTheme.js

@@ -1,5 +1,6 @@
 import GUI from "./gui";
 import windowWatcherUtil from "./utils/window_watchers";
+import { checkSetupAnalytics } from "./Analytics";
 
 const css_dark = [
     './css/dark-theme.css',
@@ -65,4 +66,13 @@ DarkTheme.applyNormal = function () {
     css_dark.forEach((el) => $(`link[href="${el}"]`).prop('disabled', true));
 };
 
+
+export function setDarkTheme(enabled) {
+    DarkTheme.setConfig(enabled);
+
+    checkSetupAnalytics(function (analyticsService) {
+        analyticsService.sendEvent(analyticsService.EVENT_CATEGORIES.APPLICATION, 'DarkTheme', enabled);
+    });
+}
+
 export default DarkTheme;

src/js/Features.js

@@ -1,5 +1,7 @@
 import { bit_check, bit_set, bit_clear } from "./bit";
 import { API_VERSION_1_44 } from './data_storage';
+import semver from "semver";
+import { tracking } from "./Analytics";
 
 const Features = function (config) {
     const self = this;

src/js/LogoManager.js

@@ -1,5 +1,6 @@
 import { gui_log } from "./gui_log";
 import { i18n } from "./localization";
+import { checkChromeRuntimeError } from "./utils/common";
 
 /**
  * Takes an ImageData object and returns an MCM symbol as an array of strings.

src/js/RateCurve.js

@@ -1,5 +1,6 @@
 import FC from "./fc";
 import { API_VERSION_1_43 } from "./data_storage";
+import semver from "semver";
 
 const minRc = 1000;
 const midRc = 1500;

src/js/TuningSliders.js

@@ -2,6 +2,10 @@ import MSP from "./msp";
 import FC from "./fc";
 import MSPCodes from "./msp/MSPCodes";
 import { API_VERSION_1_44 } from './data_storage';
+import { isExpertModeEnabled } from "./utils/isExportModeEnabled";
+import semver from "semver";
+import { mspHelper } from "./msp/MSPHelper";
+import { TABS } from "./gui";
 
 const TuningSliders = {
     // Legacy Sliders