Skip to content

Commit 78287a1

Browse files
committed
Remove callback from set and remove
1 parent 128b024 commit 78287a1

File tree

3 files changed

+7
-15
lines changed

3 files changed

+7
-15
lines changed

src/js/ConfigStorage.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,14 @@ const ConfigStorage = {
3131
}
3232
},
3333
// set takes an object like {'userLanguageSelect':'DEFAULT'}
34-
set: function(input, callback) {
34+
set: function(input) {
3535
Object.keys(input).forEach(function (element) {
3636
const tmpObj = {};
3737
tmpObj[element] = input[element];
3838
window.localStorage.setItem(element, JSON.stringify(tmpObj));
3939
});
40-
if (callback) {
41-
callback();
42-
}
4340
},
44-
remove: function(item, callback) {
41+
remove: function(item) {
4542
window.localStorage.removeItem(item);
46-
if (callback) {
47-
callback();
48-
}
4943
}
5044
};

src/js/FirmwareCache.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,8 @@ let FirmwareCache = (function () {
8484
if (cached === null) {
8585
return;
8686
}
87-
ConfigStorage.remove(cacheKey, () => {
88-
onRemoveFromCache(cached.release);
89-
});
87+
ConfigStorage.remove(cacheKey);
88+
onRemoveFromCache(cached.release);
9089
});
9190
return oldest;
9291
};
@@ -143,9 +142,8 @@ let FirmwareCache = (function () {
143142
release: release,
144143
hexdata: hexdata,
145144
};
146-
ConfigStorage.set(obj, () => {
147-
onPutToCache(release);
148-
});
145+
ConfigStorage.set(obj);
146+
onPutToCache(release);
149147
}
150148

151149
/**

src/js/release_checker.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ ReleaseChecker.prototype.loadReleaseData = function (processFunction) {
2222
const data = {};
2323
data[self._releaseDataTag] = releaseData;
2424
data[self._releaseLastUpdateTag] = releaseDataTimestamp;
25-
ConfigStorage.set(data, function () {});
25+
ConfigStorage.set(data);
2626

2727
self._processReleaseData(releaseData, processFunction);
2828
}).fail(function (data) {

0 commit comments

Comments
 (0)