Skip to content

Commit 9240349

Browse files
authored
Merge pull request #2673 from Asizon/fix_feedforward_options
Fix new feedforwardgroup options
2 parents df0e600 + bb2e75a commit 9240349

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

src/js/fc.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,8 @@ const FC = {
512512
feedforward_averaging: 0,
513513
feedforward_smooth_factor: 0,
514514
feedforward_boost: 0,
515+
feedforward_max_rate_limit: 0,
516+
feedforward_jitter_factor: 0,
515517
vbat_sag_compensation: 0,
516518
thrustLinearization: 0,
517519
};

src/js/tabs/pid_tuning.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -552,8 +552,6 @@ TABS.pid_tuning.initialize = function (callback) {
552552
} else {
553553
$('.vbatSagCompensation').hide();
554554
$('.thrustLinearization').hide();
555-
$('.feedforwardMaxRateLimit').hide();
556-
$('.feedforwardJitterFactor').hide();
557555

558556
if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_40)) {
559557
$('.pid_tuning .ROLL input[name="f"]').val(FC.ADVANCED_TUNING.feedforwardRoll > 0 ? FC.ADVANCED_TUNING.feedforwardRoll : PID_DEFAULT[4]);
@@ -1352,6 +1350,8 @@ TABS.pid_tuning.initialize = function (callback) {
13521350
FC.ADVANCED_TUNING.feedforward_averaging = $('select[id="feedforwardAveraging"]').val();
13531351
FC.ADVANCED_TUNING.feedforward_smooth_factor = parseInt($('input[name="feedforwardSmoothFactor"]').val());
13541352
FC.ADVANCED_TUNING.feedforward_boost = parseInt($('input[name="feedforwardBoost"]').val());
1353+
FC.ADVANCED_TUNING.feedforward_max_rate_limit = parseInt($('input[name="feedforwardMaxRateLimit"]').val());
1354+
FC.ADVANCED_TUNING.feedforward_jitter_factor = parseInt($('input[name="feedforwardJitterFactor"]').val());
13551355
FC.FILTER_CONFIG.dyn_lpf_curve_expo = parseInt($('.pid_filter input[name="dtermLowpassDynExpo"]').val());
13561356
FC.ADVANCED_TUNING.vbat_sag_compensation = $('input[id="vbatSagCompensation"]').is(':checked') ? parseInt($('input[name="vbatSagValue"]').val()) : 0;
13571357
FC.ADVANCED_TUNING.thrustLinearization = $('input[id="thrustLinearization"]').is(':checked') ? parseInt($('input[name="thrustLinearValue"]').val()) : 0;

src/tabs/pid_tuning.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@
605605
<div class="helpicon cf_tip" i18n_title="pidTuningFeedforwardGroupHelp"></div>
606606
<span i18n="pidTuningFeedforwardGroup"></span>
607607

608-
<span class="feedforwardJitterFactor suboption">
608+
<span class="feedforwardOption feedforwardJitterFactor suboption">
609609
<input type="number" name="feedforwardJitterFactor" step="1" min="0" max="20"/>
610610
<label>
611611
<span i18n="pidTuningFeedforwardJitter"></span>
@@ -639,7 +639,7 @@
639639
</label>
640640
</span>
641641

642-
<span class="feedforwardMaxRateLimit suboption">
642+
<span class="feedforwardOption feedforwardMaxRateLimit suboption">
643643
<input type="number" name="feedforwardMaxRateLimit" step="1" min="0" max="150"/>
644644
<label>
645645
<span i18n="pidTuningFeedforwardMaxRateLimit"></span>

0 commit comments

Comments
 (0)