Fix: Handle BT-11 BLE boards (#4547)

* Fix: Update characteristic UUID to match

* Fix: Update connectionId assignment and optimize handleNotification

* Fix: Handle 0xff crc fails

* Cleanup: Remove debug logging

* Refactor: Enhance error handling in WebBluetooth send method

* Fix: Implement handling for BT-11 corruption only

* Cleanup: Remove loghead

* Nitpick: Update src/js/msp.js

Co-authored-by: Copilot <[email protected]>

* Nitpick: Update src/js/msp.js

Co-authored-by: Copilot <[email protected]>

* Refactor: Use specific CRC corruption property

* Refactor: Move bluetooth-specific code, separate CRC bypass function

* Refactor: Move CRC bypass to WebBluetooth as well

* Refactor: Move further remains to WebBluetooth

* Refactor: Bring logHead back

---------

Co-authored-by: Copilot <[email protected]>

Author: VitroidFPV

src/js/msp.js

@@ -263,10 +263,14 @@ const MSP = {
         this.message_buffer = new ArrayBuffer(this.message_length_expected);
         this.message_buffer_uint8_view = new Uint8Array(this.message_buffer);
     },
+
     _dispatch_message(expectedChecksum) {
         if (this.message_checksum === expectedChecksum) {
             // message received, store dataview
             this.dataView = new DataView(this.message_buffer, 0, this.message_length_expected);
+        } else if (serial._webBluetooth.shouldBypassCrc(expectedChecksum)) {
+            this.dataView = new DataView(this.message_buffer, 0, this.message_length_expected);
+            this.crcError = false; // Override the CRC error for this specific case
         } else {
             this.packet_error++;
             this.crcError = true;

src/js/protocols/WebBluetooth.js

@@ -35,6 +35,8 @@ class WebBluetooth extends EventTarget {
 
         this.bluetooth = navigator?.bluetooth;
 
+        this.bt11_crc_corruption_logged = false;
+
         if (!this.bluetooth) {
             console.error(`${this.logHead} Web Bluetooth API not supported`);
             return;
@@ -88,6 +90,37 @@ class WebBluetooth extends EventTarget {
         };
     }
 
+    isBT11CorruptionPattern(expectedChecksum) {
+        if (expectedChecksum !== 0xff || this.message_checksum === 0xff) {
+            return false;
+        }
+
+        if (!this.connected) {
+            return false;
+        }
+
+        const deviceDescription = this.deviceDescription;
+        if (!deviceDescription) {
+            return false;
+        }
+
+        return deviceDescription?.susceptibleToCrcCorruption ?? false;
+    }
+
+    shouldBypassCrc(expectedChecksum) {
+        // Special handling for specific BT-11/CC2541 checksum corruption
+        // Only apply workaround for known problematic devices
+        const isBT11Device = this.isBT11CorruptionPattern(expectedChecksum);
+        if (isBT11Device) {
+            if (!this.bt11_crc_corruption_logged) {
+                console.log(`${this.logHead} Detected BT-11/CC2541 CRC corruption (0xff), skipping CRC check`);
+                this.bt11_crc_corruption_logged = true;
+            }
+            return true;
+        }
+        return false;
+    }
+
     async loadDevices() {
         try {
             const devices = await this.getDevices();
@@ -163,7 +196,7 @@ class WebBluetooth extends EventTarget {
 
         if (connectionInfo && !this.openCanceled) {
             this.connected = true;
-            this.connectionId = this.device.port;
+            this.connectionId = path;
             this.bitrate = options.baudRate;
             this.bytesReceived = 0;
             this.bytesSent = 0;
@@ -177,11 +210,9 @@ class WebBluetooth extends EventTarget {
 
             this.dispatchEvent(new CustomEvent("connect", { detail: connectionInfo }));
         } else if (connectionInfo && this.openCanceled) {
-            this.connectionId = this.device.port;
+            this.connectionId = path;
 
-            console.log(
-                `${this.logHead} Connection opened with ID: ${connectionInfo.connectionId}, but request was canceled, disconnecting`,
-            );
+            console.log(`${this.logHead} Connection opened with ID: ${path}, but request was canceled, disconnecting`);
             // some bluetooth dongles/dongle drivers really doesn't like to be closed instantly, adding a small delay
             setTimeout(() => {
                 this.openRequested = false;
@@ -260,11 +291,11 @@ class WebBluetooth extends EventTarget {
     }
 
     handleNotification(event) {
-        const buffer = new Uint8Array(event.target.value.byteLength);
-
-        for (let i = 0; i < event.target.value.byteLength; i++) {
-            buffer[i] = event.target.value.getUint8(i);
-        }
+        // Create a proper Uint8Array directly from the DataView buffer
+        const dataView = event.target.value;
+        const buffer = new Uint8Array(
+            dataView.buffer.slice(dataView.byteOffset, dataView.byteOffset + dataView.byteLength),
+        );
 
         // Dispatch immediately instead of using setTimeout to avoid race conditions
         this.dispatchEvent(new CustomEvent("receive", { detail: buffer }));
@@ -312,6 +343,7 @@ class WebBluetooth extends EventTarget {
                 this.readCharacteristic = false;
                 this.deviceDescription = false;
                 this.device = null;
+                this.bt11_crc_corruption_logged = false;
             }
         };
 
@@ -339,14 +371,24 @@ class WebBluetooth extends EventTarget {
     }
 
     async send(data, cb) {
-        if (!this.writeCharacteristic) {
+        if (!this.writeCharacteristic || typeof this.writeCharacteristic.writeValue !== "function") {
+            if (cb) {
+                cb({
+                    error: "No write characteristic available or characteristic is invalid",
+                    bytesSent: 0,
+                });
+            }
+            console.error(`${this.logHead} No write characteristic available or characteristic is invalid`);
+            return;
+        }
+        if (!this.device?.gatt?.connected) {
             if (cb) {
                 cb({
-                    error: "No write characteristic available",
+                    error: "GATT Server is disconnected. Cannot perform GATT operations.",
                     bytesSent: 0,
                 });
             }
-            console.error(`${this.logHead} No write characteristic available`);
+            console.error(`${this.logHead} GATT Server is disconnected. Cannot perform GATT operations.`);
             return;
         }
 

src/js/protocols/devices.js

@@ -3,7 +3,8 @@ export const bluetoothDevices = [
         name: "CC2541",
         serviceUuid: "0000ffe0-0000-1000-8000-00805f9b34fb",
         writeCharacteristic: "0000ffe1-0000-1000-8000-00805f9b34fb",
-        readCharacteristic: "0000ffe1-0000-1000-8000-00805f9b34fb",
+        readCharacteristic: "0000ffe2-0000-1000-8000-00805f9b34fb",
+        susceptibleToCrcCorruption: true,
     },
     {
         name: "HC-05",