queue baSED ATTEMPT

Author: ctzsnooze

src/js/tabs/onboard_logging.js

@@ -480,7 +480,6 @@ onboard_logging.initialize = function (callback) {
         if (GUI.connected_to) {
             self.blockSize = self.BLOCK_SIZE;
 
-            // Begin by refreshing the occupied size in case it changed while the tab was open
             flash_update_summary(function () {
                 const maxBytes = FC.DATAFLASH.usedSize;
 
@@ -491,61 +490,14 @@ onboard_logging.initialize = function (callback) {
 
                     show_saving_dialog();
 
-                    // START PATCH: minimal retry for null/missing blocks
                     const MAX_SIMPLE_RETRIES = 5;
-                    const RETRY_BACKOFF_MS = 30; // 30 ms delay for retries
+                    const RETRY_BACKOFF_MS = 30;
                     let simpleRetryCount = 0;
 
-                    const startTime = new Date().getTime(); // Start timestamp
+                    const startTime = new Date().getTime();
 
                     function onChunkRead(chunkAddress, chunkDataView, bytesCompressed) {
-                        if (chunkDataView && chunkDataView.byteLength > 0) {
-                            // Reset retry counter after a good block
-                            simpleRetryCount = 0;
-
-                            // --- ORIGINAL BLOCK WRITE LOGIC ---
-                            const blob = new Blob([chunkDataView]);
-                            FileSystem.writeChunk(openedFile, blob);
-
-                            nextAddress += chunkDataView.byteLength;
-
-                            if (typeof bytesCompressed === "number") {
-                                if (totalBytesCompressed == null) totalBytesCompressed = 0;
-                                totalBytesCompressed += bytesCompressed;
-                            }
-
-                            $(".dataflash-saving progress").attr("value", (nextAddress / maxBytes) * 100);
-
-                            if (saveCancelled || nextAddress >= maxBytes) {
-                                mark_saving_dialog_done(startTime, nextAddress, totalBytesCompressed);
-                                FileSystem.closeFile(openedFile);
-                            } else {
-                                mspHelper.dataflashRead(nextAddress, self.blockSize, onChunkRead);
-                            }
-                            // --- END ORIGINAL LOGIC ---
-                        } else if (chunkDataView && chunkDataView.byteLength === 0) {
-                            // Zero-length block → EOF
-                            mark_saving_dialog_done(startTime, nextAddress, totalBytesCompressed);
-                            FileSystem.closeFile(openedFile);
-                        } else {
-                            // Null/missing block
-                            if (simpleRetryCount < MAX_SIMPLE_RETRIES) {
-                                simpleRetryCount++;
-                                if (simpleRetryCount % 2 === 1) {
-                                    console.warn(`Null/missing block at ${nextAddress}, retry ${simpleRetryCount}`);
-                                }
-                                setTimeout(() => {
-                                    mspHelper.dataflashRead(nextAddress, self.blockSize, onChunkRead);
-                                }, RETRY_BACKOFF_MS);
-                            } else {
-                                console.error(
-                                    `Skipping null block at ${nextAddress} after ${MAX_SIMPLE_RETRIES} retries`,
-                                );
-                                nextAddress += self.blockSize; // Move to next block only after retries exhausted
-                                simpleRetryCount = 0;
-                                mspHelper.dataflashRead(nextAddress, self.blockSize, onChunkRead);
-                            }
-                        }
+                        // ... all recursive logic ...
                     }
 
                     // Fetch the initial block
@@ -556,7 +508,7 @@ onboard_logging.initialize = function (callback) {
                 });
             });
         }
-    }
+    } // <-- this is the exact end of flash_save_begin
 
     function prepare_file(onComplete) {
         const prefix = "BLACKBOX_LOG";