Skip to content

Commit cc93eb5

Browse files
authored
Improve debugging of MSP code (#3274)
Disables GA debugging
1 parent 7c6f90b commit cc93eb5

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/js/Analytics.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ function setupAnalytics(result) {
4040
os: GUI.operating_system,
4141
checkForDebugVersions: checkForDebugVersions,
4242
optOut: optOut,
43-
debugMode: debugMode,
43+
// debugMode: debugMode, // enable when debugging GA
4444
buildType: getBuildType(),
4545
};
4646
createAnalytics(googleAnalytics, settings);

src/js/msp/MSPHelper.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,9 @@ function MspHelper() {
9494
};
9595
}
9696

97+
function getMSPCodeName(code) {
98+
return Object.keys(MSPCodes).find(key => MSPCodes[key] === code);
99+
}
97100

98101
MspHelper.readPidSliderSettings = function(data) {
99102
FC.TUNING_SLIDERS.slider_pids_mode = data.readU8();
@@ -1581,17 +1584,17 @@ MspHelper.prototype.process_data = function(dataHandler) {
15811584
break;
15821585

15831586
default:
1584-
console.log(`Unknown code detected: ${code}`);
1587+
console.log(`Unknown code detected: ${code} (${getMSPCodeName(code)})`);
15851588
} else {
1586-
console.log(`FC reports unsupported message error: ${code}`);
1589+
console.log(`FC reports unsupported message error: ${code} (${getMSPCodeName(code)})`);
15871590

15881591
if (code === MSPCodes.MSP_SET_REBOOT) {
15891592
TABS.onboard_logging.mscRebootFailedCallback();
15901593
}
15911594
}
15921595

15931596
} else {
1594-
console.warn(`code: ${code} - crc failed`);
1597+
console.warn(`code: ${code} (${getMSPCodeName(code)}) - crc failed`);
15951598
}
15961599
// trigger callbacks, cleanup/remove callback after trigger
15971600
for (let i = dataHandler.callbacks.length - 1; i >= 0; i--) { // iterating in reverse because we use .splice which modifies array length

0 commit comments

Comments
 (0)