@@ -466,7 +466,7 @@ function debug(done) {
466466 buildNWAppsWrapper ( platforms , 'sdk' , DEBUG_DIR , done ) ;
467467}
468468
469- function injectARMCache ( flavor , callback ) {
469+ function injectARMCache ( flavor , done ) {
470470 const flavorPostfix = `-${ flavor } ` ;
471471 const flavorDownloadPostfix = flavor !== 'normal' ? `-${ flavor } ` : '' ;
472472 clean_cache ( ) . then ( function ( ) {
@@ -529,7 +529,7 @@ function injectARMCache(flavor, callback) {
529529 clean_debug ( ) ;
530530 process . exit ( 1 ) ;
531531 }
532- callback ( ) ;
532+ done ( ) ;
533533 }
534534 ) ;
535535 }
@@ -593,10 +593,10 @@ function buildNWApps(platforms, flavor, dir, done) {
593593
594594function getGitRevision ( done , callback , isReleaseBuild ) {
595595 let gitRevision = 'norevision' ;
596- git . diff ( [ '--shortstat' ] , function ( err , diff ) {
597- if ( ! err && ! diff ) {
598- git . log ( [ '-1' , '--pretty=format:%h' ] , function ( err , rev ) {
599- if ( ! err ) {
596+ git . diff ( [ '--shortstat' ] , function ( err1 , diff ) {
597+ if ( ! err1 && ! diff ) {
598+ git . log ( [ '-1' , '--pretty=format:%h' ] , function ( err2 , rev ) {
599+ if ( ! err2 ) {
600600 gitRevision = rev . latest . hash ;
601601 }
602602
@@ -990,7 +990,7 @@ function cordova_packagejson() {
990990}
991991
992992function cordova_configxml_internal ( ) {
993- let androidName = metadata . packageId . replace ( NAME_REGEX , '_' ) ;
993+ const androidName = metadata . packageId . replace ( NAME_REGEX , '_' ) ;
994994
995995 return gulp . src ( [ `${ CORDOVA_DIST_DIR } config.xml` ] )
996996 . pipe ( xmlTransformer ( [
@@ -1009,7 +1009,7 @@ function cordova_debug_configxml() {
10091009 return cordova_configxml_internal ( ) ;
10101010}
10111011
1012- function cordova_configxml ( callback ) {
1012+ function cordova_configxml ( done ) {
10131013 return gulp . series ( function version_prompt ( ) {
10141014 return gulp . src ( '.' )
10151015 . pipe ( prompt . prompt ( {
@@ -1021,7 +1021,7 @@ function cordova_configxml(callback) {
10211021 metadata . version = res . version ;
10221022 }
10231023 } ) ) ;
1024- } , cordova_configxml_internal ) ( callback ) ;
1024+ } , cordova_configxml_internal ) ( done ) ;
10251025}
10261026
10271027function cordova_rename_build_json ( ) {
@@ -1030,7 +1030,7 @@ function cordova_rename_build_json() {
10301030 . pipe ( gulp . dest ( CORDOVA_DIST_DIR ) ) ;
10311031}
10321032
1033- function cordova_browserify ( callback ) {
1033+ function cordova_browserify ( done ) {
10341034 const readFile = function ( file ) {
10351035 return new Promise ( function ( resolve ) {
10361036 if ( ! file . includes ( "node_modules" ) ) {
@@ -1048,7 +1048,7 @@ function cordova_browserify(callback) {
10481048 glob ( `${ CORDOVA_DIST_DIR } www/**/*.js` , { } , function ( err , files ) {
10491049 const readLoop = function ( ) {
10501050 if ( files . length === 0 ) {
1051- callback ( ) ;
1051+ done ( ) ;
10521052 } else {
10531053 const file = files . pop ( ) ;
10541054 readFile ( file ) . then ( function ( ) {
@@ -1087,7 +1087,7 @@ function cordova_debug() {
10871087 cordova . run ( ) ;
10881088}
10891089
1090- function cordova_debug_build ( cb ) {
1090+ function cordova_debug_build ( done ) {
10911091 cordova . build ( {
10921092 'platforms' : [ 'android' ] ,
10931093 'options' : {
@@ -1096,13 +1096,14 @@ function cordova_debug_build(cb) {
10961096 } ,
10971097 } ) . then ( function ( ) {
10981098 process . chdir ( '../' ) ;
1099- cb ( ) ;
1100- } ) ;
11011099
1102- console . log ( 'APK will be generated at dist_cordova/platforms/android/app/build/outputs/apk/release/app-release.apk' ) ;
1100+ console . log ( 'APK has been generated at dist_cordova/platforms/android/app/build/outputs/apk/release/app-release.apk' ) ;
1101+
1102+ done ( ) ;
1103+ } ) ;
11031104}
11041105
1105- function cordova_build ( callback ) {
1106+ function cordova_build ( done ) {
11061107 let storePassword = '' ;
11071108 return gulp . series ( function password_prompt ( ) {
11081109 return gulp . src ( '.' )
@@ -1119,11 +1120,11 @@ function cordova_build(callback) {
11191120 'android' : {
11201121 'release' : {
11211122 'storePassword' : storePassword ,
1122- }
1123- }
1123+ } ,
1124+ } ,
11241125 } ) )
11251126 . pipe ( gulp . dest ( './' ) ) ;
1126- } , function build ( cb ) {
1127+ } , function build ( done ) {
11271128 return cordova . build ( {
11281129 'platforms' : [ 'android' ] ,
11291130 'options' : {
@@ -1134,24 +1135,28 @@ function cordova_build(callback) {
11341135 // Delete the file containing the store password
11351136 del ( [ 'build.json' ] , { force : true } ) ;
11361137 process . chdir ( '../' ) ;
1137- cb ( ) ;
1138- } ) ;
1139- } ) ( callback ) ;
11401138
1141- console . log ( 'AAB will be generated at dist_cordova/platforms/android/app/build/outputs/bundle/release/app.aab' ) ;
1139+ console . log ( 'AAB has been generated at dist_cordova/platforms/android/app/build/outputs/bundle/release/app.aab' ) ;
1140+ done ( ) ;
1141+ } ) ;
1142+ } ) ( done ) ;
11421143}
11431144
11441145async function cordova_debug_release ( ) {
1145- const filename = await getReleaseFilename ( 'android' , 'apk' ) ;
1146+ const filename = getReleaseFilename ( 'android' , 'apk' ) ;
1147+
11461148 console . log ( `Release APK : release/${ filename } ` ) ;
1149+
11471150 return gulp . src ( `${ CORDOVA_DIST_DIR } platforms/android/app/build/outputs/apk/debug/app-debug.apk` )
11481151 . pipe ( rename ( filename ) )
11491152 . pipe ( gulp . dest ( RELEASE_DIR ) ) ;
11501153}
11511154
11521155async function cordova_release ( ) {
1153- const filename = await getReleaseFilename ( 'android' , 'aab' ) ;
1156+ const filename = getReleaseFilename ( 'android' , 'aab' ) ;
1157+
11541158 console . log ( `Release AAB : release/${ filename } ` ) ;
1159+
11551160 return gulp . src ( `${ CORDOVA_DIST_DIR } platforms/android/app/build/outputs/bundle/release/app.aab` )
11561161 . pipe ( rename ( filename ) )
11571162 . pipe ( gulp . dest ( RELEASE_DIR ) ) ;
0 commit comments