Skip to content

Commit eed2958

Browse files
authored
Merge pull request #234 from mikeller/revert_pid_to_pidf_rename
Reverted the blanket rename from PID to PIDF.
2 parents 0af1d15 + 3c4e79b commit eed2958

File tree

3 files changed

+33
-33
lines changed

3 files changed

+33
-33
lines changed

js/flightlog.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ function FlightLog(logData) {
573573
destFrame[fieldIndex++] = attitude.pitch;
574574
destFrame[fieldIndex++] = attitude.heading;
575575

576-
// Add the PIDF sum (P+I+D+F)
576+
// Add the Feedforward PID sum (P+I+D+F)
577577
for (var axis = 0; axis < 3; axis++) {
578578
destFrame[fieldIndex++] =
579579
(axisPID[axis][0] !== undefined ? srcFrame[axisPID[axis][0]] : 0) +

js/flightlog_fields_presenter.js

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -6,37 +6,37 @@ function FlightLogFieldPresenter() {
66
(function() {
77
var FRIENDLY_FIELD_NAMES = {
88

9-
'axisP[all]': 'PIDF P',
10-
'axisP[0]': 'PIDF P [roll]',
11-
'axisP[1]': 'PIDF P [pitch]',
12-
'axisP[2]': 'PIDF P [yaw]',
13-
14-
'axisI[all]': 'PIDF I',
15-
'axisI[0]': 'PIDF I [roll]',
16-
'axisI[1]': 'PIDF I [pitch]',
17-
'axisI[2]': 'PIDF I [yaw]',
18-
19-
'axisD[all]': 'PIDF D',
20-
'axisD[0]': 'PIDF D [roll]',
21-
'axisD[1]': 'PIDF D [pitch]',
22-
'axisD[2]': 'PIDF D [yaw]',
23-
24-
'axisF[all]': 'PIDF F',
25-
'axisF[0]': 'PIDF F [roll]',
26-
'axisF[1]': 'PIDF F [pitch]',
27-
'axisF[2]': 'PIDF F [yaw]',
9+
'axisP[all]': 'PID P',
10+
'axisP[0]': 'PID P [roll]',
11+
'axisP[1]': 'PID P [pitch]',
12+
'axisP[2]': 'PID P [yaw]',
13+
14+
'axisI[all]': 'PID I',
15+
'axisI[0]': 'PID I [roll]',
16+
'axisI[1]': 'PID I [pitch]',
17+
'axisI[2]': 'PID I [yaw]',
18+
19+
'axisD[all]': 'PID D',
20+
'axisD[0]': 'PID D [roll]',
21+
'axisD[1]': 'PID D [pitch]',
22+
'axisD[2]': 'PID D [yaw]',
23+
24+
'axisF[all]': 'PID Feedforward',
25+
'axisF[0]': 'PID Feedforward [roll]',
26+
'axisF[1]': 'PID Feedforward [pitch]',
27+
'axisF[2]': 'PID Feedforward [yaw]',
2828

2929
//Virtual field
30-
'axisSum[all]': 'PIDF Sum',
31-
'axisSum[0]' : 'PIDF Sum [roll]',
32-
'axisSum[1]' : 'PIDF Sum [pitch]',
33-
'axisSum[2]' : 'PIDF Sum [yaw]',
30+
'axisSum[all]': 'PID Sum',
31+
'axisSum[0]' : 'PID Sum [roll]',
32+
'axisSum[1]' : 'PID Sum [pitch]',
33+
'axisSum[2]' : 'PID Sum [yaw]',
3434

3535
//Virtual field
36-
'axisError[all]': 'PIDF Error',
37-
'axisError[0]' : 'PIDF Error [roll]',
38-
'axisError[1]' : 'PIDF Error [pitch]',
39-
'axisError[2]' : 'PIDF Error [yaw]',
36+
'axisError[all]': 'PID Error',
37+
'axisError[0]' : 'PID Error [roll]',
38+
'axisError[1]' : 'PID Error [pitch]',
39+
'axisError[2]' : 'PID Error [yaw]',
4040

4141
//Virtual field
4242
'rcCommands[all]': 'RC Rates',

js/graph_config.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,23 +191,23 @@ GraphConfig.load = function(config) {
191191
fields: ["rcCommand[all]"]
192192
},
193193
{
194-
label: "PIDFs",
194+
label: "PIDs",
195195
fields: ["axisSum[all]"]
196196
},
197197
{
198-
label: "PIDF Error",
198+
label: "PID Error",
199199
fields: ["axisError[all]"]
200200
},
201201
{
202-
label: "Gyro + PIDF roll",
202+
label: "Gyro + PID roll",
203203
fields: ["axisP[0]", "axisI[0]", "axisD[0]", "axisF[0]", "gyroADC[0]"]
204204
},
205205
{
206-
label: "Gyro + PIDF pitch",
206+
label: "Gyro + PID pitch",
207207
fields: ["axisP[1]", "axisI[1]", "axisD[1]", "axisF[1]", "gyroADC[1]"]
208208
},
209209
{
210-
label: "Gyro + PIDF yaw",
210+
label: "Gyro + PID yaw",
211211
fields: ["axisP[2]", "axisI[2]", "axisD[2]", "axisF[2]", "gyroADC[2]"]
212212
},
213213
{

0 commit comments

Comments
 (0)