Skip to content

Update confifix: correct PINIO2 assignment, redefine as 12V BEC switch #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2025
Merged

Update confifix: correct PINIO2 assignment, redefine as 12V BEC switch #933

merged 3 commits into from
Oct 25, 2025

Conversation

@Greypang
Copy link
Contributor

@Greypang Greypang commented Oct 23, 2025 •
edited by coderabbitai bot
Loading

Updated the pin mapping: previously assigned PINIO2 IO pin was incorrect.
PINIO2 has been redefined as the 12V BEC power switch control.
17611822027592

Summary by CodeRabbit

  • New Features

    • Added "CAM 1,2" and "12V BEC OFF" user controls for the GEPRC TAKER H743 MINI.

  • Configuration

    • Updated IO pin assignments and control/box mappings to align hardware controls with the new options and improve IO behavior.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments

Walkthrough

Update GEPRC_TAKER_H743MINI board macros: remap PINIO2 pin, adjust PINIO1 config, add PINIO2 config, change PINIO box indices, and introduce two BOX_USER name macros.

Changes

Cohort / File(s) Change Summary
GEPRC TAKER H743MINI board config
configs/GEPRC_TAKER_H743MINI/config.h		 PINIO2_PIN changed from PC14 to PD3; PINIO1_CONFIG changed from 129 to 1; PINIO2_CONFIG added = 129; PINIO1_BOX changed from 0 to 40; PINIO2_BOX changed from 40 to 41; added BOX_USER1_NAME = "CAM 1,2" and BOX_USER2_NAME = "12V BEC OFF"; removed obsolete prior box defs.

Sequence Diagram(s)

(omitted — changes are limited to configuration macros, no control-flow changes)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • nerdCopter
  • blckmn

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is minimal and does not follow the required template structure defined for this repository. The template specifies mandatory requirements including hardware compliance verification, a formal checklist with items such as schematics review, hardware testing, guideline compliance, and other housekeeping items. The provided description only includes a brief technical explanation and a diagram, completely omitting the required checklist, hardware compliance statements, and other mandatory sections outlined in the template.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "Update confifix: correct PINIO2 assignment, redefine as 12V BEC switch" is specific and directly related to the main changes in the changeset. The title accurately captures the primary objective of correcting the PINIO2 pin assignment (from PC14 to PD3) and redefining it as a 12V BEC power switch control, which aligns with the macro updates visible in the file changes (PINIO2_BOX changed to 41, and BOX_USER2_NAME added as "12V BEC OFF").
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis added the Bugfix Fixes a problem label Oct 23, 2025
haslinghuis
haslinghuis reviewed Oct 23, 2025
View reviewed changes
@haslinghuis haslinghuis requested a review from ot0tot October 24, 2025 00:26
ot0tot
ot0tot reviewed Oct 24, 2025
View reviewed changes
@haslinghuis haslinghuis merged commit ed47b35 into betaflight:master Oct 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ot0tot ot0tot ot0tot left review comments

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@Greypang Greypang

Labels

Bugfix Fixes a problem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Greypang @haslinghuis @ot0tot @nerdCopter