Skip to content

Fix HGLRC H743 Lite PINIO #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

Fix HGLRC H743 Lite PINIO #937

merged 1 commit into from
Oct 29, 2025

Conversation

@ot0tot
Copy link
Contributor

@ot0tot ot0tot commented Oct 29, 2025 •
edited by coderabbitai bot
Loading

PINIOs were revised when changing to the Lite target.

Summary by CodeRabbit

  • Chores
    • Updated GPIO pin assignments for the HGLRC_H743_LITE board.
    • Consolidated I/O pin definitions for streamlined hardware configuration.
    • Added 12V BEC power output label.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025 •
edited
Loading

Walkthrough

Configuration update for the HGLRC H743 Lite board that changes the primary IO pin from PE2 to PC13, removes three unused IO pin definitions, and introduces a user-facing label "12V BEC" for the primary pin configuration.

Changes

Cohort / File(s) Summary
HGLRC H743 Lite board configuration
configs/HGLRC_H743_LITE/config.h		 Changed PINIO1_PIN from PE2 to PC13; removed PINIO2/3/4 pin and config macros; removed BOX_USER3/4 labels; added BOX_USER1_NAME as "12V BEC"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify that PC13 is a valid and available pin for the H743 Lite board
  • Confirm that removal of PINIO2–PINIO4 definitions does not break existing functionality or dependent configurations
  • Check that BOX_USER1_NAME labeling correctly maps to PINIO1_BOX usage

Possibly related PRs

Suggested labels

Bugfix

Suggested reviewers

  • haslinghuis
  • nerdCopter

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is extremely minimal, consisting of only a single sentence ("PINIOs were revised when changing to the Lite target"), and does not follow the provided template structure in any way. The template specifies mandatory requirements including hardware compliance statements, links to design guidelines, a detailed checklist with hardware testing and review items, and housekeeping notes. The submitted description lacks all of these required elements and provides insufficient detail for reviewers to assess the PR comprehensively. Even if this PR represents a configuration update rather than a new flight controller submission, the description remains incomplete relative to the template structure. The author should expand the PR description to follow the provided template structure more closely, including clarification of the changes' scope, why the PINIO revision was necessary, and relevant checklist items. At minimum, the description should provide more context about what specific hardware issues or design revisions necessitated these configuration changes and whether this PR represents a new hardware submission or a configuration fix for an existing target.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Fix HGLRC H743 Lite PINIO" directly relates to the primary change in the PR, which involves revising programmable input/output (PINIO) pin configurations for the HGLRC H743 Lite hardware target. The title is concise and specific enough that a developer scanning the commit history would understand the change concerns PINIO configuration updates for this particular hardware. While the word "Fix" could be more descriptive about what specifically was corrected, the title clearly identifies the main component affected and the hardware involved.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ot0tot-patch-3
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a09185f and 14063d0.

📒 Files selected for processing (1)
  • configs/HGLRC_H743_LITE/config.h (1 hunks)
🔇 Additional comments (1)
configs/HGLRC_H743_LITE/config.h (1)

116-119: Approve the PINIO configuration changes; verify pin assignment separately.

The removal of PINIO2-4 definitions is safe. The search found no references to these macros within configs/HGLRC_H743_LITE/config.h itself, indicating this is an isolated board-specific simplification from 4 pins to 1. Other boards retain their PINIO2+ configurations unaffected. The addition of BOX_USER1_NAME "12V BEC" improves UI clarity.

However, independently verify that PC13 is the correct pin for 12V BEC control on the H743 Lite hardware schematic.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis added the Bugfix Fixes a problem label Oct 29, 2025
@haslinghuis haslinghuis merged commit da73cd2 into master Oct 29, 2025
2 checks passed
@haslinghuis haslinghuis deleted the ot0tot-patch-3 branch October 29, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@ot0tot ot0tot

Labels

Bugfix Fixes a problem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ot0tot @haslinghuis @nerdCopter