Remove Rack::HttpStreamingResponse monkey-patch by upgrading rack-proxy

- In v0.5.14 Rack::HttpStreamingResponse#read_timeout= was added, see ncr/rack-proxy@42e32e3
- Easier to upgrade dependency than to maintain patching of external dependency

Author: janraasch

lib/rack/reverse_proxy.rb

@@ -3,7 +3,6 @@
 require "rack-proxy"
 require "rack/reverse_proxy_matcher"
 require "rack/exception"
-require "rack/reverse_proxy/http_streaming_response"
 
 module Rack
   class ReverseProxy
@@ -77,7 +76,7 @@ def proxy(env, source_request, matcher)
       target_response = HttpStreamingResponse.new(target_request, uri.host, uri.port)
 
       # pass the timeout configuration through
-      target_response.set_read_timeout(options[:timeout]) if options[:timeout].to_i > 0
+      target_response.read_timeout = options[:timeout] if options[:timeout].to_i > 0
 
       target_response.use_ssl = "https" == uri.scheme
 

lib/rack/reverse_proxy/http_streaming_response.rb

@@ -14,5 +14,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "guard-bundler"
 
   s.add_dependency "rack", ">= 1.0.0"
-  s.add_dependency "rack-proxy", "~> 0.5"
+  s.add_dependency "rack-proxy", "~> 0.5", ">= 0.5.14"
 end

rack-reverse-proxy.gemspec

@@ -145,7 +145,7 @@ def app
 
       it "should make request with basic auth" do
         stub_request(:get, "http://example.com/test/slow")
-        Rack::HttpStreamingResponse.any_instance.should_receive(:set_read_timeout).with(99)
+        Rack::HttpStreamingResponse.any_instance.should_receive(:read_timeout=).with(99)
         get '/test/slow'
       end
     end
@@ -159,7 +159,7 @@ def app
 
       it "should make request with basic auth" do
         stub_request(:get, "http://example.com/test/slow")
-        Rack::HttpStreamingResponse.any_instance.should_not_receive(:set_read_timeout)
+        Rack::HttpStreamingResponse.any_instance.should_not_receive(:read_timeout=)
         get '/test/slow'
       end
     end