Merge pull request jaswope#46 from jjb/do-not-replace-location-without-host

Do not replace location without host

Author: waterlink

lib/rack_reverse_proxy/roundtrip.rb

@@ -179,7 +179,7 @@ def response_location
     end
 
     def need_replace_location?
-      response_headers["Location"] && options[:replace_response_host]
+      response_headers["Location"] && options[:replace_response_host] && response_location.host
     end
 
     def setup_request

spec/rack/reverse_proxy_spec.rb

@@ -322,7 +322,7 @@ def app
       end
     end
 
-    describe "with preserve response host turned on" do
+    describe "with replace response host turned on" do
       def app
         Rack::ReverseProxy.new(dummy_app) do
           reverse_proxy "/test", "http://example.com/", :replace_response_host => true
@@ -354,6 +354,14 @@ def app
         get "https://example.com/test/stuff"
         expect(last_response.headers["location"]).to eq("https://example.com/bar")
       end
+
+      it "doesn't replaces the location response header if it has no host" do
+        stub_request(:get, "http://example.com/test/stuff").to_return(
+          :headers => { "location" => "/bar" }
+        )
+        get "http://example.com/test/stuff"
+        expect(last_response.headers["location"]).to eq("/bar")
+      end
     end
 
     describe "with ambiguous routes and all matching" do