Satisfy rubocop

Author: waterlink

Gemfile

@@ -2,22 +2,17 @@ source "https://rubygems.org"
 
 gemspec
 
-RUBOCOP_PLATFORMS = [:ruby_20, :ruby_21, :ruby_22]
-
 ruby_version = RUBY_VERSION.to_f
-if ruby_version < 2.0  # 1.9.3 and 1.8.7
-  RUBOCOP_PLATFORMS = [:ruby_20, :ruby_21]
-end
+rubocop_platform = [:ruby_20, :ruby_21, :ruby_22]
+rubocop_platform = [:ruby_20, :ruby_21] if ruby_version < 2.0
 
 group :test do
   gem "rspec"
   gem "rack-test"
   gem "webmock"
-  gem "rubocop", :platform => RUBOCOP_PLATFORMS
+  gem "rubocop", :platform => rubocop_platform
 
-  if ruby_version < 1.9  # 1.8.7
-    gem "addressable", "< 2.4"
-  end
+  gem "addressable", "< 2.4" if ruby_version < 1.9
 end
 
 group :development, :test do

lib/rack_reverse_proxy/middleware.rb

@@ -32,7 +32,7 @@ def reverse_proxy_options(options)
 
     def reverse_proxy(rule, url = nil, opts = {})
       if rule.is_a?(String) && url.is_a?(String) && URI(url).class == URI::Generic
-        fail Errors::GenericURI.new, url
+        raise Errors::GenericURI.new, url
       end
       @rules << Rule.new(rule, url, opts)
     end

lib/rack_reverse_proxy/response_builder.rb

@@ -1,8 +1,10 @@
 module RackReverseProxy
+  # ResponseBuilder knows target response building process
   class ResponseBuilder
     def initialize(target_request, uri, options)
-      @target_request, @uri, @options =
-        target_request, uri, options
+      @target_request = target_request
+      @uri = uri
+      @options = options
     end
 
     def fetch
@@ -42,7 +44,7 @@ def handle_verify_mode
     end
 
     def verify_mode?
-      !!options[:verify_mode]
+      options.key?(:verify_mode)
     end
 
     def target_response

lib/rack_reverse_proxy/roundtrip.rb

@@ -7,7 +7,7 @@ module RackReverseProxy
   # RoundTrip represents one request-response made by rack-reverse-proxy
   # middleware.
   class RoundTrip
-    def initialize(app, env, global_options, rules, response_builder_klass=ResponseBuilder)
+    def initialize(app, env, global_options, rules, response_builder_klass = ResponseBuilder)
       @app = app
       @env = env
       @global_options = global_options
@@ -92,7 +92,7 @@ def host_header
     def set_forwarded_host
       return unless options[:x_forwarded_host]
       target_request_headers["X-Forwarded-Host"] = source_request.host
-      target_request_headers["X-Forwarded-Port"] = "#{source_request.port}"
+      target_request_headers["X-Forwarded-Port"] = source_request.port.to_s
     end
 
     def initialize_http_header
@@ -253,7 +253,7 @@ def matches
 
     def non_ambiguous_match
       return unless ambiguous_match?
-      fail Errors::AmbiguousMatch.new(path, matches)
+      raise Errors::AmbiguousMatch.new(path, matches)
     end
 
     def ambiguous_match?

lib/rack_reverse_proxy/rule.rb

@@ -48,7 +48,7 @@ def build_matcher(spec)
       return /^#{spec}/ if spec.is_a?(String)
       return spec if spec.respond_to?(:match)
       return spec if spec.respond_to?(:call)
-      fail ArgumentError, "Invalid Rule for reverse_proxy"
+      raise ArgumentError, "Invalid Rule for reverse_proxy"
     end
 
     # Candidate represents a request being matched

lib/rack_reverse_proxy/version.rb

@@ -1,4 +1,4 @@
 #:nodoc:
 module RackReverseProxy
-  VERSION = "0.9.1"
+  VERSION = "0.9.1".freeze
 end

spec/rack/reverse_proxy_spec.rb

@@ -460,7 +460,7 @@ def app
       #:nodoc:
       class Matcher
         def self.match(path)
-          return unless path.match(%r{^/(test|users)})
+          return unless path =~ %r{^/(test|users)}
           Matcher.new
         end
 
@@ -504,7 +504,7 @@ def initialize(rackreq)
         end
 
         def self.match(path, _headers, rackreq)
-          return nil unless path.match(%r{^/(test|users)})
+          return nil unless path =~ %r{^/(test|users)}
           RequestMatcher.new(rackreq)
         end