Add Turbo Stream validation handling (#1007)

## Summary
- return Turbo Stream validation errors across controllers
- provide placeholders in forms for error updates

## Testing
- `bundle exec rubocop` *(fails: command not found)*
- `bundle exec brakeman -q -w2` *(fails: command not found)*
- `bundle exec bundler-audit --update` *(fails: command not found)*
- `bin/codex_style_guard` *(fails: command not found)*
- `bin/ci` *(fails: command not found: rails)*

------
https://chatgpt.com/codex/tasks/task_e_689b64ccac4483218114fa7ee4d9d596

Author: rsmithlal

app/controllers/better_together/conversations_controller.rb

@@ -35,9 +35,13 @@ def create # rubocop:todo Metrics/MethodLength, Metrics/AbcSize
       else
         respond_to do |format|
           format.turbo_stream do
-            render :create_error, status: :unprocessable_entity
+            render turbo_stream: turbo_stream.update(
+              'form_errors',
+              partial: 'layouts/better_together/errors',
+              locals: { object: @conversation }
+            )
           end
-          format.html { render :new, status: :unprocessable_entity }
+          format.html { render :new }
         end
       end
     end

app/controllers/better_together/geography/continents_controller.rb

@@ -22,22 +22,40 @@ def new
       def edit; end
 
       # POST /geography/continents
-      def create
+      def create # rubocop:todo Metrics/MethodLength
         @geography_continent = Geography::Continent.new(geography_continent_params)
 
         if @geography_continent.save
           redirect_to @geography_continent, notice: 'Continent was successfully created.'
         else
-          render :new, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_continent }
+              )
+            end
+            format.html { render :new, status: :unprocessable_entity }
+          end
         end
       end
 
       # PATCH/PUT /geography/continents/1
-      def update
+      def update # rubocop:todo Metrics/MethodLength
         if @geography_continent.update(geography_continent_params)
           redirect_to @geography_continent, notice: 'Continent was successfully updated.', status: :see_other
         else
-          render :edit, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_continent }
+              )
+            end
+            format.html { render :edit, status: :unprocessable_entity }
+          end
         end
       end
 

app/controllers/better_together/geography/countries_controller.rb

@@ -28,23 +28,41 @@ def new
       def edit; end
 
       # POST /geography/countries
-      def create
+      def create # rubocop:todo Metrics/MethodLength
         @geography_country = resource_class.new(geography_country_params)
         authorize_geography_country
 
         if @geography_country.save
           redirect_to @geography_country, notice: 'Country was successfully created.', status: :see_other
         else
-          render :new, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_country }
+              )
+            end
+            format.html { render :new, status: :unprocessable_entity }
+          end
         end
       end
 
       # PATCH/PUT /geography/countries/1
-      def update
+      def update # rubocop:todo Metrics/MethodLength
         if @geography_country.update(geography_country_params)
           redirect_to @geography_country, notice: 'Country was successfully updated.', status: :see_other
         else
-          render :edit, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_country }
+              )
+            end
+            format.html { render :edit, status: :unprocessable_entity }
+          end
         end
       end
 

app/controllers/better_together/geography/region_settlements_controller.rb

@@ -22,23 +22,41 @@ def new
       def edit; end
 
       # POST /geography/region_settlements
-      def create
+      def create # rubocop:todo Metrics/MethodLength
         @geography_region_settlement = Geography::RegionSettlement.new(geography_region_settlement_params)
 
         if @geography_region_settlement.save
           redirect_to @geography_region_settlement, notice: 'Region settlement was successfully created.'
         else
-          render :new, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_region_settlement }
+              )
+            end
+            format.html { render :new, status: :unprocessable_entity }
+          end
         end
       end
 
       # PATCH/PUT /geography/region_settlements/1
-      def update
+      def update # rubocop:todo Metrics/MethodLength
         if @geography_region_settlement.update(geography_region_settlement_params)
           redirect_to @geography_region_settlement, notice: 'Region settlement was successfully updated.',
                                                     status: :see_other
         else
-          render :edit, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_region_settlement }
+              )
+            end
+            format.html { render :edit, status: :unprocessable_entity }
+          end
         end
       end
 

app/controllers/better_together/geography/regions_controller.rb

@@ -28,23 +28,41 @@ def new
       def edit; end
 
       # POST /geography/regions
-      def create
+      def create # rubocop:todo Metrics/MethodLength
         @geography_region = resource_class.new(geography_region_params)
         authorize_geography_region
 
         if @geography_region.save
           redirect_to @geography_region, notice: 'Region was successfully created.'
         else
-          render :new, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_region }
+              )
+            end
+            format.html { render :new, status: :unprocessable_entity }
+          end
         end
       end
 
       # PATCH/PUT /geography/regions/1
-      def update
+      def update # rubocop:todo Metrics/MethodLength
         if @geography_region.update(geography_region_params)
           redirect_to @geography_region, notice: 'Region was successfully updated.', status: :see_other
         else
-          render :edit, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_region }
+              )
+            end
+            format.html { render :edit, status: :unprocessable_entity }
+          end
         end
       end
 

app/controllers/better_together/geography/settlements_controller.rb

@@ -28,23 +28,41 @@ def new
       def edit; end
 
       # POST /geography/settlements
-      def create
+      def create # rubocop:todo Metrics/MethodLength
         @geography_settlement = resource_class.new(geography_settlement_params)
         authorize_geography_settlement
 
         if @geography_settlement.save
           redirect_to @geography_settlement, notice: 'Settlement was successfully created.'
         else
-          render :new, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_settlement }
+              )
+            end
+            format.html { render :new, status: :unprocessable_entity }
+          end
         end
       end
 
       # PATCH/PUT /geography/settlements/1
-      def update
+      def update # rubocop:todo Metrics/MethodLength
         if @geography_settlement.update(geography_settlement_params)
           redirect_to @geography_settlement, notice: 'Settlement was successfully updated.', status: :see_other
         else
-          render :edit, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_settlement }
+              )
+            end
+            format.html { render :edit, status: :unprocessable_entity }
+          end
         end
       end
 

app/controllers/better_together/geography/states_controller.rb

@@ -26,23 +26,41 @@ def new
       def edit; end
 
       # POST /geography/states
-      def create
+      def create # rubocop:todo Metrics/MethodLength
         @geography_state = ::BetterTogether::Geography::State.new(geography_state_params)
         authorize_geography_state
 
         if @geography_state.save
           redirect_to @geography_state, notice: 'State was successfully created.', status: :see_other
         else
-          render :new, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_state }
+              )
+            end
+            format.html { render :new, status: :unprocessable_entity }
+          end
         end
       end
 
       # PATCH/PUT /geography/states/1
-      def update
+      def update # rubocop:todo Metrics/MethodLength
         if @geography_state.update(geography_state_params)
           redirect_to @geography_state, notice: 'State was successfully updated.', status: :see_other
         else
-          render :edit, status: :unprocessable_entity
+          respond_to do |format|
+            format.turbo_stream do
+              render turbo_stream: turbo_stream.update(
+                'form_errors',
+                partial: 'layouts/better_together/errors',
+                locals: { object: @geography_state }
+              )
+            end
+            format.html { render :edit, status: :unprocessable_entity }
+          end
         end
       end
 

app/controllers/better_together/navigation_areas_controller.rb

@@ -45,24 +45,42 @@ def edit
       authorize @navigation_area
     end
 
-    def create
+    def create # rubocop:todo Metrics/MethodLength
       @navigation_area = resource_class.new(navigation_area_params)
       authorize @navigation_area
 
       if @navigation_area.save
         redirect_to @navigation_area, only_path: true, notice: 'Navigation area was successfully created.'
       else
-        render :new
+        respond_to do |format|
+          format.turbo_stream do
+            render turbo_stream: turbo_stream.update(
+              'form_errors',
+              partial: 'layouts/better_together/errors',
+              locals: { object: @navigation_area }
+            )
+          end
+          format.html { render :new }
+        end
       end
     end
 
-    def update
+    def update # rubocop:todo Metrics/MethodLength
       authorize @navigation_area
 
       if @navigation_area.update(navigation_area_params)
         redirect_to @navigation_area, only_path: true, notice: 'Navigation area was successfully updated.'
       else
-        render :edit
+        respond_to do |format|
+          format.turbo_stream do
+            render turbo_stream: turbo_stream.update(
+              'form_errors',
+              partial: 'layouts/better_together/errors',
+              locals: { object: @navigation_area }
+            )
+          end
+          format.html { render :edit }
+        end
       end
     end
 

app/controllers/better_together/pages_controller.rb

@@ -32,14 +32,23 @@ def new
       authorize @page
     end
 
-    def create
+    def create # rubocop:todo Metrics/MethodLength
       @page = resource_class.new(page_params)
       authorize @page
 
       if @page.save
         redirect_to edit_page_path(@page), notice: t('flash.generic.created', resource: t('resources.page'))
       else
-        render :new
+        respond_to do |format|
+          format.turbo_stream do
+            render turbo_stream: turbo_stream.update(
+              'form_errors',
+              partial: 'layouts/better_together/errors',
+              locals: { object: @page }
+            )
+          end
+          format.html { render :new }
+        end
       end
     end