rubocop fixes

Author: rsmithlal

app/builders/better_together/navigation_builder.rb

@@ -150,7 +150,7 @@ def build_footer # rubocop:todo Metrics/MethodLength, Metrics/AbcSize
       end
 
       def build_header # rubocop:todo Metrics/MethodLength
-        I18n.with_locale(:en) do
+        I18n.with_locale(:en) do # rubocop:todo Metrics/BlockLength
           # Create platform header pages
           header_pages = ::BetterTogether::Page.create(
             [

app/controllers/better_together/application_controller.rb

@@ -170,7 +170,7 @@ def after_sign_in_path_for(resource)
         end
     end
 
-    def after_sign_out_path_for(resource_or_scope)
+    def after_sign_out_path_for(_resource_or_scope)
       BetterTogether.base_path_with_locale
     end
   end

app/controllers/better_together/people_controller.rb

@@ -70,10 +70,10 @@ def set_person
 
     def set_resource_instance
       @resource = if me?
-        helpers.current_person
-      else
-        super
-      end
+                    helpers.current_person
+                  else
+                    super
+                  end
     end
 
     def person_params
@@ -90,16 +90,16 @@ def resource_class
 
     def resource_collection # rubocop:todo Metrics/MethodLength
       policy_scope(resource_class.with_translations.with_attached_profile_image.with_attached_cover_image.includes(
-        contact_detail: %i[phone_numbers email_addresses website_links addresses social_media_accounts],
-        person_platform_memberships: {
-          joinable: [:string_translations, { profile_image_attachment: :blob }],
-          role: [:string_translations]
-        },
-        person_community_memberships: {
-          joinable: [:string_translations, { profile_image_attachment: :blob }],
-          role: [:string_translations]
-        }
-      ))
+                     contact_detail: %i[phone_numbers email_addresses website_links addresses social_media_accounts],
+                     person_platform_memberships: {
+                       joinable: [:string_translations, { profile_image_attachment: :blob }],
+                       role: [:string_translations]
+                     },
+                     person_community_memberships: {
+                       joinable: [:string_translations, { profile_image_attachment: :blob }],
+                       role: [:string_translations]
+                     }
+                   ))
     end
   end
 end

app/controllers/better_together/users/sessions_controller.rb

@@ -9,7 +9,7 @@ class SessionsController < ::Devise::SessionsController # rubocop:todo Style/Doc
       def respond_to_on_destroy
         respond_to do |format|
           format.all { head :no_content }
-          format.any(*navigational_formats) { redirect_to after_sign_out_path_for(resource_name), status: :see_other}
+          format.any(*navigational_formats) { redirect_to after_sign_out_path_for(resource_name), status: :see_other }
         end
       end
     end

app/helpers/better_together/image_helper.rb

@@ -3,7 +3,10 @@
 module BetterTogether
   # Helps with rendering images for various entities
   module ImageHelper
-    def cover_image_tag(entity, options = {}) # rubocop:todo Metrics/MethodLength
+    # rubocop:todo Metrics/PerceivedComplexity
+    # rubocop:todo Metrics/CyclomaticComplexity
+    # rubocop:todo Metrics/AbcSize
+    def cover_image_tag(entity, options = {}) # rubocop:todo Metrics/MethodLength, Metrics/AbcSize
       image_classes = "cover-image rounded-top #{options[:class]}"
       image_style = (options[:style]).to_s
       image_width = options[:width] || 2400
@@ -15,7 +18,7 @@ def cover_image_tag(entity, options = {}) # rubocop:todo Metrics/MethodLength
         class: image_classes,
         style: image_style,
         alt: image_alt,
-        title: image_title,
+        title: image_title
       }
 
       # Determine if entity has a profile image
@@ -33,8 +36,14 @@ def cover_image_tag(entity, options = {}) # rubocop:todo Metrics/MethodLength
         image_tag(image_url(default_image), **image_tag_attributes)
       end
     end
+    # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/CyclomaticComplexity
+    # rubocop:enable Metrics/PerceivedComplexity
 
-    def profile_image_tag(entity, options = {}) # rubocop:todo Metrics/MethodLength
+    # rubocop:todo Metrics/PerceivedComplexity
+    # rubocop:todo Metrics/CyclomaticComplexity
+    # rubocop:todo Metrics/AbcSize
+    def profile_image_tag(entity, options = {}) # rubocop:todo Metrics/MethodLength, Metrics/AbcSize
       image_classes = "profile-image rounded-circle #{options[:class]}"
       image_style = (options[:style]).to_s
       image_size = options[:size] || 300
@@ -59,10 +68,13 @@ def profile_image_tag(entity, options = {}) # rubocop:todo Metrics/MethodLength
         image_tag(attachment.url, **image_tag_attributes)
       else
         # Use a default image based on the entity type
-        default_image = default_profile_image(entity)
+        default_image = default_profile_image(entity, image_format)
         image_tag(image_url(default_image), **image_tag_attributes)
       end
     end
+    # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/CyclomaticComplexity
+    # rubocop:enable Metrics/PerceivedComplexity
 
     private
 
@@ -77,14 +89,14 @@ def default_cover_image(entity, image_format)
       end
     end
 
-    def default_profile_image(entity)
+    def default_profile_image(entity, image_format)
       case entity.class.name
       when 'BetterTogether::Person'
-        'profile_images/default_profile_image_person.jpg'
+        "profile_images/default_profile_image_person.#{image_format}"
       when 'BetterTogether::Community'
-        'profile_images/default_profile_image_community.jpg'
+        "profile_images/default_profile_image_community.#{image_format}"
       else
-        'profile_images/default_profile_image_generic.jpg'
+        "profile_images/default_profile_image_generic.#{image_format}"
       end
     end
   end