Rubocop fixes

Author: rsmithlal

spec/builders/better_together/builder_spec.rb

@@ -29,13 +29,13 @@ def cleared? = @cleared
   end
 
   describe '.build' do
-    it 'calls seed_data without clear when clear: false' do # rubocop:todo RSpec/MultipleExpectations
+    it 'calls seed_data without clear when clear: false' do
       expect(subclass).to receive(:seed_data) # rubocop:todo RSpec/MessageSpies
       expect(subclass).not_to receive(:clear_existing) # rubocop:todo RSpec/MessageSpies
       subclass.build(clear: false)
     end
 
-    it 'calls clear_existing and seed_data when clear: true' do # rubocop:todo RSpec/MultipleExpectations
+    it 'calls clear_existing and seed_data when clear: true' do
       expect(subclass).to receive(:clear_existing).ordered # rubocop:todo RSpec/MessageSpies
       expect(subclass).to receive(:seed_data).ordered # rubocop:todo RSpec/MessageSpies
       subclass.build(clear: true)

spec/channels/better_together/messages_channel_spec.rb

@@ -9,7 +9,7 @@
     stub_connection(current_person: person)
   end
 
-  it 'streams for the current person on subscribe' do # rubocop:todo RSpec/MultipleExpectations
+  it 'streams for the current person on subscribe' do
     subscribe
     expect(subscription).to be_confirmed
     expect(subscription).to have_stream_for(person)

spec/controllers/better_together/person_blocks_controller_spec.rb

@@ -17,7 +17,7 @@
   describe 'GET #search' do # rubocop:todo RSpec/MultipleMemoizedHelpers
     let!(:john_doe) { create(:better_together_person, name: 'John Doe', privacy: 'public') }
 
-    it 'returns searchable people as JSON' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
+    it 'returns searchable people as JSON' do # rubocop:todo RSpec/ExampleLength
       get :search, params: { locale: locale, q: 'John' }, format: :json
 
       expect(response).to have_http_status(:success)
@@ -28,7 +28,7 @@
       expect(json_response.first['value']).to eq(john_doe.id.to_s)
     end
 
-    it 'excludes already blocked people from search results' do # rubocop:todo RSpec/MultipleExpectations
+    it 'excludes already blocked people from search results' do
       blocked_user = create(:better_together_person, name: 'Blocked User', privacy: 'public')
       create(:person_block, blocker: person, blocked: blocked_user)
 
@@ -38,7 +38,7 @@
       expect(JSON.parse(response.body)).to be_empty
     end
 
-    it 'excludes current user from search results' do # rubocop:todo RSpec/MultipleExpectations
+    it 'excludes current user from search results' do
       get :search, params: { locale: locale, q: person.name }, format: :json
 
       expect(response).to have_http_status(:success)
@@ -111,7 +111,7 @@
     context 'when not authenticated' do
       before { sign_out user }
 
-      it 'redirects to sign in' do # rubocop:todo RSpec/MultipleExpectations
+      it 'redirects to sign in' do
         get :index, params: { locale: locale }
         expect(response).to have_http_status(:redirect)
         expect(response.location).to include('/users/sign-in')
@@ -134,7 +134,7 @@
     context 'when not authenticated' do
       before { sign_out user }
 
-      it 'redirects to sign in' do # rubocop:todo RSpec/MultipleExpectations
+      it 'redirects to sign in' do
         get :new, params: { locale: locale }
         expect(response).to have_http_status(:redirect)
         expect(response.location).to include('/users/sign-in')
@@ -244,7 +244,7 @@
     context 'when not authenticated' do
       before { sign_out user }
 
-      it 'redirects to sign in' do # rubocop:todo RSpec/MultipleExpectations
+      it 'redirects to sign in' do
         post :create, params: { locale: locale, person_block: { blocked_id: blocked_person.id } }
         expect(response).to have_http_status(:redirect)
         expect(response.location).to include('/users/sign-in')
@@ -293,7 +293,7 @@
     context 'when not authenticated' do # rubocop:todo RSpec/MultipleMemoizedHelpers
       before { sign_out user }
 
-      it 'redirects to sign in' do # rubocop:todo RSpec/MultipleExpectations
+      it 'redirects to sign in' do
         delete :destroy, params: { locale: locale, id: person_block.id }
         expect(response).to have_http_status(:redirect)
         expect(response.location).to include('/users/sign-in')

spec/features/checklist_create_appends_spec.rb

@@ -12,7 +12,6 @@
     login_as(manager, scope: :user)
   end
 
-  # rubocop:todo RSpec/MultipleExpectations
   it 'creates a new checklist item and it appears at the bottom after refresh' do # rubocop:todo RSpec/ExampleLength
     # rubocop:enable RSpec/MultipleExpectations
     checklist = create(:better_together_checklist, title: 'Append Test Checklist')

spec/features/conversations_client_validation_spec.rb

@@ -15,7 +15,6 @@
   end
 
   # rubocop:todo RSpec/ExampleLength
-  # rubocop:todo RSpec/MultipleExpectations
   it 'prevents submission and shows client-side validation when first message is empty' do
     # rubocop:enable RSpec/MultipleExpectations
     visit better_together.new_conversation_path(locale: I18n.default_locale,

spec/features/events/location_selector_spec.rb

@@ -4,7 +4,6 @@
 
 RSpec.feature 'Event location selector', :as_platform_manager, :js do
   # rubocop:todo RSpec/ExampleLength
-  # rubocop:todo RSpec/MultipleExpectations
   scenario 'shows inline new address and building blocks', skip: 'temporarily disabled (location selector flakiness)' do
     # rubocop:enable RSpec/MultipleExpectations
     visit better_together.new_event_path(locale: I18n.default_locale)

spec/features/joatu/invalid_inputs_spec.rb

@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 RSpec.feature 'Joatu invalid inputs' do
-  scenario 'fails to create a request without a name' do # rubocop:todo RSpec/MultipleExpectations
+  scenario 'fails to create a request without a name' do
     person = create(:better_together_person)
     request = BetterTogether::Joatu::Request.new(description: 'Need help', creator: person)
 

spec/features/joatu/respond_with_offer_spec.rb

@@ -8,7 +8,6 @@
   let(:owner_user) { create(:user, :confirmed) }
   let(:responder_user) { create(:user, :confirmed) }
   let(:request_resource) { create(:better_together_joatu_request, creator: owner_user.person) }
-  # rubocop:todo RSpec/MultipleExpectations
   scenario 'shows respond with offer button and redirects with source params' do # rubocop:todo RSpec/ExampleLength
     # rubocop:enable RSpec/MultipleExpectations
 

spec/features/notifications/unread_badge_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe 'notification badge' do
   context 'with platform manager role' do
-    it 'updates badge and title based on unread count', :js do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
+    it 'updates badge and title based on unread count', :js do # rubocop:todo RSpec/ExampleLength
       visit conversations_path(locale: I18n.default_locale)
       original_title = page.title
 

spec/features/setup_wizard_spec.rb

@@ -4,7 +4,6 @@
 
 RSpec.feature 'Setup Wizard Flow', :js, skip: 'flaky/setup_wizard - disabled while debugging suite' do
   # rubocop:todo RSpec/ExampleLength
-  # rubocop:todo RSpec/MultipleExpectations
   scenario 'redirects from root and completes the first wizard step using platform attributes' do
     # rubocop:enable RSpec/MultipleExpectations
     # Build a platform instance (using FactoryBot) with test data