feat: Enhance checklist item update with flash messaging and localization support

Author: rsmithlal

app/controllers/better_together/person_checklist_items_controller.rb

@@ -32,17 +32,29 @@ def create
                                                                       checklist_item: @checklist_item)
       pci.completed_at = params[:completed] ? Time.zone.now : nil
 
-      if pci.save
-        Rails.logger.info("DBG PersonChecklistItemsController#create: saved pci id=#{pci.id} completed_at=#{pci.completed_at}")
-        # If checklist completed, trigger a hook (implement as ActiveSupport::Notifications for now)
-        notify_if_checklist_complete(person)
-        render json: { id: pci.id, completed_at: pci.completed_at }, status: :ok
-      else
-        render json: { errors: pci.errors.full_messages }, status: :unprocessable_entity
+      respond_to do |format|
+        if pci.save
+          Rails.logger.info("DBG PersonChecklistItemsController#create: saved pci id=#{pci.id} completed_at=#{pci.completed_at}")
+          # If checklist completed, trigger a hook (implement as ActiveSupport::Notifications for now)
+          notify_if_checklist_complete(person)
+          format.json { render json: { id: pci.id, completed_at: pci.completed_at, flash: { type: 'notice', message: t('flash.checklist_item.updated') } }, status: :ok }
+          format.html { redirect_back(fallback_location: BetterTogether.base_path_with_locale, notice: t('flash.checklist_item.updated')) }
+          format.turbo_stream do
+            flash.now[:notice] = t('flash.checklist_item.updated')
+            render turbo_stream: turbo_stream.replace('flash_messages', partial: 'layouts/better_together/flash_messages', locals: { flash: })
+          end
+        else
+          format.json { render json: { errors: pci.errors.full_messages, flash: { type: 'alert', message: t('flash.checklist_item.update_failed') } }, status: :unprocessable_entity }
+          format.html { redirect_back(fallback_location: BetterTogether.base_path_with_locale, alert: t('flash.checklist_item.update_failed')) }
+          format.turbo_stream do
+            flash.now[:alert] = t('flash.checklist_item.update_failed')
+            render turbo_stream: turbo_stream.replace('flash_messages', partial: 'layouts/better_together/flash_messages', locals: { flash: })
+          end
+        end
       end
     rescue StandardError => e
       Rails.logger.error("PersonChecklistItemsController#create unexpected error: #{e.class} - #{e.message}\n#{e.backtrace.join("\n")}")
-      render json: { errors: [e.message] }, status: :internal_server_error
+      render json: { errors: [e.message], flash: { type: 'alert', message: e.message } }, status: :internal_server_error
     end
 
     private

app/javascript/controllers/better_together/person_checklist_item_controller.js

@@ -131,6 +131,13 @@ export default class extends Controller {
           try { errBody = await r.json() } catch (e) { /* ignore */ }
           lastError = { status: r.status, body: errBody }
 
+          // Show server-provided flash if present
+          try {
+            if (errBody && errBody.flash && window.BetterTogetherNotifications && typeof window.BetterTogetherNotifications.displayFlashMessage === 'function') {
+              window.BetterTogetherNotifications.displayFlashMessage(errBody.flash.type || 'alert', errBody.flash.message || errBody.errors?.join(', ') || 'An error occurred')
+            }
+          } catch (e) { /* noop */ }
+
           // Retry on server errors (5xx). For 4xx, break early.
           if (r.status >= 500) {
             const backoff = 200 * attempt
@@ -144,6 +151,12 @@ export default class extends Controller {
   const data = await r.json()
       // update UI with returned state
   this.updateUI(data)
+  // Show server-provided flash if present
+  try {
+    if (data && data.flash && window.BetterTogetherNotifications && typeof window.BetterTogetherNotifications.displayFlashMessage === 'function') {
+      window.BetterTogetherNotifications.displayFlashMessage(data.flash.type || 'notice', data.flash.message || '')
+    }
+  } catch (e) { /* noop */ }
   // Dispatch an event for checklist-level listeners with detail
   this.element.dispatchEvent(new CustomEvent('person-checklist-item:toggled', { bubbles: true, detail: { checklist_item_id: this.checklistItemIdValue, status: 'toggled', data } }))
         return
@@ -162,6 +175,13 @@ export default class extends Controller {
       this.containerTarget.classList.add('person-checklist-error')
       setTimeout(() => this.containerTarget.classList.remove('person-checklist-error'), 3000)
     }
+    // Show a fallback flash message for persistent failures
+    try {
+      const msg = (typeof I18n !== 'undefined' && I18n && I18n.t) ? I18n.t('flash.checklist_item.update_failed') : 'Failed to update checklist item.'
+      if (window.BetterTogetherNotifications && typeof window.BetterTogetherNotifications.displayFlashMessage === 'function') {
+        window.BetterTogetherNotifications.displayFlashMessage('alert', msg)
+      }
+    } catch (e) { /* noop */ }
   }
 
   getCSRFToken() {

config/locales/en.yml

@@ -1801,6 +1801,9 @@ en:
     person_block:
       blocked: Person was successfully blocked.
       unblocked: Person was successfully unblocked.
+    checklist_item:
+      updated: Checklist item updated.
+      update_failed: Failed to update checklist item.
   globals:
     actions: Actions
     add_block: Add block

config/locales/es.yml

@@ -1238,6 +1238,9 @@ es:
     person_block:
       cannot_block_manager: no puede ser un administrador de la plataforma
       cannot_block_self: no puedes bloquearte a ti mismo
+    checklist_item:
+      updated: Elemento de la lista actualizado.
+      update_failed: Error al actualizar el elemento de la lista.
     person_blocks:
       index:
         actions: Acciones