feat(models): update slugging and associations in Calendar, Community, Conversation, and Person

Author: rsmithlal

app/models/better_together/calendar.rb

@@ -15,11 +15,11 @@ class Calendar < ApplicationRecord
     has_many :calendar_entries, class_name: 'BetterTogether::CalendarEntry', dependent: :destroy
     has_many :events, through: :calendar_entries
 
-    slugged :name
-
     translates :name
     translates :description, backend: :action_text
 
+    slugged :name
+
     def to_s
       name
     end

app/models/better_together/community.rb

@@ -19,17 +19,17 @@ class Community < ApplicationRecord
                optional: true
 
     has_many :calendars, class_name: 'BetterTogether::Calendar', dependent: :destroy
-    has_one :default_calendar, -> { where(name: 'Default') }, class_name: 'BetterTogether::Calendar'
+    has_one :default_calendar, -> { i18n.where(name: 'Default') }, class_name: 'BetterTogether::Calendar'
 
     joinable joinable_type: 'community',
              member_type: 'person'
 
-    slugged :name
-
     translates :name
     translates :description, type: :text
     translates :description_html, backend: :action_text
 
+    slugged :name
+
     has_one_attached :profile_image do |attachable|
       attachable.variant :optimized_jpeg, resize_to_limit: [200, 200],
                                           # rubocop:todo Layout/LineLength

app/models/better_together/conversation.rb

@@ -3,8 +3,9 @@
 module BetterTogether
   # groups messages for participants
   class Conversation < ApplicationRecord
+    include Creatable
+
     encrypts :title, deterministic: true
-    belongs_to :creator, class_name: 'BetterTogether::Person'
     has_many :messages, dependent: :destroy
     accepts_nested_attributes_for :messages, allow_destroy: false
     has_many :conversation_participants, dependent: :destroy

app/models/better_together/person.rb

@@ -26,7 +26,8 @@ def self.primary_community_delegation_attrs
 
     has_many :conversation_participants, dependent: :destroy
     has_many :conversations, through: :conversation_participants
-    has_many :created_conversations, as: :creator, class_name: 'BetterTogether::Conversation', dependent: :destroy
+    has_many :created_conversations, foreign_key: :creator_id, class_name: 'BetterTogether::Conversation',
+                                     dependent: :destroy
 
     has_many :agreement_participants, class_name: 'BetterTogether::AgreementParticipant', dependent: :destroy
     has_many :agreements, through: :agreement_participants