Feature/conversation encryption (#1001)

- adds a slider to edit_person to toggle showing of conversation title
and message sender
- adds key-value pair for show_conversation_details to person model's
notification_preferences
- updates the conversation_mailer to reflect these preference changes

- adds encryption to conversation model title attribute
- host_dashboard resource_cards can now be altered to determine what
attribute they show publicly
- adds migrations to update un-encrypted values to be encrypted

Author: rsmithlal

app/controllers/better_together/people_controller.rb

@@ -94,7 +94,8 @@ def set_resource_instance
     def person_params
       params.require(:person).permit(
         :name, :description, :profile_image, :slug, :locale, :notify_by_email,
-        :profile_image, :cover_image, :remove_profile_image, :remove_cover_image,
+        :show_conversation_details, :profile_image, :cover_image, :remove_profile_image,
+        :remove_cover_image,
         *resource_class.permitted_attributes
       )
     end

app/mailers/better_together/conversation_mailer.rb

@@ -11,21 +11,25 @@ def new_message_notification # rubocop:todo Metrics/MethodLength, Metrics/AbcSiz
       @recipient = params[:recipient]
       @sender = @message.sender
 
+      from = t('better_together.conversation_mailer.new_message_notification.from_address',
+               from_address: default_params[:from])
       subject = t('better_together.conversation_mailer.new_message_notification.subject')
-      if @conversation.title.present?
-        subject = t('better_together.conversation_mailer.new_message_notification.subject_with_title',
-                    conversation: @conversation.title)
+      if @recipient.show_conversation_details
+        if @conversation.title.present?
+          subject = t('better_together.conversation_mailer.new_message_notification.subject_with_title',
+                      conversation: @conversation.title)
+        end
+        from = t('better_together.conversation_mailer.new_message_notification.from_address_with_sender',
+                 sender_name: @sender.name,
+                 from_address: default_params[:from])
       end
 
       # Override time zone and locale if necessary
       self.locale = @recipient.locale
       self.time_zone = @recipient.time_zone
 
       mail(to: @recipient.email,
-           from: t('better_together.conversation_mailer.new_message_notification.from_address',
-                   sender_name: @sender.name,
-                   from_address: default_params[:from]),
-           subject:)
+           from:, subject:)
     end
     # rubocop:enable Metrics/AbcSize
   end

app/models/better_together/conversation.rb

@@ -3,6 +3,7 @@
 module BetterTogether
   # groups messages for participants
   class Conversation < ApplicationRecord
+    encrypts :title, deterministic: true
     belongs_to :creator, class_name: 'BetterTogether::Person'
     has_many :messages, dependent: :destroy
     has_many :conversation_participants, dependent: :destroy

app/models/better_together/person.rb

@@ -68,6 +68,7 @@ def self.primary_community_delegation_attrs
 
     store_attributes :notification_preferences do
       notify_by_email Boolean, default: true
+      show_conversation_details Boolean, default: false
     end
 
     validates :name,

app/notifiers/better_together/new_message_notifier.rb

@@ -33,7 +33,7 @@ def sender
       delegate :url, to: :event
 
       def send_email_notification?
-        recipient.email.present? && recipient.notification_preferences['notify_by_email'] && should_send_email?
+        recipient.email.present? && recipient.notify_by_email && should_send_email?
       end
 
       def should_send_email?

app/views/better_together/conversation_mailer/new_message_notification.html.erb

@@ -2,7 +2,12 @@
 
 <p><%= t('.greeting', recipient_name: @recipient.name) %></p>
 
-<p><%= t('.message_intro', sender_name: @sender.name) %></p>
+
+<% if(@recipient.show_conversation_details) %>
+	<p><%= t('.message_intro_with_sender', sender_name: @sender.name) %></p>
+<% else %>
+	<p><%= t('.message_intro') %></p>
+<% end %>
 
 <p><%= t('.view_conversation') %></p>
 

app/views/better_together/host_dashboard/_resource_card.html.erb

@@ -1,6 +1,6 @@
 <!-- app/views/better_together/host_dashboard/_resource_card.html.erb -->
 
-<%# locals: (collection:, model_class: collection.model, model_name: model_class.model_name, count:, url_helper: :url_for) -%>
+<%# locals: (collection:, model_class: collection.model, model_name: model_class.model_name, count:, url_helper: :url_for, show_attr: :to_s) -%>
 
 <div class="col mb-4">
   <div class="card hover-effect shadow-sm h-100">
@@ -19,12 +19,12 @@
     <div class="card-body" style="min-height: 100px;">
       <% if collection.any? %>
         <% collection.each do |resource| %>
-          <div class="d-flex justify-content-between mb-2">
+          <div class="d-flex justify-content-between mb-2">							
             <span class="text-truncate" style="max-width: 70%;" data-bs-toggle="tooltip" title="<%= resource.to_s %>">
-              <% if policy(resource).show? %>
+							<% if policy(resource).show? %>
                 <%= link_to resource, public_send(url_helper, resource), class: "text-decoration-none" %>
               <% else %>
-                <%= resource %>
+                <%= resource.public_send(show_attr) %>
               <% end %>
             </span>
             <span class="text-muted small" data-bs-toggle="tooltip" title="<%= l(resource.created_at, format: :long) %>">

app/views/better_together/host_dashboard/index.html.erb

@@ -35,7 +35,7 @@
 
       <!-- Users -->
       <%= render partial: 'resource_card', locals: { collection: @users, count: @user_count, url_helper: :user_path } %>
-      <%= render partial: 'resource_card', locals: { collection: @conversations, count: @conversation_count, url_helper: :conversation_path } %>
+      <%= render partial: 'resource_card', locals: { collection: @conversations, count: @conversation_count, url_helper: :conversation_path, show_attr: :id } %>
       <%= render partial: 'resource_card', locals: { collection: @messages, count: @message_count, url_helper: :message_path } %>
       <%= render partial: 'resource_card', locals: { collection: @categories, count: @category_count, url_helper: :category_path } %>
     </div>

app/views/better_together/people/_form.html.erb

@@ -113,7 +113,7 @@
         </div>
       </div>
 
-      <!-- Device Permissions Tab -->
+      <!-- Preferences Tab -->
       <div class="nav-tab-pane tab-pane fade"
            id="person-preferences"
            role="tabpanel"
@@ -128,6 +128,10 @@
 					<%= render partial: 'better_together/shared/fields/toggle_switch', locals: {form:, attr: :notify_by_email} %>
 					  <small class="form-text text-muted"><%= t('helpers.hint.person.notify_by_email') %></small>
 				</div>
+				<div class="mb-3">
+					<%= render partial: 'better_together/shared/fields/toggle_switch', locals: {form:, attr: :show_conversation_details} %>
+					  <small class="form-text text-muted"><%= t('helpers.hint.person.show_conversation_details') %></small>
+				</div>
       </div>
 
       <!-- Device Permissions Tab -->

config/locales/en.yml

@@ -303,6 +303,7 @@ en:
         person_platform_memberships: Person platform memberships
         platform_roles: Platform roles
         preferences: Preferences
+        show_conversation_details: Show conversation details
         slug: Username
         slugs: Slugs
         string_translations: String translations
@@ -628,9 +629,11 @@ en:
       add: Add Contact
     conversation_mailer:
       new_message_notification:
-        from_address: '%{sender_name} via %{from_address}'
+        from_address: 'New message via %{from_address}'
+        from_address_with_sender: '%{sender_name} via %{from_address}'
         greeting: Hello %{recipient_name},
-        message_intro: 'You have an unread message from %{sender_name}:'
+        message_intro: You have an unread message
+        message_intro_with_sender: 'You have an unread message from %{sender_name}'
         signature: Signature
         signature_html: |-
           Best regards,<br />
@@ -1315,6 +1318,7 @@ en:
         name: Enter the full name of the person.
         notify_by_email: Send an email when a conversation has an unread message.
         profile_image: Upload a profile image for the person.
+        show_conversation_details: Show conversation title and sender name in notifications.
         slug: A URL-friendly identifier, typically auto-generated.
     label:
       person: