Replace class constants with class attributes for overridable class values

Author: rsmithlal

app/helpers/better_together/navigation_items_helper.rb

@@ -109,7 +109,7 @@ def render_platform_header_nav_items
 
     def route_names_for_select(nav_item = nil)
       options_for_select(
-        BetterTogether::NavigationItem::ROUTE_NAMES.map { |name, route| [I18n.t("route_names.#{name}"), route] },
+        BetterTogether::NavigationItem.route_names.map { |name, route| [I18n.t("route_names.#{name}"), route] },
         (nav_item ? nav_item.route_name : nil)
       )
     end

app/models/better_together/content/block.rb

@@ -28,9 +28,7 @@ def to_partial_path
       def self.inherited(subclass)
         super
         # Your custom logic here, which will be available to all subclasses
-        subclass.instance_eval do
-          include ::BetterTogether::Content::BlockAttributes
-        end
+        subclass.include ::BetterTogether::Content::BlockAttributes
       end
 
       def self.block_name

app/models/better_together/content/template.rb

@@ -4,10 +4,10 @@ module BetterTogether
   module Content
     # Renders a template from a file
     class Template < Block
-      AVAILABLE_TEMPLATES = %w[
+      class_attribute :available_templates, default: %w[
         better_together/content/blocks/template/default
         better_together/content/blocks/template/host_community_contact_details
-      ].freeze
+      ]
 
       has_many :page_blocks, foreign_key: :block_id, dependent: :destroy
       has_many :pages, through: :page_blocks
@@ -16,7 +16,7 @@ class Template < Block
         template_path String
       end
 
-      validates :template_path, presence: true, inclusion: { in: ->(template) { template.class::AVAILABLE_TEMPLATES } }
+      validates :template_path, presence: true, inclusion: { in: ->(template) { template.class.available_templates } }
     end
   end
 end

app/models/better_together/navigation_item.rb

@@ -7,6 +7,25 @@ class NavigationItem < ApplicationRecord # rubocop:todo Metrics/ClassLength
     include Positioned
     include Protected
 
+    class_attribute :route_names, default: {
+      content_blocks: 'content_blocks_path',
+      communities: 'communities_path',
+      geography_continents: 'geography_continents_path',
+      geography_countries: 'geography_countries_path',
+      geography_states: 'geography_states_path',
+      geography_regions: 'geography_regions_path',
+      geography_settlements: 'geography_settlements_path',
+      host_dashboard: 'host_dashboard_path',
+      metrics_reports: 'metrics_reports_path',
+      navigation_areas: 'navigation_areas_path',
+      pages: 'pages_path',
+      people: 'people_path',
+      platforms: 'platforms_path',
+      resource_permissions: 'resource_permissions_path',
+      roles: 'roles_path',
+      users: 'users_path'
+    }
+
     belongs_to :navigation_area, touch: true
     belongs_to :linkable, polymorphic: true, optional: true, autosave: true
 
@@ -31,27 +50,8 @@ class NavigationItem < ApplicationRecord # rubocop:todo Metrics/ClassLength
       'BetterTogether::Page'
     ].freeze
 
-    ROUTE_NAMES = {
-      content_blocks: 'content_blocks_path',
-      communities: 'communities_path',
-      geography_continents: 'geography_continents_path',
-      geography_countries: 'geography_countries_path',
-      geography_states: 'geography_states_path',
-      geography_regions: 'geography_regions_path',
-      geography_settlements: 'geography_settlements_path',
-      host_dashboard: 'host_dashboard_path',
-      metrics_reports: 'metrics_reports_path',
-      navigation_areas: 'navigation_areas_path',
-      pages: 'pages_path',
-      people: 'people_path',
-      platforms: 'platforms_path',
-      resource_permissions: 'resource_permissions_path',
-      roles: 'roles_path',
-      users: 'users_path'
-    }.freeze
-
     def self.route_name_paths
-      ROUTE_NAMES.values.map(&:to_s)
+      route_names.values.map(&:to_s)
     end
 
     translates :title, type: :string
@@ -97,8 +97,7 @@ def self.route_name_paths
       combined_conditions = visible_flag.and(not_page.or(published_page).or(linkable_is_nil))
 
       # Apply the join and where conditions
-      joins(join)
-        .where(combined_conditions)
+      joins(join).where(combined_conditions)
     }
 
     def build_children(pages, navigation_area) # rubocop:todo Metrics/MethodLength

app/models/concerns/better_together/removeable_attachment.rb

@@ -3,10 +3,9 @@
 module BetterTogether
   module RemoveableAttachment # rubocop:todo Style/Documentation
     extend ::ActiveSupport::Concern
+
     included do
-      # rubocop:todo Lint/ConstantDefinitionInBlock
-      ATTACHMENT_ATTRIBUTES = [] # rubocop:todo Style/MutableConstant, Lint/ConstantDefinitionInBlock
-      # rubocop:enable Lint/ConstantDefinitionInBlock
+      class_attribute :attachment_attributes, default: []
 
       # define accessors, before_save callback, and purge method for all declared has_one attachments
       reflect_on_all_attachments
@@ -17,7 +16,7 @@ module RemoveableAttachment # rubocop:todo Style/Documentation
         remove_attachment_attr = :"remove_#{attachment}"
         attr_accessor :"remove_#{attachment}"
 
-        ATTACHMENT_ATTRIBUTES.push(attachment, remove_attachment_attr)
+        attachment_attributes.push(attachment, remove_attachment_attr)
 
         # Callbacks to remove images if necessary
         before_save :"purge_#{attachment}", if: -> { public_send(remove_attachment_attr) == '1' }
@@ -30,7 +29,7 @@ module RemoveableAttachment # rubocop:todo Style/Documentation
 
     class_methods do
       def extra_permitted_attributes
-        super + ATTACHMENT_ATTRIBUTES.flatten.compact
+        super + attachment_attributes.flatten.compact
       end
     end
   end

app/views/better_together/content/blocks/fields/_template.html.erb

@@ -2,5 +2,5 @@
 <%- scope = local_assigns[:scope] ? local_assigns[:scope] : BetterTogether::Content::Block.block_name %>
 <div class="template-fields">
   <%= required_label block, :template_path %>
-  <%= select_tag "#{scope}[template_path]", options_for_select(block.class::AVAILABLE_TEMPLATES.map { |path| [ I18n.t(path.tr('/', '.')), path] }, block.template_path), class: 'form-select' %>
+  <%= select_tag "#{scope}[template_path]", options_for_select(block.class::available_templates.map { |path| [ I18n.t(path.tr('/', '.')), path] }, block.template_path), class: 'form-select' %>
 </div>