Fix app-breaking javascript re: stimulus-loading

Author: rsmithlal

app/assets/config/better_together_manifest.js

@@ -1,9 +1,13 @@
 // app/assets/config/better_together_manifest.js
 
 //= link_tree ../../javascript/better_together .js
+// link_tree ../../../vendor/javascript .js
 //= link_tree ../stylesheets/better_together .css
 //= link_tree ../images/better_together
 
 //= link bootstrap.min.js
 //= link popper.js
 
+//= link stimulus.min.js
+//= link stimulus-loading.js
+//= link turbo.min.js

app/javascript/better_together/application.js

@@ -16,17 +16,22 @@
 //= require better_together/tooltips
 // require_tree .
 
-import '@hotwired/turbo-rails'
-import '@hotwired/stimulus'
-import '@hotwired/stimulus-loading'
+import { Turbo } from '@hotwired/turbo-rails'
+// import { Application } from '@hotwired/stimulus'
 // import 'trix'
-import '@rails/actiontext'
+// import { start as startActionText } from '@rails/actiontext'
 
-import 'better_together/controllers'
+import { application } from 'better_together/controllers'
 // import 'better_together/trix-extensions/richtext'
 
 // import 'bootstrap'
 
 // Turbo.session.drive = false
 
-console.log('initializing engine')
+// const application = Application.start()
+
+console.log('initializing engine')
+
+// window.Stimulus = application
+
+export { application }

app/javascript/better_together/controllers/index.js

@@ -7,9 +7,9 @@ import { application } from "better_together/controllers/application"
 // eagerLoadControllersFrom("controllers", application)
 
 // Lazy load controllers as they appear in the DOM (remember not to preload controllers in import map!)
-import { lazyLoadControllersFrom } from "@hotwired/stimulus-loading"
+import { lazyLoadControllersFrom } from 'stimulus-loading' // Adjust the path if necessary
 lazyLoadControllersFrom("controllers", application)
 
 console.log('initializing engine controllers')
 
-export { }
+export { application }

config/importmap.rb

@@ -1,14 +1,15 @@
 # frozen_string_literal: true
 
 # config/importmap.rb
-# pin_all_from File.expand_path("../app/assets/javascript", __dir__)
+
 pin_all_from File.expand_path('../app/javascript', __dir__)
+# pin_all_from File.expand_path('../vendor/javascript', __dir__)
 pin_all_from 'app/javascript/better_together/controllers', under: 'controllers', to: 'controllers'
 pin_all_from 'app/javascript/better_together/trix-extensions', under: 'trix-extensions', to: 'trix-extensions'
+
 pin '@hotwired/turbo-rails', to: 'turbo.min.js'
 pin '@hotwired/stimulus', to: 'stimulus.min.js'
-pin '@hotwired/stimulus-loading', to: 'stimulus-loading'
-# TODO: Check if this is compiled for prod: https://github.com/hotwired/stimulus-rails/issues/108
+pin 'stimulus-loading', to: 'stimulus-loading.js', preload: true # Ensure correct path and file extension
 
 pin 'bootstrap', to: 'bootstrap.min.js', preload: true
 pin '@popperjs/core', to: 'popper.js', preload: true

lib/better_together/engine.rb

@@ -47,14 +47,14 @@ class Engine < ::Rails::Engine
     initializer 'better_together.importmap', before: 'importmap' do |app|
       app.config.importmap.paths << Engine.root.join('config/importmap.rb')
 
-      # NOTE: something about cache; I did not look into it.
-      # https://github.com/rails/importmap-rails#sweeping-the-cache-in-development-and-test
+      # Ensure the cache is swept in development and test environments
       app.config.importmap.cache_sweepers << root.join('app/assets/javascripts')
+      app.config.importmap.cache_sweepers << root.join('app/javascript')
     end
 
-    # NOTE: add engine manifest to precompile assets in production
+    # Add engine manifest to precompile assets in production
     initializer 'better_together.assets' do |app|
-      app.config.assets.precompile += %w[better_together_manifest]
+      app.config.assets.precompile += %w[better_together_manifest.js]
       app.config.assets.paths << root.join('app', 'assets', 'images')
       app.config.assets.paths << root.join('app', 'javascript')
     end
@@ -63,6 +63,11 @@ class Engine < ::Rails::Engine
       app.config.action_view.form_with_generates_remote_forms = true
     end
 
+    # Add custom logging
+    initializer 'better_together.logging', before: :initialize_logger do |app|
+      app.config.log_tags = [:request_id, :remote_ip]
+    end
+
     rake_tasks do
       load 'tasks/better_together_tasks.rake'