refactor: rename notification marking method for consistency and clarity

Author: rsmithlal

docs/developers/systems/notifications_system.md

@@ -1,6 +1,9 @@
 # Notifications System Overview
 
-This document explains how notifications are produced, delivered, deduplicated, and marked as read across the app. The system uses the Noticed gem with Action Cable and email channels.
+This document explains how notifications are produced, delivered, deduplicated, - Concern: `BetterTogether::NotificationReadable` (`app/controllers/concerns/better_together/notification_readable.rb`)
+  - `mark_notifications_read_for_record_id(record_id)`: generic record-based read marker using `noticed_events.record_id`.
+  - `mark_notifications_read_for_event_records(event_class, record_ids)`: batch mark for a specific Noticed event type and list of record IDs.
+  - `mark_match_notifications_read_for(record)`: efficiently marks unread `MatchNotifier` notifications for an Offer/Request by matching the record's GlobalID in `params`.marked as read across the app. The system uses the Noticed gem with Action Cable and email channels.
 
 ## Process Flow Diagram
 

spec/controllers/concerns/notification_readable_spec.rb

@@ -32,7 +32,7 @@
     end
   end
 
-  describe '#mark_notifications_read_for_record' do
+  describe '#mark_notifications_read_for_record_id' do
     # rubocop:todo RSpec/MultipleExpectations
     it 'marks unread notifications tied to the event record as read' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
       # rubocop:enable RSpec/MultipleExpectations
@@ -48,7 +48,7 @@
                                .where(noticed_events: { type: 'BetterTogether::NewMessageNotifier' }).count
       expect(unread_before).to be >= 1
 
-      concern_host.mark_notifications_read_for_record(message, recipient:)
+      concern_host.mark_notifications_read_for_record_id(message.id, recipient:)
 
       unread_after = recipient.notifications.unread.joins(:event)
                               .where(noticed_events: { type: 'BetterTogether::NewMessageNotifier' }).count