Improve preloading of conversation participant data

Author: rsmithlal

app/policies/better_together/conversation_policy.rb

@@ -37,7 +37,7 @@ def leave_conversation?
     # Returns the people that the agent is permitted to message
     def permitted_participants
       if permitted_to?('manage_platform')
-        BetterTogether::Person.all
+        BetterTogether::Person.includes(:string_translations).all
       else
         role = BetterTogether::Role.find_by(identifier: 'platform_manager')
         manager_ids = BetterTogether::PersonPlatformMembership.where(role_id: role.id).pluck(:member_id)
@@ -46,7 +46,7 @@ def permitted_participants
           'preferences @> ?', { receive_messages_from_members: true }.to_json
         )
 
-        BetterTogether::Person.where(id: manager_ids).or(opted_in).distinct
+        BetterTogether::Person.includes(:string_translations).where(id: manager_ids).or(opted_in).distinct
       end
     end
 

app/views/better_together/conversations/_conversation_content.html.erb

@@ -12,7 +12,7 @@
 				</h4>
 				<% end %>
 					<div class="conversation-participants w-100 d-flex align-items-top justify-content-evenly overflow-auto">
-						<%= render partial: 'better_together/people/mention' , collection: conversation.participants, as: :person,
+						<%= render partial: 'better_together/people/mention' , collection: conversation.participants.includes(:string_translations).with_attached_profile_image, as: :person,
 							locals: { flex_layout: 'flex-column' , flex_align_items: 'center' } %>
 					</div>
 					<div data-bs-toggle="tooltip" title="<%= t('.options_tooltip') %>" class="align-self-center mx-4">

app/views/better_together/people/_mention.html.erb

@@ -7,7 +7,7 @@
     <%= profile_image_tag(person, class: 'mention', size: 50) %>
   </div>
   <div class="h-50 align-self-top">
-    <a class="text-decoration-none identity-name stretched-link" href="<%= policy(person).show? ? person_path(person) : 'test' %>">
+    <a class="text-decoration-none identity-name stretched-link" href="<%= policy(person).show? ? person_path(person) : nil %>">
       <%= person.name %>
     </a>
   </div>