cleans up controllers for better abstraction

Author: Kneeba921

app/controllers/better_together/notifications_controller.rb

@@ -14,8 +14,8 @@ def index
     def mark_as_read # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
       if params[:id]
         mark_notification_as_read(params[:id])
-      elsif params[:message_id]
-        mark_message_as_read(params[:message_id])
+      elsif params[:record_id]
+        mark_record_notification_as_read(params[:message_id])
       else
         helpers.current_person.notifications.unread.update_all(read_at: Time.current)
       end
@@ -41,11 +41,11 @@ def mark_notification_as_read(id)
       @notification.update(read_at: Time.current)
     end
 
-    def mark_message_as_read(id)
-      @notification = helpers.current_person.notifications.unread.includes(
+    def mark_record_notification_as_read(id)
+      @notifications = helpers.current_person.notifications.unread.includes(
         :event
       ).references(:event).where(event: { record_id: id })
-      @notification.update(read_at: Time.current)
+      @notifications.update_all(read_at: Time.current)
     end
   end
 end

app/javascript/controllers/better_together/message_visibility_controller.js

@@ -37,7 +37,7 @@ export default class extends Controller {
 				'X-CSRF-Token': this.getCSRFToken()
 			},
 			body: JSON.stringify({
-				message_id: messageId
+				record_id: messageId
 			})
 		})
 		.then(response => {