Allow events to be created within communities by community members.

Adjust event policy to ensure that checks are correct. Don't show draft or private events to people who aren't connected to them.

Author: rsmithlal

app/models/better_together/person.rb

@@ -102,7 +102,7 @@ def description_html(locale: I18n.locale)
     end
 
     def valid_event_host_ids
-      [id]
+      [id] + member_communities.pluck(:id)
     end
 
     def handle

app/policies/better_together/community_policy.rb

@@ -22,6 +22,11 @@ def update?
       user.present? && (permitted_to?('manage_platform') || permitted_to?('update_community', record))
     end
 
+    def create_events?
+      update? &&
+        BetterTogether::EventPolicy.new(user, BetterTogether::Event.new).create?
+    end
+
     def edit?
       update?
     end

app/policies/better_together/event_policy.rb

@@ -8,15 +8,15 @@ def index?
     end
 
     def show?
-      record.privacy_public? || creator_or_manager || event_host_member?
+      (record.privacy_public? && record.starts_at.present?) || creator_or_manager || event_host_member?
     end
 
     def update?
       creator_or_manager || event_host_member?
     end
 
     def create?
-      permitted_to?('manage_platform')
+      permitted_to?('manage_platform') || event_host_member?
     end
 
     def destroy?
@@ -56,15 +56,20 @@ def permitted_query # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
           query = query.or(
             events_table[:creator_id].eq(agent.id)
           )
+
           if agent.valid_event_host_ids.any?
-            event_ids = event_ids
+            event_ids = event_hosts_table
                         .where(event_hosts_table[:host_id].in(agent.valid_event_host_ids))
                         .project(:event_id)
             query = query.or(
               events_table[:id].in(event_ids)
             )
           end
+
           query
+        else
+          # Events must have a start time to be shown to people who aren't conencted to the event
+          query = query.and(events_table[:starts_at].not_eq(nil))
         end
 
         query

app/views/better_together/communities/show.html.erb

@@ -49,13 +49,14 @@
         <%= content_tag :div, id: 'communityTabs', class: 'nav nav-tabs card-header-tabs', role: 'tablist', aria_label: 'Community Sections' do %>
           <%= link_to t('globals.tabs.about'), '#about', class: 'nav-link active', id: 'about-tab', data: { bs_toggle: 'tab', bs_target: '#about', bs_parent: '#profileSections' }, role: 'tab', aria_controls: 'about', aria_selected: 'true', tabindex: '0' %>
           <%= link_to t('globals.tabs.members'), '#members', class: 'nav-link', id: 'members-tab', data: { bs_toggle: 'tab', bs_target: '#members', bs_parent: '#communitySections' }, role: 'tab', aria_controls: 'members', aria_selected: 'false', tabindex: '-1' %>
+          <%= link_to t('globals.tabs.events'), '#events', class: 'nav-link', id: 'events-tab', data: { bs_toggle: 'tab', bs_target: '#events', bs_parent: '#profileSections' }, role: 'tab', aria_controls: 'events', aria_selected: 'true', tabindex: '0' %>
         <% end %>
       </div>
 
       <%# Accordion content with accessible attributes and flexbox layout %>
       <div class="card-body" id="communitySections" role="tabpanel">
         <!-- Person About Section -->
-        <section id="about" class="row collapse show" aria-labelledby="about-tab" aria-expanded="true" data-bs-parent="#platformTabs">
+        <section id="about" class="row collapse show" aria-labelledby="about-tab" aria-expanded="true" data-bs-parent="#communityTabs">
           <div class="col-md-12">
             <!-- Name Section -->
             <h2 class="card-title profile-name text-center mb-3">
@@ -121,6 +122,15 @@
             <%= render partial: 'better_together/person_community_memberships/person_community_membership_member', collection: @resource.person_community_memberships, as: :membership %>
           </div>
         </div>
+
+        <div id="events" class="collapse" aria-labelledby="events-tab" aria-expanded="true" data-bs-parent="#communityTabs">
+          <% if policy(@resource).create_events? %>
+            <%= link_to t('.create_event', default: 'Create an Event'), new_event_path(host_id: @resource.id, host_type: resource_class), class: 'btn btn-primary' %>
+          <% end %>
+          <div id="events_list" class="mt-3 row row-cols-1 row-cols-md-2 row-cols-lg-3 row-cols-xl-4">
+            <%= render(policy_scope(@resource.hosted_events)) || render('better_together/events/none') %>
+          </div>
+        </div>
       </div>
     </section>
   </div>