Add active_storage_validations gem for robust attachment validations for image block and other attachments

Author: rsmithlal

Gemfile.lock

@@ -20,6 +20,7 @@ PATH
   remote: .
   specs:
     better_together (0.5.0)
+      active_storage_validations
       activerecord-import
       activerecord-postgis-adapter
       bootstrap (~> 5.3.2)
@@ -102,6 +103,11 @@ GEM
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
+    active_storage_validations (1.1.4)
+      activejob (>= 5.2.0)
+      activemodel (>= 5.2.0)
+      activestorage (>= 5.2.0)
+      activesupport (>= 5.2.0)
     activejob (7.1.3.4)
       activesupport (= 7.1.3.4)
       globalid (>= 0.3.6)
@@ -140,7 +146,7 @@ GEM
       mime-types (>= 2.99)
       unf
     ast (2.4.2)
-    autoprefixer-rails (10.4.16.0)
+    autoprefixer-rails (10.4.19.0)
       execjs (~> 2)
     aws-eventstream (1.3.0)
     aws-partitions (1.973.0)
@@ -289,7 +295,7 @@ GEM
       ruby-progressbar (~> 1.4)
     globalid (1.2.1)
       activesupport (>= 6.1)
-    google-protobuf (4.27.1-x86_64-linux)
+    google-protobuf (4.28.0-x86_64-linux)
       bigdecimal
       rake (>= 13)
     highline (3.1.0)
@@ -377,7 +383,7 @@ GEM
     nio4r (2.7.3)
     nokogiri (1.16.7-x86_64-linux)
       racc (~> 1.4)
-    noticed (2.4.1)
+    noticed (2.4.3)
       rails (>= 6.1.0)
     optimist (3.1.0)
     orm_adapter (0.5.0)
@@ -550,12 +556,12 @@ GEM
       ffi (~> 1.12)
       logger
     rubyzip (2.3.2)
-    sass-embedded (1.77.4-x86_64-linux-gnu)
-      google-protobuf (>= 3.25, < 5.0)
+    sass-embedded (1.78.0-x86_64-linux-gnu)
+      google-protobuf (~> 4.27)
     sassc (2.4.0)
       ffi (~> 1.9)
-    sassc-embedded (1.76.0)
-      sass-embedded (~> 1.76)
+    sassc-embedded (1.78.0)
+      sass-embedded (~> 1.78)
     selenium-webdriver (4.24.0)
       base64 (~> 0.2)
       logger (~> 1.4)
@@ -607,7 +613,7 @@ GEM
       unicode-display_width (>= 1.1.1, < 3)
     thor (1.3.2)
     thread_safe (0.3.6)
-    tilt (2.3.0)
+    tilt (2.4.0)
     timeout (0.4.1)
     tins (1.33.0)
       bigdecimal

app/models/better_together/content/image.rb

@@ -4,6 +4,8 @@ module Content
     class Image < Block
       include Translatable
 
+      CONTENT_TYPES = %w[image/jpeg image/png image/gif image/webp image/svg+xml].freeze
+
       has_one_attached :media
 
       delegate :url, to: :media
@@ -12,7 +14,13 @@ class Image < Block
       translates :alt_text, type: :string
       translates :caption, type: :string
 
-      validate :acceptable_media
+      validates :media,
+                presence: true,
+                attached: true,
+                processable_image: true,
+                content_type: CONTENT_TYPES,
+                size: { less_than: 100.megabytes , message: 'is too large' }
+
 
       validates :attribution_url,
                 format: {
@@ -21,9 +29,6 @@ class Image < Block
                   message: 'must be a valid URL starting with "http" or "https"'
                 }
 
-      def acceptable_media
-        return unless media.attached?
-      end
     end
   end
 end

better_together.gemspec

@@ -30,6 +30,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'activerecord-import'
   spec.add_dependency 'activerecord-postgis-adapter'
+  spec.add_dependency 'active_storage_validations'
   spec.add_dependency 'bootstrap', '~> 5.3.2'
   spec.add_dependency 'dartsass-sprockets', '~> 3.1'
   spec.add_dependency 'devise'

lib/better_together/engine.rb

@@ -3,6 +3,7 @@
 require 'action_cable/engine'
 require 'action_text/engine'
 require 'active_storage/engine'
+require 'active_storage_validations'
 require 'activerecord-import'
 require 'better_together/column_definitions'
 require 'better_together/migration_helpers'