Don't change zoom level arbitrarily. Just use point extent

rsmithlal · rsmithlal · commit 5b3ecf8f0b9e · 2025-04-10T14:03:27.000-02:30
diff --git a/app/javascript/controllers/better_together/map_controller.js b/app/javascript/controllers/better_together/map_controller.js
@@ -95,11 +95,7 @@ export default class extends Controller {
       return marker
     })
 
-    const currentZoom = this.map.getZoom()
     const bounds = L.latLngBounds(points.map(point => [point.lat, point.lng]))
     this.map.fitBounds(bounds)
-    const newZoom = this.map.getZoom()
-    const halfwayZoom = (currentZoom + newZoom) / 2
-    this.map.setZoom(halfwayZoom)
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -95,11 +95,7 @@ export default class extends Controller {`
`95`	`95`	`return marker`
`96`	`96`	`})`
`97`	`97`
`98`		`- const currentZoom = this.map.getZoom()`
`99`	`98`	`const bounds = L.latLngBounds(points.map(point => [point.lat, point.lng]))`
`100`	`99`	`this.map.fitBounds(bounds)`
`101`		`- const newZoom = this.map.getZoom()`
`102`		`- const halfwayZoom = (currentZoom + newZoom) / 2`
`103`		`- this.map.setZoom(halfwayZoom)`
`104`	`100`	`}`
`105`	`101`	`}`