Improve test coverage

Author: rsmithlal

spec/requests/better_together/metrics/page_view_reports_download_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::Metrics::PageViewReportsController download', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  it 'downloads an attached report file' do
+    report = BetterTogether::Metrics::PageViewReport.create!(file_format: 'csv')
+    report.report_file.attach(
+      io: StringIO.new('col1,col2\n1,2\n'),
+      filename: 'report.csv',
+      content_type: 'text/csv'
+    )
+
+    get better_together.download_metrics_page_view_report_path(locale:, id: report.id)
+    expect(response).to have_http_status(:ok)
+    expect(response.header['Content-Type']).to include('text/csv')
+  end
+end

spec/requests/better_together/metrics/page_views_controller_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::Metrics::PageViewsController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  it 'creates a page view with valid params' do
+    page = create(:better_together_page)
+
+    post better_together.metrics_page_views_path(locale:), params: {
+      viewable_type: page.class.name,
+      viewable_id: page.id,
+      locale: locale.to_s
+    }
+
+    expect(response).to have_http_status(:ok)
+    expect(JSON.parse(response.body)['success']).to eq(true)
+  end
+
+  it 'returns 422 for invalid viewable' do
+    post better_together.metrics_page_views_path(locale:), params: {
+      viewable_type: 'NonExistent',
+      viewable_id: '123',
+      locale: locale.to_s
+    }
+
+    expect(response).to have_http_status(:unprocessable_content)
+  end
+end

spec/requests/better_together/metrics/search_queries_controller_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::Metrics::SearchQueriesController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  it 'tracks a search query with valid params' do
+    post better_together.metrics_search_queries_path(locale:), params: {
+      query: 'test',
+      results_count: 3
+    }
+    expect(response).to have_http_status(:ok)
+    expect(JSON.parse(response.body)['success']).to eq(true)
+  end
+
+  it 'returns 422 for invalid params' do
+    post better_together.metrics_search_queries_path(locale:), params: { query: '', results_count: '' }
+    expect(response).to have_http_status(:unprocessable_content)
+  end
+end

spec/requests/better_together/metrics/shares_controller_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::Metrics::SharesController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  it 'tracks a share with valid params' do
+    post better_together.metrics_shares_path(locale:), params: {
+      platform: 'facebook',
+      url: 'https://example.com/post/1',
+      shareable_type: 'BetterTogether::Post',
+      shareable_id: SecureRandom.uuid
+    }
+    expect(response).to have_http_status(:ok)
+    expect(JSON.parse(response.body)['success']).to eq(true)
+  end
+
+  it 'returns 422 for invalid platform/url' do
+    post better_together.metrics_shares_path(locale:), params: { platform: 'unknown', url: 'notaurl' }
+    expect(response).to have_http_status(:unprocessable_content)
+  end
+end

spec/requests/better_together/person_community_memberships_controller_spec.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+# rubocop:todo Metrics/BlockLength
+RSpec.describe 'BetterTogether::PersonCommunityMembershipsController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'POST /:locale/.../host/communities/:community_id/person_community_memberships' do
+    it 'creates a membership and redirects when actor has update_community permission' do
+      community = create(:better_together_community)
+
+      # Ensure current user has the required permission on this community
+      coordinator_role = BetterTogether::Role.find_by(identifier: 'community_coordinator')
+      BetterTogether::PersonCommunityMembership.create!(
+        joinable: community,
+        member: BetterTogether::User.find_by(email: '[email protected]').person,
+        role: coordinator_role
+      )
+
+      member = create(:better_together_person)
+      target_role = BetterTogether::Role.find_by(identifier: 'community_member')
+
+      post better_together.community_person_community_memberships_path(locale:, community_id: community.id), params: {
+        person_community_membership: {
+          member_id: member.id,
+          role_id: target_role.id
+        }
+      }
+
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'DELETE /:locale/.../host/communities/:community_id/person_community_memberships/:id' do
+    it 'destroys a membership and redirects' do
+      community = create(:better_together_community)
+      coordinator_role = BetterTogether::Role.find_by(identifier: 'community_coordinator')
+      BetterTogether::PersonCommunityMembership.create!(
+        joinable: community,
+        member: BetterTogether::User.find_by(email: '[email protected]').person,
+        role: coordinator_role
+      )
+
+      member = create(:better_together_person)
+      target_role = BetterTogether::Role.find_by(identifier: 'community_member')
+      membership = BetterTogether::PersonCommunityMembership.create!(
+        joinable: community,
+        member: member,
+        role: target_role
+      )
+
+      delete better_together.community_person_community_membership_path(locale:, community_id: community.id,
+                                                                        id: membership.id)
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end
+# rubocop:enable Metrics/BlockLength