Skip to content

Commit 650c33e

Browse files
committed
Only auto-toggle nav-tabs and nav-tab-panes
Prevents toggling of translated attributes or nested tab panes
1 parent 575e66b commit 650c33e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

app/javascript/controllers/better_together/tabs_controller.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ export default class extends Controller {
5555
if (selectedTab.closest('.localized-fields')) break;
5656

5757
const tabTarget = this.element.querySelector(`${selectedTab.dataset.bsTarget}`);
58-
const tabPanes = this.element.querySelectorAll('.tab-pane');
58+
const tabPanes = this.element.querySelectorAll('.nav-tab-pane');
5959

60-
this.tabTargets.forEach((pane) => {
61-
pane.classList.remove('active');
60+
this.tabTargets.forEach((tab) => {
61+
tab.classList.remove('active');
6262
});
6363
selectedTab.classList.add('active');
6464

0 commit comments

Comments
 (0)