fix event specs and factories

Author: rsmithlal

spec/factories/better_together/events.rb

@@ -1,6 +1,14 @@
 # frozen_string_literal: true
 
+require 'faker'
+
 FactoryBot.define do
-  factory :event do # rubocop:todo Lint/EmptyBlock
+  factory :event, class: 'BetterTogether::Event' do
+    name { "Event \#{Faker::Lorem.unique.word}" }
+    starts_at { 1.day.from_now }
+
+    trait :draft do
+      after(:create) { |event| event.update_column(:starts_at, nil) }
+    end
   end
 end

spec/factories/better_together/users.rb

@@ -20,8 +20,13 @@
 
     trait :platform_manager do
       after(:create) do |user|
-        host_platform = BetterTogether::Platform.find_or_create_by(host: true)
-        platform_manager_role = BetterTogether::Role.find_by(identifier: 'platform_manager')
+        host_platform = BetterTogether::Platform.find_by(host: true) || create(:platform, :host)
+        platform_manager_role = BetterTogether::Role.find_by(identifier: 'platform_manager') ||
+                                create(:better_together_role,
+                                       identifier: 'platform_manager',
+                                       name: 'Platform Manager',
+                                       resource_type: 'BetterTogether::Platform',
+                                       protected: true)
         host_platform.person_platform_memberships.create!(
           member: user.person,
           role: platform_manager_role

spec/features/events/index_spec.rb

@@ -10,9 +10,9 @@
     login_as_platform_manager
   end
 
-  let!(:draft_event) { BetterTogether::Event.create!(name: 'Draft Event') }
-  let!(:upcoming_event) { BetterTogether::Event.create!(name: 'Upcoming Event', starts_at: 1.day.from_now) }
-  let!(:past_event) { BetterTogether::Event.create!(name: 'Past Event', starts_at: 2.days.ago) }
+  let!(:draft_event) { create(:event, :draft, name: 'Draft Event') }
+  let!(:upcoming_event) { create(:event, name: 'Upcoming Event', starts_at: 1.day.from_now) }
+  let!(:past_event) { create(:event, name: 'Past Event', starts_at: 2.days.ago) }
 
   scenario 'displays events grouped by status' do
     visit events_path(locale: I18n.default_locale)

spec/requests/better_together/events_spec.rb

@@ -9,7 +9,7 @@
   let(:locale) { I18n.default_locale }
 
   describe 'GET /events' do
-    let!(:event) { BetterTogether::Event.create!(name: 'Sample Event') }
+    let!(:event) { create(:event) }
 
     it 'returns http success' do
       get events_path(locale: locale)
@@ -24,28 +24,29 @@
 
     it 'creates an event' do
       expect do
-        post events_path(locale: locale), params: { event: { name: 'New Event' } }
+        post events_path(locale: locale),
+             params: { event: { name: 'New Event', starts_at: 1.day.from_now } }
       end.to change(BetterTogether::Event, :count).by(1)
       expect(response).to redirect_to(event_path(BetterTogether::Event.last, locale: locale))
     end
   end
 
   describe 'PATCH /events/:id' do
     let(:user) { create(:better_together_user, :confirmed, :platform_manager) }
-    let!(:event) { BetterTogether::Event.create!(name: 'Old Name', creator: user.person) }
+    let!(:event) { create(:event, name: 'Old Name', creator: user.person) }
 
     before { login(user) }
 
     it 'updates the event' do
-      patch event_path(event, locale: locale), params: { event: { name: 'Updated Name' } }
+      patch event_path(event, locale: locale), params: { event: { name: 'Updated Name', starts_at: 1.day.from_now } }
       expect(response).to redirect_to(edit_event_path(event, locale: locale))
       expect(event.reload.name).to eq('Updated Name')
     end
   end
 
   describe 'DELETE /events/:id' do
     let(:user) { create(:better_together_user, :confirmed, :platform_manager) }
-    let!(:event) { BetterTogether::Event.create!(name: 'Delete Me', creator: user.person) }
+    let!(:event) { create(:event, name: 'Delete Me', creator: user.person) }
 
     before { login(user) }