Add checklist and checklist item management features

- Implement ChecklistPolicy and ChecklistItemPolicy for authorization.
- Create views for checklists including index, show, new, edit, and form partials.
- Add routes for checklists and nested checklist items.
- Create migrations for checklists and checklist items with necessary fields.
- Add factories for checklist and checklist items for testing.
- Implement request specs for checklist CRUD operations and authorization.
- Update locale files for checklist-related translations.

Author: rsmithlal

app/controllers/better_together/checklist_items_controller.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+module BetterTogether
+  class ChecklistItemsController < FriendlyResourceController # rubocop:todo Style/Documentation
+    before_action :set_checklist
+    before_action :checklist_item, only: %i[show edit update destroy]
+
+    helper_method :new_checklist_item
+
+    def create # rubocop:todo Metrics/AbcSize
+      @checklist_item = new_checklist_item
+      @checklist_item.assign_attributes(resource_params)
+      authorize @checklist_item
+
+      if @checklist_item.save
+        redirect_to request.referer || checklist_path(@checklist), notice: t('flash.generic.created')
+      else
+        redirect_to request.referer || checklist_path(@checklist),
+                    alert: @checklist_item.errors.full_messages.to_sentence
+      end
+    end
+
+    def update
+      authorize @checklist_item
+
+      if @checklist_item.update(resource_params)
+        redirect_to request.referer || checklist_path(@checklist), notice: t('flash.generic.updated')
+      else
+        redirect_to request.referer || checklist_path(@checklist),
+                    alert: @checklist_item.errors.full_messages.to_sentence
+      end
+    end
+
+    def destroy
+      authorize @checklist_item
+
+      @checklist_item.destroy
+      redirect_to request.referer || checklist_path(@checklist), notice: t('flash.generic.deleted')
+    end
+
+    private
+
+    def set_checklist
+      @checklist = BetterTogether::Checklist.find(params[:checklist_id] || params[:id])
+    end
+
+    def checklist_item
+      @checklist_item = set_resource_instance
+    end
+
+    def new_checklist_item
+      @checklist.checklist_items.new
+    end
+
+    def resource_class
+      ::BetterTogether::ChecklistItem
+    end
+
+    def resource_collection
+      resource_class.where(checklist: @checklist)
+    end
+  end
+end

app/controllers/better_together/checklists_controller.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module BetterTogether
+  class ChecklistsController < FriendlyResourceController # rubocop:todo Style/Documentation
+    def create
+      @checklist = resource_class.new(resource_params)
+      authorize @checklist
+      @checklist.creator = helpers.current_person if @checklist.respond_to?(:creator=)
+
+      if @checklist.save
+        redirect_to @checklist, notice: t('flash.generic.created')
+      else
+        render :new, status: :unprocessable_entity
+      end
+    end
+
+    private
+
+    def resource_class
+      ::BetterTogether::Checklist
+    end
+  end
+end

app/models/better_together/checklist.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module BetterTogether
+  class Checklist < ApplicationRecord # rubocop:todo Style/Documentation
+    include Identifier
+    include Creatable
+    include FriendlySlug
+    include Protected
+    include Privacy
+
+    has_many :checklist_items, class_name: '::BetterTogether::ChecklistItem', dependent: :destroy
+    has_many :person_checklist_items, class_name: '::BetterTogether::PersonChecklistItem', dependent: :destroy
+
+    translates :title, type: :string
+
+    slugged :title
+
+    validates :title, presence: true
+
+    # Returns checklist items along with per-person completions for a given person
+    def items_with_progress_for(person)
+      checklist_items.includes(:translations).map do |item|
+        {
+          item: item,
+          done: item.done_for?(person),
+          completion_record: BetterTogether::PersonChecklistItem.find_by(person:, checklist: self,
+                                                                         checklist_item: item)
+        }
+      end
+    end
+
+    # Percentage of items completed for a given person (0..100)
+    def completion_percentage_for(person)
+      total = checklist_items.count
+      return 0 if total.zero?
+
+      completed = person_checklist_items.where(person:, done: true).count
+      ((completed.to_f / total) * 100).round
+    end
+
+    def to_param
+      slug
+    end
+  end
+end

app/models/better_together/checklist_item.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+module BetterTogether
+  # An item belonging to a Checklist. Translated label and description.
+  class ChecklistItem < ApplicationRecord
+    include Identifier
+    include Creatable
+    include FriendlySlug
+    include Positioned
+    include Protected
+    include Privacy
+
+    belongs_to :checklist, class_name: '::BetterTogether::Checklist', inverse_of: :checklist_items
+
+    translates :label, type: :string
+    translates :description, backend: :action_text
+
+    slugged :label
+
+    validates :label, presence: true
+
+    # Per-person completion helpers
+    def done_for?(person)
+      return false unless person
+
+      BetterTogether::PersonChecklistItem.completed.exists?(person:, checklist: checklist, checklist_item: self)
+    end
+
+    def completion_record_for(person)
+      BetterTogether::PersonChecklistItem.find_by(person:, checklist: checklist, checklist_item: self)
+    end
+
+    def self.permitted_attributes(id: false, destroy: false)
+      super + %i[checklist_id]
+    end
+
+    def to_s
+      label
+    end
+  end
+end

app/models/better_together/person_checklist_item.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+module BetterTogether
+  class PersonChecklistItem < ApplicationRecord # rubocop:todo Style/Documentation
+    include Creatable
+    include Protected
+
+    belongs_to :person, class_name: 'BetterTogether::Person'
+    belongs_to :checklist, class_name: 'BetterTogether::Checklist'
+    belongs_to :checklist_item, class_name: 'BetterTogether::ChecklistItem'
+
+    validates :person, :checklist, :checklist_item, presence: true
+
+    before_save :enforce_directional_progression, if: :setting_completed_at?
+
+    def mark_done!(completed_at: Time.zone.now)
+      update!(completed_at: completed_at)
+    end
+
+    def mark_undone!
+      update!(completed_at: nil)
+    end
+
+    def done?
+      completed_at.present?
+    end
+
+    scope :completed, -> { where.not(completed_at: nil) }
+    scope :pending, -> { where(completed_at: nil) }
+
+    private
+
+    def setting_completed_at?
+      completed_at_changed? && completed_at.present?
+    end
+
+    def enforce_directional_progression # rubocop:todo Metrics/AbcSize
+      return unless checklist&.directional
+
+      # Find any items with position less than this item that are not completed for this person
+      earlier_items = checklist.checklist_items.where('position < ?', checklist_item.position)
+
+      return if earlier_items.none?
+
+      incomplete = earlier_items.any? do |item|
+        !BetterTogether::PersonChecklistItem.where.not(completed_at: nil).exists?(person:, checklist:,
+                                                                                  checklist_item: item)
+      end
+
+      return unless incomplete
+
+      errors.add(:completed_at, I18n.t('errors.models.person_checklist_item.directional_incomplete'))
+      throw(:abort)
+    end
+  end
+end

app/policies/better_together/checklist_item_policy.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module BetterTogether
+  class ChecklistItemPolicy < ApplicationPolicy # rubocop:todo Style/Documentation
+    def show?
+      # If parent checklist is public or user can update checklist
+      record.checklist.privacy_public? || ChecklistPolicy.new(user, record.checklist).update?
+    end
+
+    def create?
+      ChecklistPolicy.new(user, record.checklist).update?
+    end
+
+    def update?
+      ChecklistPolicy.new(user, record.checklist).update?
+    end
+
+    def destroy?
+      ChecklistPolicy.new(user, record.checklist).destroy?
+    end
+
+    class Scope < ApplicationPolicy::Scope # rubocop:todo Style/Documentation
+      def resolve
+        scope.with_translations
+      end
+    end
+  end
+end

app/policies/better_together/checklist_policy.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module BetterTogether
+  class ChecklistPolicy < ApplicationPolicy # rubocop:todo Style/Documentation
+    def show?
+      # Allow viewing public checklists to everyone, otherwise fall back to update permissions
+      record.privacy_public? || update?
+    end
+
+    def index?
+      # Let policy_scope handle visibility; index access is allowed (scope filters public/private)
+      true
+    end
+
+    def create?
+      permitted_to?('manage_platform')
+    end
+
+    def update?
+      permitted_to?('manage_platform') || (agent.present? && record.creator == agent)
+    end
+
+    def destroy?
+      permitted_to?('manage_platform') && !record.protected?
+    end
+
+    class Scope < ApplicationPolicy::Scope # rubocop:todo Style/Documentation
+      def resolve
+        scope.with_translations
+      end
+    end
+  end
+end

app/views/better_together/checklists/_checklist.html.erb

@@ -0,0 +1,19 @@
+<!-- app/views/better_together/checklists/_checklist.html.erb -->
+
+<li class="list-group-item d-flex justify-content-between align-items-center" id="<%= dom_id(checklist) %>">
+  <div>
+    <%= link_to checklist.title, better_together.checklist_path(checklist, locale: I18n.locale), class: 'h6 mb-0' %>
+    <% if checklist.creator.present? %>
+      <small class="text-muted ms-2">&middot; <%= checklist.creator.to_s %></small>
+    <% end %>
+  </div>
+
+  <div class="text-end">
+    <%= render 'shared/resource_toolbar',
+               back_to_list_path: better_together.checklists_path(locale: I18n.locale),
+               edit_path: (policy(checklist).update? ? better_together.edit_checklist_path(checklist, locale: I18n.locale) : nil),
+               destroy_path: (policy(checklist).destroy? ? better_together.checklist_path(checklist, locale: I18n.locale) : nil) do %>
+      <span class="badge bg-secondary"><%= checklist.privacy %></span>
+    <% end %>
+  </div>
+</li>

app/views/better_together/checklists/_form.html.erb

@@ -0,0 +1,42 @@
+<!-- app/views/better_together/checklists/_form.html.erb -->
+
+<%= content_tag :div, id: 'checklist_form' do %>
+  <%= form_with(model: [@checklist], local: true, class: 'form') do |form| %>
+    <% content_for :action_toolbar do %>
+      <div class="btn-toolbar mb-3" role="toolbar" aria-label="Toolbar with button groups">
+        <div class="btn-group me-2" role="group">
+          <%= link_to t('globals.back_to_list'), better_together.checklists_path(locale: I18n.locale), class: 'btn btn-secondary' %>
+        </div>
+        <div class="btn-group me-2" role="group">
+          <%= form.submit class: 'btn btn-primary' %>
+        </div>
+      </div>
+    <% end %>
+
+    <%= yield :action_toolbar %>
+
+    <div id="form_errors">
+      <% if @checklist.errors.any? %>
+        <div class="alert alert-danger">
+          <h4><%= pluralize(@checklist.errors.count, "error") %> prohibited this checklist from being saved:</h4>
+          <ul>
+            <% @checklist.errors.full_messages.each do |message| %>
+              <li><%= message %></li>
+            <% end %>
+          </ul>
+        </div>
+      <% end %>
+    </div>
+
+    <div class="mb-3">
+      <%= render partial: 'better_together/shared/translated_string_field', locals: { model: @checklist, form: form, attribute: 'title' } %>
+    </div>
+
+    <div class="mb-3">
+      <%= form.label :privacy %>
+      <%= form.select :privacy, options_for_select([['Public', 'public'], ['Private', 'private']], @checklist.privacy), {}, class: 'form-select' %>
+    </div>
+
+    <%= yield :action_toolbar %>
+  <% end %>
+<% end %>

app/views/better_together/checklists/edit.html.erb

@@ -0,0 +1,11 @@
+<!-- app/views/better_together/checklists/edit.html.erb -->
+
+<% content_for :page_title do %>
+	<%= t('better_together.checklists.edit.title', default: 'Edit Checklist') %>
+<% end %>
+
+<div class="container my-3">
+	<h1 class="mb-3"><%= t('better_together.checklists.edit.title', default: 'Edit Checklist') %></h1>
+
+	<%= render partial: 'form' %>
+</div>