Skip to content

Commit 6d7f1b0

Browse files
committed
Ensure that image preview clear buttons work as expected
1 parent 3a6242b commit 6d7f1b0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/views/better_together/communities/_community_fields.html.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<%# Hidden field to track removal state %>
6969
<%= form.hidden_field :remove_profile_image, value: '0', "data-better_together--image-preview-target" => "deleteField" %>
7070

71-
<%= button_tag t('globals.clear'), { type: 'button', class: 'btn btn-secondary', "data-better_together--image-preview-target" => "deleteButton", data: { 'clearValue' => t('globals.clear'), 'undoClearValue' => t('globals.undo_clear'), 'noImageValue' => t('globals.no_image') } } %>
71+
<%= button_tag t('globals.clear'), { type: 'button', class: 'btn btn-secondary', "data-better_together--image-preview-target" => "deleteButton", data: { 'action' => "better_together--image-preview#toggleDelete", 'clear-value' => t('globals.clear'), 'undo-clear-value' => t('globals.undo_clear'), 'no-image-value' => t('globals.no_image') } } %>
7272
</div>
7373

7474
<small class="form-text text-muted"><%= t('helpers.hint.person.profile_image') %></small>
@@ -94,7 +94,7 @@
9494
<%# Hidden field to track removal state %>
9595
<%= form.hidden_field :remove_cover_image, value: '0', "data-better_together--image-preview-target" => "deleteField" %>
9696

97-
<%= button_tag t('globals.clear'), { type: 'button', class: 'btn btn-secondary', 'data-better_together--image-preview-target' => "deleteButton", data: { 'action' => "better_together--image-preview#toggleDelete", clearValue: t('globals.clear'), undoClearValue: t('globals.undo_clear'), noImageValue: t('globals.no_image') } } %>
97+
<%= button_tag t('globals.clear'), { type: 'button', class: 'btn btn-secondary', 'data-better_together--image-preview-target' => "deleteButton", data: { 'action' => "better_together--image-preview#toggleDelete", 'clear-value' => t('globals.clear'), 'undo-clear-value' => t('globals.undo_clear'), 'no-image-value' => t('globals.no_image') } } %>
9898
</div>
9999

100100
<small class="form-text text-muted"><%= t('helpers.hint.community.cover_image') %></small>
@@ -120,7 +120,7 @@
120120
<%# Hidden field to track removal state %>
121121
<%= form.hidden_field :remove_logo, value: '0', "data-better_together--image-preview-target" => "deleteField" %>
122122

123-
<%= button_tag t('globals.clear'), { type: 'button', class: 'btn btn-secondary', "data-better_together--image-preview-target" => "deleteButton", data: { 'clearValue' => t('globals.clear'), 'undoClearValue' => t('globals.undo_clear'), 'noImageValue' => t('globals.no_image') } } %>
123+
<%= button_tag t('globals.clear'), { type: 'button', class: 'btn btn-secondary', "data-better_together--image-preview-target" => "deleteButton", data: { 'action' => "better_together--image-preview#toggleDelete", 'clear-value' => t('globals.clear'), 'undo-clear-value' => t('globals.undo_clear'), 'no-image-value' => t('globals.no_image') } } %>
124124
</div>
125125

126126
<small class="form-text text-muted"><%= t('helpers.hint.community.logo') %></small>

app/views/better_together/content/blocks/fields/shared/_image_field.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<%- required = !attachment.attached? if required %>
55

66
<div class="image-fields" data-controller="better_together--image-preview"
7-
data-image-preview-clear-value="<%= t('globals.clear') %>"
8-
data-image-preview-undo-clear-value="<%= t('globals.undo_clear') %>">
7+
data-better_together--image-preview-clear-value="<%= t('globals.clear') %>"
8+
data-better_together--image-preview-undo-clear-value="<%= t('globals.undo_clear') %>">
99
<%= label_tag do %>
1010
<%= block.class.human_attribute_name(attribute) %>
1111
<% if attachment.attached? %>

0 commit comments

Comments
 (0)