Rubocop fixes

Author: rsmithlal

app/controllers/better_together/navigation_items_controller.rb

@@ -5,9 +5,9 @@
 module BetterTogether
   # Responds to requests for navigation items
   class NavigationItemsController < FriendlyResourceController # rubocop:todo Metrics/ClassLength
-    before_action :set_navigation_area
+    before_action :navigation_area
     before_action :set_pages, only: %i[new edit create update]
-    before_action :set_navigation_item, only: %i[show edit update destroy]
+    before_action :navigation_item, only: %i[show edit update destroy]
 
     helper_method :available_parent_items
 
@@ -103,14 +103,14 @@ def set_pages
       )
     end
 
-    def set_navigation_area
+    def navigation_area
       @navigation_area ||= find_by_translatable(
         translatable_type: ::BetterTogether::NavigationArea.name,
         friendly_id: params[:navigation_area_id]
       )
     end
 
-    def set_navigation_item
+    def navigation_item
       @navigation_item = set_resource_instance
     end
 

app/models/better_together/community.rb

@@ -71,16 +71,14 @@ def optimized_profile_image
       if profile_image.content_type == 'image/svg+xml'
         # If SVG, return the original without transformation
         profile_image
+
+      # For other formats, analyze to determine transparency
+      elsif profile_image.content_type == 'image/png'
+        # If PNG with transparency, return the optimized PNG variant
+        profile_image.variant(:optimized_png).processed
       else
-        # For other formats, analyze to determine transparency
-        metadata = profile_image.metadata
-        if profile_image.content_type == 'image/png'
-          # If PNG with transparency, return the optimized PNG variant
-          profile_image.variant(:optimized_png).processed
-        else
-          # Otherwise, use the optimized JPG variant
-          profile_image.variant(:optimized_jpeg).processed
-        end
+        # Otherwise, use the optimized JPG variant
+        profile_image.variant(:optimized_jpeg).processed
       end
     end