Rubocop fixes

Author: rsmithlal

spec/helpers/better_together/hub_helper_spec.rb

@@ -2,6 +2,7 @@
 
 require 'rails_helper'
 
+# rubocop:disable Metrics/ModuleLength
 module BetterTogether
   RSpec.describe HubHelper do
     describe '#activities' do
@@ -217,3 +218,4 @@ module BetterTogether
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

spec/jobs/better_together/platform_invitation_mailer_job_spec.rb

@@ -2,6 +2,7 @@
 
 require 'rails_helper'
 
+# rubocop:disable Metrics/ModuleLength
 module BetterTogether
   RSpec.describe PlatformInvitationMailerJob do
     include ActiveSupport::Testing::TimeHelpers
@@ -228,3 +229,4 @@ module BetterTogether
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

spec/lib/better_together/migration_helpers_spec.rb

@@ -2,6 +2,7 @@
 
 require 'rails_helper'
 
+# rubocop:disable Metrics/ModuleLength, RSpec/StubbedMock, RSpec/VerifiedDoubles, RSpec/RepeatedExample
 module BetterTogether
   RSpec.describe MigrationHelpers do
     # Create a test migration class to include the module
@@ -344,3 +345,4 @@ module BetterTogether
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength, RSpec/StubbedMock, RSpec/VerifiedDoubles, RSpec/RepeatedExample

spec/mailers/better_together/platform_invitation_mailer_spec.rb

@@ -2,6 +2,7 @@
 
 require 'rails_helper'
 
+# rubocop:disable Metrics/ModuleLength
 module BetterTogether
   RSpec.describe PlatformInvitationMailer do
     describe '#invite' do
@@ -63,11 +64,7 @@ module BetterTogether
                 locale: 'en')
         end
 
-        it 'returns nil without sending' do
-          expect(mail.message).to be_a(ActionMailer::Base::NullMail)
-        end
-
-        it 'does not render the email body' do
+        it 'returns NullMail without sending' do
           expect(mail.message).to be_a(ActionMailer::Base::NullMail)
         end
       end
@@ -176,11 +173,7 @@ module BetterTogether
           expect(mail.body.encoded).to match(platform_invitation.greeting.to_plain_text)
         end
 
-        it 'assigns @valid_from' do
-          expect(mail.body.encoded).to be_present
-        end
-
-        it 'assigns @valid_until' do
+        it 'assigns @valid_from and @valid_until' do
           expect(mail.body.encoded).to be_present
         end
 
@@ -191,3 +184,4 @@ module BetterTogether
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

spec/requests/better_together/setup_wizard_steps_controller_spec.rb

@@ -2,6 +2,7 @@
 
 require 'rails_helper'
 
+# rubocop:disable Metrics/ModuleLength
 module BetterTogether
   RSpec.describe SetupWizardStepsController, :skip_host_setup do
     let(:wizard) { Wizard.find_or_create_by!(identifier: 'host_setup') }
@@ -130,9 +131,11 @@ module BetterTogether
           invalid_platform = Platform.new
           invalid_platform.errors.add(:base, 'Test validation error')
 
+          # rubocop:disable RSpec/AnyInstance
           allow_any_instance_of(Platform).to receive(:save!).and_raise(
             ActiveRecord::RecordInvalid.new(invalid_platform)
           )
+          # rubocop:enable RSpec/AnyInstance
 
           post better_together.setup_wizard_step_create_host_platform_path(locale: I18n.default_locale),
                params: { platform: valid_platform_params }
@@ -210,7 +213,8 @@ module BetterTogether
       context 'with valid parameters' do
         before do
           # Wizard should start with ZERO users and create the first one
-          expect(User.count).to eq(0), "Expected 0 users before wizard creates first admin, found #{User.count}"
+          raise "Expected 0 users before wizard creates first admin, found #{User.count}" unless User.none?
+
           post better_together.setup_wizard_step_create_admin_path(locale: I18n.default_locale),
                params: { user: valid_user_params }
         end
@@ -307,9 +311,11 @@ module BetterTogether
           invalid_user = User.new
           invalid_user.errors.add(:base, 'Test validation error')
 
+          # rubocop:disable RSpec/AnyInstance
           allow_any_instance_of(User).to receive(:save!).and_raise(
             ActiveRecord::RecordInvalid.new(invalid_user)
           )
+          # rubocop:enable RSpec/AnyInstance
 
           post better_together.setup_wizard_step_create_admin_path(locale: I18n.default_locale),
                params: { user: valid_user_params }
@@ -372,7 +378,9 @@ module BetterTogether
 
       describe '#base_platform' do
         before do
+          # rubocop:disable RSpec/MessageChain
           allow(controller).to receive_message_chain(:helpers, :base_url).and_return('http://test.example.com')
+          # rubocop:enable RSpec/MessageChain
         end
 
         it 'creates a platform with default attributes' do
@@ -387,3 +395,4 @@ module BetterTogether
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

spec/requests/better_together/translations_controller_spec.rb

@@ -2,6 +2,7 @@
 
 require 'rails_helper'
 
+# rubocop:disable Metrics/ModuleLength
 module BetterTogether
   RSpec.describe TranslationsController, :as_user do
     describe 'POST #translate' do
@@ -153,11 +154,7 @@ module BetterTogether
       end
 
       context 'when current_person is nil' do
-        it 'passes nil as initiator' do
-          skip 'Route requires authentication, so current_person cannot be nil in practice'
-        end
-
-        it 'still returns successful translation' do
+        it 'handles nil initiator and returns successful translation' do
           skip 'Route requires authentication, so current_person cannot be nil in practice'
         end
       end
@@ -211,3 +208,4 @@ module BetterTogether
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

spec/sanitizers/better_together/sanitizers/external_link_icon_sanitizer_spec.rb

@@ -3,6 +3,7 @@
 require 'rails_helper'
 
 module BetterTogether
+  # rubocop:disable Metrics/ModuleLength
   module Sanitizers
     RSpec.describe ExternalLinkIconSanitizer do
       let(:sanitizer) { described_class.new }
@@ -294,4 +295,5 @@ module Sanitizers
       end
     end
   end
+  # rubocop:enable Metrics/ModuleLength
 end