Fix event policy to correctly check for event start date in ICS link visibility

Author: rsmithlal

app/policies/better_together/event_policy.rb

@@ -11,7 +11,9 @@ def show?
       (record.privacy_public? && record.starts_at.present?) || creator_or_manager || event_host_member?
     end
 
-    alias ics? show?
+    def ics?
+      record.starts_at.present? && show?
+    end
 
     def update?
       creator_or_manager || event_host_member?

app/views/better_together/events/show.html.erb

@@ -35,7 +35,7 @@
                    destroy_path: policy(@resource).destroy? ? event_path(@resource) : nil,
                    destroy_confirm: t('globals.confirm_delete'),
                    destroy_aria_label: 'Delete Record' do %>
-          <%= link_to t('better_together.events.add_to_calendar', default: 'Add to calendar (.ics)'), ics_event_path(@event), class: 'btn btn-outline-secondary btn-sm' %>
+          <%= link_to t('better_together.events.add_to_calendar', default: 'Add to calendar (.ics)'), ics_event_path(@event), class: 'btn btn-outline-secondary btn-sm' if policy(@event).ics? %>
         <% end %>
       </div>
     </div>