Refactor RSpec tests for ReportPORO and LinkCheckerReportsController to improve clarity and maintainability

Author: rsmithlal

spec/models/better_together/metrics/link_checker_report_spec.rb

@@ -61,8 +61,7 @@ def generate_csv_file
   # rubocop:enable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 end
 
-# rubocop:disable RSpec/DescribeClass
-RSpec.describe 'ReportPORO (test helper)' do
+RSpec.describe ReportPORO do
   describe 'CSV generation and filename' do
     let(:report) do
       described_class.new(filters: { 'from_date' => '2025-09-01', 'to_date' => '2025-09-02' })

spec/requests/better_together/metrics/link_checker_reports_controller_spec.rb

@@ -23,13 +23,18 @@ def persisted?
         false
       end
 
+      # Instances should expose filters so form helpers like f.select can read values
+      def filters
+        {}
+      end
+
       def self.order(*)
         []
       end
 
       def self.create_and_generate!(*_args)
         file = Struct.new(:attached?).new(false)
-        Struct.new(:id, :persisted?, :report_file).new(SecureRandom.uuid, true, file)
+  Struct.new(:id, :persisted?, :report_file).new(SecureRandom.uuid, true, file)
       end
 
       def self.find(id)