Rubocop fixes

Author: rsmithlal

app/controllers/better_together/platform_invitations_controller.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 module BetterTogether
+  # rubocop:todo Metrics/ClassLength
   class PlatformInvitationsController < ApplicationController # rubocop:todo Style/Documentation
     before_action :set_platform
     before_action :set_platform_invitation, only: %i[destroy resend]
@@ -124,8 +125,9 @@ def param_invitation_class
       param_type = params[:platform_invitation][:type]
 
       Rails.application.eager_load! if Rails.env.development? # Ensure all models are loaded
-      valid_types = [ BetterTogether::PlatformInvitation, *BetterTogether::PlatformInvitation.descendants ].map(&:to_s)
-      invitation_type = param_type.constantize if valid_types.include?(param_type)
+      valid_types = [BetterTogether::PlatformInvitation, *BetterTogether::PlatformInvitation.descendants].map(&:to_s)
+      param_type.constantize if valid_types.include?(param_type)
     end
   end
+  # rubocop:enable Metrics/ClassLength
 end

app/models/concerns/better_together/member.rb

@@ -127,9 +127,7 @@ def membership_class_for(record)
       def cache_key_for(method, identifier = nil, record = nil)
         base_key = "better_together/member/#{self.class.name}/#{id}/#{cache_version}/#{method}"
         key = identifier ? "#{base_key}/#{identifier}" : base_key
-        key = record ? "#{key}/#{record.class.name}/#{record.identifier}" : key
-
-        key
+        record ? "#{key}/#{record.class.name}/#{record.identifier}" : key
       end
     end
   end