Improve test coverage for users controller and fix users redirect route name overshadow

Author: rsmithlal

config/routes.rb

@@ -31,7 +31,8 @@
                  defaults: { format: :html, locale: I18n.locale }
 
       get 'search', to: 'search#search'
-      get 'users', to: redirect('users/sign-in') # redirect for user after_sign_up
+      # Avoid clobbering admin users_path helper; keep redirect but rename helper
+      get 'users', to: redirect('users/sign-in'), as: :redirect_users # redirect for user after_sign_up
 
       authenticated :user do # rubocop:todo Metrics/BlockLength
         resources :calendars

spec/requests/better_together/users_controller_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::UsersController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../host/users' do
+    it 'renders index' do
+      get better_together.users_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'renders show for the current user' do
+      user = BetterTogether::User.find_by(email: '[email protected]')
+      get better_together.user_path(locale:, id: user.id)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end