fix rspec errors

Author: rsmithlal

app/models/better_together/navigation_item.rb

@@ -125,7 +125,7 @@ def url
       elsif route_name.present? # If the route_name is present, use the dynamic route
         retrieve_route(route_name)
       else
-        read_attribute(:url) # or super
+        read_attribute(:url) or _url
       end
     end
 

spec/factories/better_together/navigation_areas.rb

@@ -7,7 +7,7 @@
           class: 'BetterTogether::NavigationArea',
           aliases: %i[navigation_area] do
     id { SecureRandom.uuid }
-    name { Faker::Commerce.department(max: 1) } # Ensure uniqueness
+    name { Faker::Lorem.unique.sentence } # Ensure uniqueness
     identifier { name.parameterize }
     style { Faker::Lorem.word }
     visible { Faker::Boolean.boolean }

spec/factories/better_together/pages.rb

@@ -12,12 +12,8 @@
     content { Faker::Lorem.paragraph }
     meta_description { Faker::Lorem.sentence }
     keywords { Faker::Lorem.words(number: 4).join(', ') }
-    published { Faker::Boolean.boolean }
     published_at { Faker::Date.backward(days: 30) }
     privacy { BetterTogether::Page::PRIVACY_LEVELS.keys.sample.to_s }
-    layout { Faker::Lorem.word }
-    template { Faker::Lorem.word }
-    language { 'en' }
     protected { Faker::Boolean.boolean }
   end
 end

spec/models/better_together/content/rich_text_spec.rb

@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 module BetterTogether
-  RSpec.describe Content::Block::RichText, type: :model do
+  RSpec.describe Content::RichText, type: :model do
     pending "add some examples to (or delete) #{__FILE__}"
   end
 end

spec/models/better_together/page_spec.rb

@@ -17,7 +17,6 @@ module BetterTogether
     describe 'ActiveModel validations' do
       it { is_expected.to validate_presence_of(:title) }
       it { is_expected.to validate_presence_of(:privacy) }
-      it { is_expected.to validate_presence_of(:language) }
     end
 
     describe 'Attributes' do
@@ -26,20 +25,18 @@ module BetterTogether
       it { is_expected.to respond_to(:content) }
       it { is_expected.to respond_to(:meta_description) }
       it { is_expected.to respond_to(:keywords) }
-      it { is_expected.to respond_to(:published) }
       it { is_expected.to respond_to(:published_at) }
       it { is_expected.to respond_to(:privacy) }
       it { is_expected.to respond_to(:layout) }
       it { is_expected.to respond_to(:template) }
-      it { is_expected.to respond_to(:language) }
       it { is_expected.to respond_to(:protected) }
     end
 
     describe 'Scopes' do
       describe '.published' do
         it 'returns only published pages' do
           published_page_count = Page.published.count
-          create(:better_together_page, published: false)
+          create(:better_together_page, published_at: nil)
           expect(Page.published.count).to eq(published_page_count)
         end
       end
@@ -62,12 +59,12 @@ module BetterTogether
     describe 'Methods' do
       describe '#published?' do
         it 'returns true if the page is published' do
-          page.published = true
+          page.published_at = Time.now - 2.days
           expect(page.published?).to be true
         end
 
         it 'returns false if the page is not published' do
-          page.published = false
+          page.published_at = nil
           expect(page.published?).to be false
         end
       end