Rubocop fixes

Author: rsmithlal

app/controllers/better_together/search_controller.rb

@@ -3,46 +3,58 @@
 module BetterTogether
   # Handles dispatching search queries to elasticsearch and displaying the results
   class SearchController < ApplicationController
-    def search
+    def search # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
       searchable_models = BetterTogether::Searchable.included_in_models
       @query = params[:q]
       search_results = []
       suggestions = []
 
       if @query.present?
-        response = Elasticsearch::Model.search({
-          query: {
-            bool: {
-              must: [
-                {
-                  multi_match: {
-                    query: @query,
-                    fields: ['title^3', 'content', 'blocks.rich_text_content.body^2', 'formatted_address^2', 'name^3', 'description^2'],
-                    type: 'best_fields'
-                  }
-                }
-              ]
-            }
-          },
-          suggest: {
-            text: @query,
-            suggestions: {
-              term: {
-                field: 'name',
-                suggest_mode: 'always'
-              }
-            }
-          }
-        }, searchable_models)
+        response = Elasticsearch::Model.search(build_search_query(@query), searchable_models)
 
         search_results = response.records.to_a
-        suggestions = response.response['suggest']['suggestions'].map { |s| s['options'].map { |o| o['text'] } }.flatten
+        suggestions = response.response['suggest']['suggestions'].map do |s|
+          s['options'].map do |o|
+            o['text']
+          end
+        end.flatten
       end
 
       # Use Kaminari for pagination
       @results = Kaminari.paginate_array(search_results).page(params[:page]).per(10)
       @suggestions = suggestions
     end
 
+    private
+
+    def build_search_query(query) # rubocop:todo Metrics/MethodLength
+      {
+        query: {
+          bool: {
+            must: [
+              {
+                multi_match: {
+                  query: query,
+                  fields: [
+                    'title^3', 'content', 'blocks.rich_text_content.body^2',
+                    'formatted_address^2', 'name^3', 'description^2'
+                  ],
+                  type: 'best_fields'
+                }
+              }
+            ]
+          }
+        },
+        suggest: {
+          text: query,
+          suggestions: {
+            term: {
+              field: 'name',
+              suggest_mode: 'always'
+            }
+          }
+        }
+      }
+    end
   end
 end

app/jobs/better_together/elasticsearch_index_job.rb

@@ -1,5 +1,9 @@
+# frozen_string_literal: true
 
 module BetterTogether
+  # Queues up Elasticsearch indexing jobs in the background
+  # This job is responsible for indexing and deleting documents in Elasticsearch
+  # when records are created, updated, or destroyed.
   class ElasticsearchIndexJob < ApplicationJob
     queue_as :default
 

app/models/better_together/content/block.rb

@@ -81,8 +81,8 @@ def to_s
                            end}"
       end
 
-       # Method to return the content used for Elasticsearch indexing
-       def cached_content
+      # Method to return the content used for Elasticsearch indexing
+      def cached_content
         {
           id: id,
           type: type,

app/models/concerns/better_together/searchable.rb

@@ -28,13 +28,13 @@ def self.refresh_elastic_index!
 
       # Need to create another way to access elasticsearch import.
       # class.import is using by activerecord-import, I think
-      def self.elastic_import args={}
+      def self.elastic_import(args = {})
         __elasticsearch__.import(args) unless Rails.env.test?
       end
     end
 
     class_methods do
-      def default_elasticsearch_index
+      def default_elasticsearch_index # rubocop:todo Metrics/MethodLength
         {
           number_of_shards: 1,
           analysis: {
@@ -43,13 +43,13 @@ def default_elasticsearch_index
                 type: 'edge_ngram',
                 min_gram: 2,
                 max_gram: 20,
-                token_chars: ['letter', 'digit']
+                token_chars: %w[letter digit]
               }
             },
             analyzer: {
               custom_analyzer: {
                 tokenizer: 'edge_ngram_tokenizer',
-                filter: ['lowercase', 'asciifolding']
+                filter: %w[lowercase asciifolding]
               }
             }
           }