Rubocop fixes

rsmithlal · rsmithlal · commit aba6542245b1 · 2025-08-27T18:13:41.000-02:30
diff --git a/debug_navigation_test.rb b/debug_navigation_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Debug script to investigate the navigation areas controller issue
 
 require 'rails_helper'
diff --git a/i18n_analysis.rb b/i18n_analysis.rb
@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 # Performance analysis script for I18n JavaScript optimization
 require 'json'
@@ -13,7 +14,7 @@
     'navigation' => { 'home' => 'Home', 'about' => 'About' }, # ... hundreds more keys
     'forms' => { 'submit' => 'Submit', 'cancel' => 'Cancel' }, # ... hundreds more keys
     # Simulate ~2000 translation keys
-    **1000.times.map { |i| ["key_#{i}", "Value #{i}"] }.to_h
+    **1000.times.to_h { |i| ["key_#{i}", "Value #{i}"] }
   }
 }
 
diff --git a/scripts/categorize_and_fix_specs.rb b/scripts/categorize_and_fix_specs.rb
diff --git a/scripts/refactor_test_specs.rb b/scripts/refactor_test_specs.rb
diff --git a/spec/features/invitations/platform_invitation_create_spec.rb b/spec/features/invitations/platform_invitation_create_spec.rb
@@ -1,20 +1,3 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
-
-RSpec.describe 'creating a platform invitation', :as_platform_manager do
-  let!(:host_platform) do
-  end
-  let(:invitee_email) { Faker::Internet.unique.email }
-
-  before do
-    within '#newInvitationModal' do
-      select 'Platform Invitation', from: 'platform_invitation[type]'
-      select 'Community Facilitator', from: 'platform_invitation[community_role_id]'
-      select 'Platform Manager', from: 'platform_invitation[platform_role_id]'
-      fill_in 'platform_invitation[invitee_email]', with: invitee_email
-      click_button 'Invite'
-    end
-    expect(page).to have_content(invitee_email)
-  end
-end
diff --git a/spec/requests/better_together/geography/countries_controller_spec.rb b/spec/requests/better_together/geography/countries_controller_spec.rb
@@ -4,6 +4,7 @@
 
 RSpec.describe 'BetterTogether::Geography::CountriesController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../host/geography/countries' do
     it 'renders index' do
       get better_together.geography_countries_path(locale:)
diff --git a/spec/requests/better_together/geography/region_settlements_controller_spec.rb b/spec/requests/better_together/geography/region_settlements_controller_spec.rb
@@ -4,6 +4,7 @@
 
 RSpec.describe 'BetterTogether::Geography::RegionSettlementsController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../host/geography/region_settlements' do
     it 'renders index' do
       get better_together.geography_region_settlements_path(locale:)
diff --git a/spec/requests/better_together/geography/regions_controller_spec.rb b/spec/requests/better_together/geography/regions_controller_spec.rb
@@ -4,6 +4,7 @@
 
 RSpec.describe 'BetterTogether::Geography::RegionsController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../host/geography/regions' do
     it 'renders index' do
       get better_together.geography_regions_path(locale:)
diff --git a/spec/requests/better_together/geography/settlements_controller_spec.rb b/spec/requests/better_together/geography/settlements_controller_spec.rb
@@ -4,6 +4,7 @@
 
 RSpec.describe 'BetterTogether::Geography::SettlementsController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../host/geography/settlements' do
     it 'renders index' do
       get better_together.geography_settlements_path(locale:)
diff --git a/spec/requests/better_together/geography/states_controller_spec.rb b/spec/requests/better_together/geography/states_controller_spec.rb
@@ -4,6 +4,7 @@
 
 RSpec.describe 'BetterTogether::Geography::StatesController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../host/geography/states' do
     it 'renders index' do
       get better_together.geography_states_path(locale:)
diff --git a/spec/requests/better_together/joatu/matchmaking_spec.rb b/spec/requests/better_together/joatu/matchmaking_spec.rb
@@ -18,6 +18,7 @@
     end
   end
   let(:locale) { I18n.default_locale }
+
   describe 'GET /exchange/requests/:id/matches' do # rubocop:todo RSpec/MultipleMemoizedHelpers
     it 'renders matching offers' do
       get "/#{locale}/exchange/requests/#{request_model.id}/matches"
diff --git a/spec/requests/better_together/joatu/requests_spec.rb b/spec/requests/better_together/joatu/requests_spec.rb
@@ -5,7 +5,7 @@
 # rubocop:disable Metrics/BlockLength
 RSpec.describe 'BetterTogether::Joatu::Requests', :as_user do
   include AutomaticTestConfiguration
-  
+
   let(:locale) { I18n.default_locale }
   let(:user) { find_or_create_test_user('user@example.test', 'password12345', :user) }
   let(:person) { user.person }
diff --git a/spec/requests/better_together/metrics/link_click_reports_controller_spec.rb b/spec/requests/better_together/metrics/link_click_reports_controller_spec.rb
@@ -2,9 +2,9 @@
 
 require 'rails_helper'
 
-# rubocop:todo Metrics/BlockLength
 RSpec.describe 'BetterTogether::Metrics::LinkClickReportsController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../metrics/link_click_reports' do
     it 'renders index' do
       get better_together.metrics_link_click_reports_path(locale:)
@@ -35,4 +35,3 @@
     end
   end
 end
-# rubocop:enable Metrics/BlockLength
diff --git a/spec/requests/better_together/metrics/link_click_reports_download_spec.rb b/spec/requests/better_together/metrics/link_click_reports_download_spec.rb
@@ -7,6 +7,7 @@
   # rubocop:todo RSpec/MultipleExpectations
   it 'downloads an attached report file' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
     # rubocop:enable RSpec/MultipleExpectations
+
     report = BetterTogether::Metrics::LinkClickReport.create!(file_format: 'csv')
     report.report_file.attach(
       io: StringIO.new('a,b\n1,2\n'),
diff --git a/spec/requests/better_together/metrics/page_view_reports_controller_spec.rb b/spec/requests/better_together/metrics/page_view_reports_controller_spec.rb
@@ -2,9 +2,9 @@
 
 require 'rails_helper'
 
-# rubocop:todo Metrics/BlockLength
 RSpec.describe 'BetterTogether::Metrics::PageViewReportsController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../metrics/page_view_reports' do
     it 'renders index' do
       get better_together.metrics_page_view_reports_path(locale:)
@@ -35,4 +35,3 @@
     end
   end
 end
-# rubocop:enable Metrics/BlockLength
diff --git a/spec/requests/better_together/metrics/page_view_reports_download_spec.rb b/spec/requests/better_together/metrics/page_view_reports_download_spec.rb
@@ -7,6 +7,7 @@
   # rubocop:todo RSpec/MultipleExpectations
   it 'downloads an attached report file' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
     # rubocop:enable RSpec/MultipleExpectations
+
     report = BetterTogether::Metrics::PageViewReport.create!(file_format: 'csv')
     report.report_file.attach(
       io: StringIO.new('col1,col2\n1,2\n'),
diff --git a/spec/requests/better_together/navigation_items_controller_spec.rb b/spec/requests/better_together/navigation_items_controller_spec.rb
@@ -6,6 +6,7 @@
   let(:locale) { I18n.default_locale }
   let(:user) { create(:better_together_user, :confirmed, :platform_manager) }
   let!(:navigation_area) { create(:better_together_navigation_area) }
+
   describe 'GET /:locale/.../navigation_areas/:navigation_area_id/navigation_items' do
     it 'returns ok for index' do
       get better_together.navigation_area_navigation_items_path(
diff --git a/spec/requests/better_together/people_controller_spec.rb b/spec/requests/better_together/people_controller_spec.rb
@@ -4,6 +4,7 @@
 
 RSpec.describe 'BetterTogether::PeopleController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../host/p/:id' do
     let!(:person) { create(:better_together_person) }
 
diff --git a/spec/requests/better_together/person_community_memberships_controller_spec.rb b/spec/requests/better_together/person_community_memberships_controller_spec.rb
@@ -5,6 +5,7 @@
 # rubocop:todo Metrics/BlockLength
 RSpec.describe 'BetterTogether::PersonCommunityMembershipsController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'POST /:locale/.../host/communities/:community_id/person_community_memberships' do
     # rubocop:todo RSpec/ExampleLength
     # rubocop:todo RSpec/MultipleExpectations
diff --git a/spec/requests/better_together/roles_controller_spec.rb b/spec/requests/better_together/roles_controller_spec.rb
@@ -4,6 +4,7 @@
 
 RSpec.describe 'BetterTogether::RolesController', :as_platform_manager do
   let(:locale) { I18n.default_locale }
+
   describe 'GET /:locale/.../host/roles' do
     it 'renders index' do
       get better_together.roles_path(locale:)
diff --git a/spec/support/automatic_test_configuration.rb b/spec/support/automatic_test_configuration.rb
@@ -114,13 +114,12 @@ def use_auth_method_for_spec_type(example, user_type)
 
     if controller_spec_type?(example)
       # Use Devise test helpers for controller specs
-      if user_type == :manager
-        user = find_or_create_test_user('manager@example.test', 'password12345', :platform_manager)
-        sign_in user
-      else
-        user = find_or_create_test_user('user@example.test', 'password12345', :user)
-        sign_in user
-      end
+      user = if user_type == :manager
+               find_or_create_test_user('manager@example.test', 'password12345', :platform_manager)
+             else
+               find_or_create_test_user('user@example.test', 'password12345', :user)
+             end
+      sign_in user
     elsif feature_spec_type?(example)
       # Use Capybara navigation for feature specs
       extend BetterTogether::CapybaraFeatureHelpers unless respond_to?(:capybara_login_as_platform_manager)
diff --git a/spec/support/better_together/capybara_feature_helpers.rb b/spec/support/better_together/capybara_feature_helpers.rb
@@ -38,7 +38,7 @@ def capybara_login_as_platform_manager
     end
 
     def capybara_login_as_user
-      capybara_sign_in_user('user@example.test', 'password12345')  
+      capybara_sign_in_user('user@example.test', 'password12345')
     end
 
     def capybara_sign_in_user(email, password)

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# Debug script to investigate the navigation areas controller issue`
`2`	`4`
`3`	`5`	`require 'rails_helper'`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#!/usr/bin/env ruby`
	`2`	`+# frozen_string_literal: true`
`2`	`3`
`3`	`4`	`# Performance analysis script for I18n JavaScript optimization`
`4`	`5`	`require 'json'`
`@@ -13,7 +14,7 @@`
`13`	`14`	`'navigation' => { 'home' => 'Home', 'about' => 'About' }, # ... hundreds more keys`
`14`	`15`	`'forms' => { 'submit' => 'Submit', 'cancel' => 'Cancel' }, # ... hundreds more keys`
`15`	`16`	`# Simulate ~2000 translation keys`
`16`		`- **1000.times.map { \|i\| ["key_#{i}", "Value #{i}"] }.to_h`
	`17`	`+ **1000.times.to_h { \|i\| ["key_#{i}", "Value #{i}"] }`
`17`	`18`	`}`
`18`	`19`	`}`
`19`	`20`