Enhance/load times (#1126)

This pull request introduces several improvements to the Better Together
platform, focusing on enhanced filtering, sorting, and pagination for
pages and platform invitations, as well as UI and performance
enhancements. The changes include new backend logic for filtering and
sorting collections, improved pagination styling, and better preloading
of associations to optimize queries.

### Platform Invitations: Filtering, Sorting, and Pagination

* Added comprehensive filtering and sorting logic to the
`PlatformInvitationsController`, allowing invitations to be filtered by
status, email, date fields, and sorted by multiple attributes.
Pagination is now applied to the invitations list for better usability.
[[1]](diffhunk://#diff-5197dbd0633c5f56fd1b09d798ff9a5c902c5fbabe36ada2107c0a2ba580cb95R10-R35)
[[2]](diffhunk://#diff-5197dbd0633c5f56fd1b09d798ff9a5c902c5fbabe36ada2107c0a2ba580cb95R148-R260)
* Updated controller actions for create, destroy, and resend to
consistently redirect to the invitations index page and improved error
handling for form submissions.
[[1]](diffhunk://#diff-5197dbd0633c5f56fd1b09d798ff9a5c902c5fbabe36ada2107c0a2ba580cb95L22-R74)
[[2]](diffhunk://#diff-5197dbd0633c5f56fd1b09d798ff9a5c902c5fbabe36ada2107c0a2ba580cb95L57-R104)
[[3]](diffhunk://#diff-5197dbd0633c5f56fd1b09d798ff9a5c902c5fbabe36ada2107c0a2ba580cb95L88-R126)

### Pages: Filtering, Sorting, and Performance

* Refactored the `PagesController` to support filtering by title and
slug, sorting by various attributes, and paginating results. Content
blocks are now preloaded with their associations for improved
performance.
[[1]](diffhunk://#diff-f88a9949466215662c8d25574d12de2b72ccc9af3d089d6b847eea3b6cb33f5fL17-R30)
[[2]](diffhunk://#diff-f88a9949466215662c8d25574d12de2b72ccc9af3d089d6b847eea3b6cb33f5fR165-R251)
* Simplified and modularized permitted parameters for page creation and
update, improving maintainability and clarity.

### UI and Styles

* Added a new `pagination.scss` file and imported it into the main
stylesheet, providing custom styles for pagination components and
enhancing accessibility and responsiveness.
[[1]](diffhunk://#diff-5499b5855ee11d3be02ebb1d25ee68dbe0331c7a2fc94250b73f716f42b803c6R39)
[[2]](diffhunk://#diff-75ee5cb95b10419a7583f3d14d33fe4db015a119b41b60e9094959e658cdc0dfR1-R79)

### Performance

* Improved performance in the events controller by removing unnecessary
preloading of text translations for events.

### Cleanup

* Removed the unused `event_datetime_controller.js` file, cleaning up
legacy code related to event time synchronization.

Author: rsmithlal

app/assets/javascripts/better_together/controllers/event_datetime_controller.js

@@ -36,6 +36,7 @@
 @use 'metrics';
 @use 'navigation';
 @use 'notifications';
+@use 'pagination';
 @use 'profiles';
 @use 'share';
 @use 'sidebar_nav';

app/assets/stylesheets/better_together/application.scss

@@ -0,0 +1,79 @@
+/* Better Together Pagination Styles */
+.pagination {
+  --bs-pagination-padding-x: 0.75rem;
+  --bs-pagination-padding-y: 0.5rem;
+  --bs-pagination-font-size: 0.875rem;
+  --bs-pagination-color: var(--bs-link-color);
+  --bs-pagination-bg: transparent;
+  --bs-pagination-border-width: 0;
+  --bs-pagination-border-color: transparent;
+  --bs-pagination-border-radius: 0.375rem;
+  --bs-pagination-hover-color: var(--bs-primary);
+  --bs-pagination-hover-bg: var(--bs-gray-100);
+  --bs-pagination-hover-border-color: transparent;
+  --bs-pagination-focus-color: var(--bs-primary);
+  --bs-pagination-focus-bg: var(--bs-gray-100);
+  --bs-pagination-focus-box-shadow: 0 0 0 0.25rem rgba(var(--bs-primary-rgb), 0.25);
+  --bs-pagination-active-color: #fff;
+  --bs-pagination-active-bg: var(--bs-primary);
+  --bs-pagination-active-border-color: var(--bs-primary);
+  --bs-pagination-disabled-color: var(--bs-secondary-color);
+  --bs-pagination-disabled-bg: transparent;
+  --bs-pagination-disabled-border-color: transparent;
+}
+
+.pagination-info {
+  display: flex;
+  align-items: center;
+  min-height: 2rem;
+}
+
+.pagination-info small {
+  font-weight: 500;
+  letter-spacing: 0.025em;
+}
+
+/* Responsive pagination */
+@media (max-width: 768px) {
+  .pagination-info {
+    margin-bottom: 0.75rem;
+    text-align: center;
+    width: 100%;
+  }
+  
+  .pagination {
+    justify-content: center !important;
+  }
+  
+  .d-flex.justify-content-between.align-items-center.flex-wrap {
+    flex-direction: column;
+    align-items: center;
+  }
+}
+
+/* Enhanced focus states for accessibility */
+.page-link:focus {
+  outline: 2px solid transparent;
+  outline-offset: 2px;
+}
+
+.page-link:focus-visible {
+  box-shadow: var(--bs-pagination-focus-box-shadow);
+  outline: 2px solid var(--bs-primary);
+  outline-offset: 2px;
+}
+
+/* Smooth transitions */
+.page-link {
+  transition: all 0.15s ease-in-out;
+}
+
+/* Card styling for pagination container */
+.pagination .card {
+  background: var(--bs-gray-50);
+  border: 1px solid var(--bs-border-color-translucent);
+}
+
+.pagination .card-body {
+  background: transparent;
+}

app/assets/stylesheets/better_together/pagination.scss

@@ -325,7 +325,6 @@ def preload_event_associations! # rubocop:todo Metrics/CyclomaticComplexity, Met
 
       # Preload translations for the event itself
       @event.string_translations.load
-      @event.text_translations.load
 
       # Preload cover image attachment to avoid attachment queries
       @event.cover_image_attachment&.blob&.load if @event.cover_image.attached?

app/controllers/better_together/events_controller.rb

@@ -14,14 +14,20 @@ class PagesController < FriendlyResourceController # rubocop:todo Metrics/ClassL
 
     def index
       authorize resource_class
-      @pages = resource_collection
+
+      @pages = build_filtered_collection
+      @pages = apply_sorting(@pages)
+      @pages = @pages.page(params[:page]).per(25)
     end
 
     def show
       # Hide pages that don't exist or aren't viewable to the current user as 404s
       render_not_found and return if @page.nil?
 
-      @content_blocks = @page.content_blocks
+      # Preload content blocks with their associations for better performance
+      @content_blocks = @page.content_blocks.includes(
+        background_image_file_attachment: :blob
+      )
       @layout = 'layouts/better_together/page'
       @layout = @page.layout if @page.layout.present?
     end
@@ -141,29 +147,13 @@ def safe_page_redirect_url
 
     def set_page
       @page = set_resource_instance
+      return unless @page
+
+      @page = preload_page_associations(@page)
     rescue ActiveRecord::RecordNotFound
       render_not_found && return
     end
 
-    def page_params # rubocop:todo Metrics/MethodLength
-      params.require(:page).permit(
-        :meta_description, :keywords, :published_at, :sidebar_nav_id,
-        :privacy, :layout, :template, *Page.localized_attribute_list,
-        *Page.extra_permitted_attributes,
-        page_blocks_attributes: [
-          :id, :position, :_destroy,
-          {
-            block_attributes: [
-              :id, :type, :identifier, :_destroy,
-              *BetterTogether::Content::Block.localized_block_attributes,
-              *BetterTogether::Content::Block.storext_keys,
-              *BetterTogether::Content::Block.extra_permitted_attributes
-            ]
-          }
-        ]
-      )
-    end
-
     def resource_class
       ::BetterTogether::Page
     end
@@ -172,8 +162,92 @@ def resource_collection
       policy_scope(resource_class)
     end
 
+    def apply_sorting(collection)
+      sort_by = params[:sort_by]
+      sort_direction = params[:sort_direction] == 'desc' ? :desc : :asc
+
+      case sort_by
+      when 'title', 'slug'
+        collection.i18n.order(sort_by.to_sym => sort_direction)
+      else
+        collection.order(collection.arel_table[:identifier].send(sort_direction))
+      end
+    end
+
+    def build_filtered_collection
+      collection = base_collection
+      collection = apply_title_filter(collection) if params[:title_filter].present?
+      collection = apply_slug_filter(collection) if params[:slug_filter].present?
+      collection
+    end
+
     def translatable_conditions
       []
     end
+
+    def base_collection
+      resource_collection.includes(
+        :string_translations,
+        page_blocks: {
+          block: [{ background_image_file_attachment: :blob }]
+        }
+      )
+    end
+
+    def apply_title_filter(collection)
+      search_term = params[:title_filter].strip
+      collection.i18n { title.matches("%#{search_term}%") }
+    end
+
+    def apply_slug_filter(collection)
+      search_term = params[:slug_filter].strip
+      collection.i18n { slug.matches("%#{search_term}%") }
+    end
+
+    def preload_page_associations(page)
+      resource_class.includes(page_includes).find(page.id)
+    end
+
+    def page_includes
+      [
+        :string_translations,
+        :sidebar_nav,
+        { page_blocks: {
+          block: [{ background_image_file_attachment: :blob }]
+        } }
+      ]
+    end
+
+    def page_params
+      params.require(:page).permit(
+        basic_page_attributes + page_blocks_permitted_attributes
+      )
+    end
+
+    def basic_page_attributes
+      [
+        :meta_description, :keywords, :published_at, :sidebar_nav_id,
+        :privacy, :layout, :template, *Page.localized_attribute_list,
+        *Page.extra_permitted_attributes
+      ]
+    end
+
+    def page_blocks_permitted_attributes
+      [
+        page_blocks_attributes: [
+          :id, :position, :_destroy,
+          { block_attributes: block_permitted_attributes }
+        ]
+      ]
+    end
+
+    def block_permitted_attributes
+      [
+        :id, :type, :identifier, :_destroy,
+        *BetterTogether::Content::Block.localized_block_attributes,
+        *BetterTogether::Content::Block.storext_keys,
+        *BetterTogether::Content::Block.extra_permitted_attributes
+      ]
+    end
   end
 end