Rubocop fixes

Author: rsmithlal

app/models/better_together/navigation_item.rb

@@ -82,9 +82,7 @@ def self.route_name_urls
       pages = BetterTogether::Page.arel_table
 
       # Construct the LEFT OUTER JOIN condition
-      # rubocop:todo Layout/LineLength
       join_condition = navigation_items[:linkable_type].eq('BetterTogether::Page').and(navigation_items[:linkable_id].eq(pages[:id]))
-      # rubocop:enable Layout/LineLength
       join = navigation_items
              .join(pages, Arel::Nodes::OuterJoin)
              .on(join_condition)

app/models/better_together/page.rb

@@ -49,15 +49,11 @@ class Page < ApplicationRecord
     scope :by_publication_date, -> { order(published_at: :desc) }
 
     def hero_block
-      # rubocop:todo Layout/LineLength
       @hero_block ||= blocks.where(type: 'BetterTogether::Content::Hero').with_attached_background_image_file.with_translations.first
-      # rubocop:enable Layout/LineLength
     end
 
     def content_blocks
-      # rubocop:todo Layout/LineLength
       @content_blocks ||= blocks.where.not(type: 'BetterTogether::Content::Hero').with_attached_background_image_file.with_translations
-      # rubocop:enable Layout/LineLength
     end
 
     # Customize the data sent to Elasticsearch for indexing

app/models/concerns/better_together/primary_flag.rb

@@ -19,7 +19,9 @@ def extra_permitted_attributes
         super + [:primary_flag]
       end
 
-      def has_primary_for(parent_id) # rubocop:todo Naming/PredicatePrefix
+      # rubocop:todo Naming/PredicateMethod
+      def has_primary_for(parent_id) # rubocop:todo Naming/PredicatePrefix, Naming/PredicateMethod
+        # rubocop:enable Naming/PredicateMethod
         return false unless parent_id && primary_flag_scope_key
 
         where(primary_flag: true, primary_flag_scope_key => parent_id).exists?