Skip to content

Commit c1b3896

Browse files
committed
Fix bug preventing dependent nav item fields from toggling correctly
1 parent 11b166a commit c1b3896

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

app/views/better_together/navigation_items/_form.html.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@
5151
</div>
5252

5353
<!-- Control field for linkable_id -->
54-
<div class="bt-mb-3" data-better_together--dependent-fields-target="dependentField" data-dependent-fields-control="navigation_item_route_name" data-show-if-control_navigation_item_route_name="*not_present*">
54+
<div id="nav-item-linkable" class="bt-mb-3" data-better_together--dependent-fields-target="dependentField" data-dependent-fields-control="navigation_item_route_name" data-show-if-control_navigation_item_route_name="*not_present*">
5555
<%= form.label :linkable_id, 'Link to Page' %>
56-
<%= form.collection_select :linkable_id, @pages, :id, :select_option_title, { include_blank: true }, { class: ('form-select' + (@navigation_item.errors[:linkable_id].any? ? ' is-invalid' : '')), data: { controller: "better_together--slim-select" }, 'data-better_together--dependent-fields-target' => "controlField" } %>
56+
<%= form.collection_select :linkable_id, @pages, :id, :select_option_title, { include_blank: true }, { id: 'navigation_item_linkable_id', class: ('form-select' + (@navigation_item.errors[:linkable_id].any? ? ' is-invalid' : '')), data: { controller: "better_together--slim-select" }, 'data-better_together--dependent-fields-target' => "controlField" } %>
5757
<% if @navigation_item.errors[:linkable_id].any? %>
5858
<div class="invalid-feedback">
5959
<%= @navigation_item.errors[:linkable_id].join(", ") %>
@@ -70,7 +70,7 @@
7070
<!-- Dependent field 2 (shown when no value is present) -->
7171
<div id="nav-item-route-name" class="bt-mb-3" data-better_together--dependent-fields-target="dependentField" data-dependent-fields-control="navigation_item_linkable_id" data-show-if-control_navigation_item_linkable_id="*not_present*">
7272
<%= form.label :route_name, "Dynamic Route" %>
73-
<%= form.select :route_name, route_names_for_select(@navigation_item), { include_blank: true }, { class: 'form-select', 'data-better_together--dependent-fields-target' => "controlField", data: { controller: "better_together--slim-select" } } %>
73+
<%= form.select :route_name, route_names_for_select(@navigation_item), { include_blank: true }, { id: 'navigation_item_route_name', class: 'form-select', 'data-better_together--dependent-fields-target' => "controlField", data: { controller: "better_together--slim-select" } } %>
7474
<% if @navigation_item.errors[:linkable_id].any? %>
7575
<div class="invalid-feedback">
7676
<%= @navigation_item.errors[:linkable_id].join(", ") %>

0 commit comments

Comments
 (0)