feat(translations): add unique translated records statistics and improve overview layout

rsmithlal · rsmithlal · commit c23cb277217e · 2025-10-20T19:56:26.000-02:30
diff --git a/app/controllers/better_together/translations_controller.rb b/app/controllers/better_together/translations_controller.rb
@@ -6,7 +6,7 @@ def index
       # For overview tab - prepare statistics data
       @available_locales = I18n.available_locales.map(&:to_s)
       @available_model_types = collect_all_model_types
-      @available_attributes = collect_available_attributes('all')
+      @available_attributes = collect_all_attributes
 
       @data_type_summary = build_data_type_summary
       @data_type_stats = calculate_data_type_stats
@@ -16,6 +16,7 @@ def index
       @model_type_stats = calculate_model_type_stats
       @attribute_stats = calculate_attribute_stats
       @total_translation_records = calculate_total_records
+      @unique_translated_records = calculate_unique_translated_records
 
       # Calculate model instance translation coverage
       @model_instance_stats = calculate_model_instance_stats
@@ -98,9 +99,22 @@ def collect_all_model_types
       collect_rich_text_translation_models(model_types)
       collect_file_translation_models(model_types)
 
-      # Convert to array and constantize
+      # Convert to array, constantize, and filter for models with actual translatable attributes
       model_types.map do |type_name|
-        { name: type_name, class: type_name.constantize }
+        model_class = type_name.constantize
+
+        # Load subclasses to ensure STI descendants are available
+        load_subclasses(model_class)
+
+        # Check if the model actually has translatable attributes
+        has_translatable_attributes = has_translatable_attributes?(model_class)
+
+        if has_translatable_attributes
+          { name: type_name, class: model_class }
+        else
+          Rails.logger.debug "Skipping #{type_name}: no translatable attributes found"
+          nil
+        end
       rescue StandardError => e
         Rails.logger.warn "Could not constantize model type #{type_name}: #{e.message}"
         nil
@@ -338,20 +352,55 @@ def collect_text_translation_models(model_types)
     def collect_rich_text_translation_models(model_types)
       return unless defined?(ActionText::RichText)
 
+      # Get unique combinations of record_type and name to validate translatable attributes
       ActionText::RichText
         .distinct
-        .pluck(:record_type)
-        .each { |type| model_types.add(type) }
+        .pluck(:record_type, :name)
+        .each do |record_type, attribute_name|
+          next unless record_type.present? && attribute_name.present?
+
+          begin
+            model_class = record_type.constantize
+            load_subclasses(model_class)
+
+            # Check if this specific attribute is translatable in the model or its descendants
+            if has_translatable_rich_text_attribute?(model_class, attribute_name)
+              model_types.add(record_type)
+            else
+              Rails.logger.debug "Skipping #{record_type}: attribute '#{attribute_name}' not found in translatable rich text attributes"
+            end
+          rescue StandardError => e
+            Rails.logger.warn "Could not check rich text translatability for #{record_type}: #{e.message}"
+          end
+        end
     end
 
     def collect_file_translation_models(model_types)
       return unless defined?(ActiveStorage::Attachment) &&
                     ActiveStorage::Attachment.column_names.include?('locale')
 
+      # Get unique combinations of record_type and name to validate translatable attachments
       ActiveStorage::Attachment
+        .where.not(locale: [nil, '']) # Only include records with actual locale values
         .distinct
-        .pluck(:record_type)
-        .each { |type| model_types.add(type) }
+        .pluck(:record_type, :name)
+        .each do |record_type, attachment_name|
+          next unless record_type.present? && attachment_name.present?
+
+          begin
+            model_class = record_type.constantize
+            load_subclasses(model_class)
+
+            # Check if this specific attachment is translatable in the model or its descendants
+            if has_translatable_attachment?(model_class, attachment_name)
+              model_types.add(record_type)
+            else
+              Rails.logger.debug "Skipping #{record_type}: attachment '#{attachment_name}' not found in translatable attachments"
+            end
+          rescue StandardError => e
+            Rails.logger.warn "Could not check file translatability for #{record_type}: #{e.message}"
+          end
+        end
     end
 
     def group_models_by_namespace(models)
@@ -624,6 +673,45 @@ def calculate_total_records
       count
     end
 
+    def calculate_unique_translated_records
+      unique_records = Set.new
+
+      # Collect unique (model_type, record_id) pairs from string translations
+      if defined?(Mobility::Backends::ActiveRecord::KeyValue::StringTranslation)
+        Mobility::Backends::ActiveRecord::KeyValue::StringTranslation
+          .distinct
+          .pluck(:translatable_type, :translatable_id)
+          .each { |type, id| unique_records.add([type, id]) }
+      end
+
+      # Collect from text translations
+      if defined?(Mobility::Backends::ActiveRecord::KeyValue::TextTranslation)
+        Mobility::Backends::ActiveRecord::KeyValue::TextTranslation
+          .distinct
+          .pluck(:translatable_type, :translatable_id)
+          .each { |type, id| unique_records.add([type, id]) }
+      end
+
+      # Collect from rich text translations
+      if defined?(ActionText::RichText)
+        ActionText::RichText
+          .distinct
+          .pluck(:record_type, :record_id)
+          .each { |type, id| unique_records.add([type, id]) }
+      end
+
+      # Collect from file translations
+      if defined?(ActiveStorage::Attachment) && ActiveStorage::Attachment.column_names.include?('locale')
+        ActiveStorage::Attachment
+          .where.not(locale: [nil, ''])
+          .distinct
+          .pluck(:record_type, :record_id)
+          .each { |type, id| unique_records.add([type, id]) }
+      end
+
+      unique_records.size
+    end
+
     # Calculate unique model instance translation coverage
     def calculate_model_instance_stats
       stats = {}
@@ -1098,6 +1186,15 @@ def collect_all_attributes
           .each { |attr| attributes.add(attr) }
       end
 
+      # Collect from file translations (ActiveStorage attachments with locale)
+      if defined?(ActiveStorage::Attachment) && ActiveStorage::Attachment.column_names.include?('locale')
+        ActiveStorage::Attachment
+          .where.not(locale: [nil, ''])
+          .distinct
+          .pluck(:name)
+          .each { |attr| attributes.add(attr) }
+      end
+
       attributes.to_a.sort
     end
 
@@ -1193,5 +1290,68 @@ def load_subclasses(model_class)
     rescue StandardError => e
       Rails.logger.warn "Error loading subclasses for #{model_class.name}: #{e.message}"
     end
+
+    # Check if a model class has any translatable attributes (including STI descendants)
+    def has_translatable_attributes?(model_class)
+      # Check mobility attributes on the model itself
+      return true if model_class.respond_to?(:mobility_attributes) && model_class.mobility_attributes.any?
+
+      # Check translatable attachments on the model itself
+      if model_class.respond_to?(:mobility_translated_attachments) && model_class.mobility_translated_attachments&.any?
+        return true
+      end
+
+      # For STI models, check descendants
+      if model_class.respond_to?(:descendants) && model_class.descendants.any?
+        model_class.descendants.each do |subclass|
+          return true if subclass.respond_to?(:mobility_attributes) && subclass.mobility_attributes.any?
+          if subclass.respond_to?(:mobility_translated_attachments) && subclass.mobility_translated_attachments&.any?
+            return true
+          end
+        end
+      end
+
+      false
+    end
+
+    # Check if a model has a specific translatable rich text attribute
+    def has_translatable_rich_text_attribute?(model_class, attribute_name)
+      # Check if the model has this attribute configured for Action Text translation
+      if model_class.respond_to?(:mobility_attributes)
+        mobility_configs = model_class.mobility.attributes_hash
+        return true if mobility_configs[attribute_name.to_sym]&.dig(:backend) == :action_text
+      end
+
+      # Check STI descendants
+      if model_class.respond_to?(:descendants) && model_class.descendants.any?
+        model_class.descendants.each do |subclass|
+          next unless subclass.respond_to?(:mobility_attributes)
+
+          mobility_configs = subclass.mobility.attributes_hash
+          return true if mobility_configs[attribute_name.to_sym]&.dig(:backend) == :action_text
+        end
+      end
+
+      false
+    end
+
+    # Check if a model has a specific translatable attachment
+    def has_translatable_attachment?(model_class, attachment_name)
+      # Check if the model has this attachment configured as translatable
+      if model_class.respond_to?(:mobility_translated_attachments)
+        return model_class.mobility_translated_attachments&.key?(attachment_name.to_sym)
+      end
+
+      # Check STI descendants
+      if model_class.respond_to?(:descendants) && model_class.descendants.any?
+        model_class.descendants.each do |subclass|
+          if subclass.respond_to?(:mobility_translated_attachments) && subclass.mobility_translated_attachments&.key?(attachment_name.to_sym)
+            return true
+          end
+        end
+      end
+
+      false
+    end
   end
 end
diff --git a/app/views/better_together/translations/_overview.html.erb b/app/views/better_together/translations/_overview.html.erb
@@ -11,31 +11,39 @@
       </div>
       <div class="card-body">
         <div class="row text-center">
-          <div class="col-md-3 mb-3">
+          <div class="col-lg-2 col-md-4 col-sm-6 mb-3">
             <div class="border rounded p-3">
               <h3 class="text-primary mb-0">
                 <%= number_with_delimiter(@total_translation_records || 0) %>
               </h3>
               <small class="text-muted"><%= t('.total_translation_records') %></small>
             </div>
           </div>
-          <div class="col-md-3 mb-3">
+          <div class="col-lg-2 col-md-4 col-sm-6 mb-3">
+            <div class="border rounded p-3">
+              <h3 class="text-secondary mb-0">
+                <%= number_with_delimiter(@unique_translated_records || 0) %>
+              </h3>
+              <small class="text-muted"><%= t('.unique_translated_records') %></small>
+            </div>
+          </div>
+          <div class="col-lg-2 col-md-4 col-sm-6 mb-3">
             <div class="border rounded p-3">
               <h3 class="text-success mb-0">
                 <%= @available_locales&.size || 0 %>
               </h3>
               <small class="text-muted"><%= t('.supported_locales') %></small>
             </div>
           </div>
-          <div class="col-md-3 mb-3">
+          <div class="col-lg-2 col-md-4 col-sm-6 mb-3">
             <div class="border rounded p-3">
               <h3 class="text-info mb-0">
                 <%= @available_model_types&.size || 0 %>
               </h3>
               <small class="text-muted"><%= t('.translatable_models') %></small>
             </div>
           </div>
-          <div class="col-md-3 mb-3">
+          <div class="col-lg-2 col-md-4 col-sm-6 mb-3">
             <div class="border rounded p-3">
               <h3 class="text-warning mb-0">
                 <%= @available_attributes&.size || 0 %>
@@ -173,7 +181,7 @@
       </div>
       <div class="card-body">
         <% if @attribute_stats&.any? %>
-          <% @attribute_stats.first(10).each do |attribute, count| %>
+          <% @attribute_stats.each do |attribute, count| %>
             <div class="d-flex justify-content-between align-items-center mb-2">
               <span class="badge bg-warning text-dark">
                 <%= attribute %>
@@ -183,13 +191,6 @@
               </span>
             </div>
           <% end %>
-          <% if @attribute_stats.size > 10 %>
-            <div class="text-center mt-3">
-              <small class="text-muted">
-                <%= t('.and_more_attributes', count: @attribute_stats.size - 10) %>
-              </small>
-            </div>
-          <% end %>
         <% else %>
           <p class="text-muted"><%= t('.no_attribute_data') %></p>
         <% end %>
@@ -248,7 +249,7 @@
                 <% if stats[:attribute_coverage]&.any? %>
                   <h6 class="small text-muted mb-2"><%= t('.attribute_coverage_title') %></h6>
                   <div class="attribute-coverage">
-                    <% stats[:attribute_coverage].first(5).each do |attr, attr_stats| %>
+                    <% stats[:attribute_coverage].each do |attr, attr_stats| %>
                       <div class="d-flex justify-content-between align-items-center mb-1">
                         <span class="badge text-bg-<%= attr_stats[:attribute_type] == 'file' ? 'info' : 'secondary' %> small">
                           <%= attr %>
@@ -259,13 +260,6 @@
                         </small>
                       </div>
                     <% end %>
-                    <% if stats[:attribute_coverage].size > 5 %>
-                      <div class="text-center mt-2">
-                        <small class="text-muted">
-                          <%= t('.and_more_attributes', count: stats[:attribute_coverage].size - 5) %>
-                        </small>
-                      </div>
-                    <% end %>
                   </div>
                 <% elsif stats[:total_instances] == 0 %>
                   <p class="small text-muted text-center">
diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -1515,6 +1515,7 @@ en:
         no_attribute_data: No attribute data available
         and_more_attributes: "and %{count} more attributes..."
         total_translation_records: Total Translation Records
+        unique_translated_records: Unique Translated Records
         supported_locales: Supported Locales
         translatable_models: Translatable Models
         unique_attributes: Unique Attributes
@@ -1568,6 +1569,7 @@ en:
         no_attribute_data: No attribute data available
         and_more_attributes: "and %{count} more attributes..."
         total_translation_records: Total Translation Records
+        unique_translated_records: Unique Translated Records
         supported_locales: Supported Locales
         translatable_models: Translatable Models
         unique_attributes: Unique Attributes
diff --git a/config/locales/es.yml b/config/locales/es.yml
@@ -1526,6 +1526,7 @@ es:
         no_attribute_data: No hay datos de atributo disponibles
         and_more_attributes: "y %{count} atributos más..."
         total_translation_records: Total de Registros de Traducción
+        unique_translated_records: Registros Traducidos Únicos
         supported_locales: Idiomas Soportados
         translatable_models: Modelos Traducibles
         unique_attributes: Atributos Únicos
@@ -1579,6 +1580,7 @@ es:
         no_attribute_data: No hay datos de atributo disponibles
         and_more_attributes: "y %{count} atributos más..."
         total_translation_records: Total de Registros de Traducción
+        unique_translated_records: Registros Traducidos Únicos
         supported_locales: Idiomas Soportados
         translatable_models: Modelos Traducibles
         unique_attributes: Atributos Únicos
diff --git a/config/locales/fr.yml b/config/locales/fr.yml
@@ -1534,6 +1534,7 @@ fr:
         no_attribute_data: Aucune donnée d'attribut disponible
         and_more_attributes: "et %{count} attributs de plus..."
         total_translation_records: Total des Enregistrements de Traduction
+        unique_translated_records: Enregistrements Traduits Uniques
         supported_locales: Langues Supportées
         translatable_models: Modèles Traduisibles
         unique_attributes: Attributs Uniques
@@ -1587,6 +1588,7 @@ fr:
         no_attribute_data: Aucune donnée d'attribut disponible
         and_more_attributes: "et %{count} attributs de plus..."
         total_translation_records: Total des Enregistrements de Traduction
+        unique_translated_records: Enregistrements Traduits Uniques
         supported_locales: Langues Supportées
         translatable_models: Modèles Traduisibles
         unique_attributes: Attributs Uniques
